Refactor: scheduler: drop unnecessary arguments to child_promoting_constraints()

Every caller uses pe_order_optional for the "type" argument, so drop the
argument and use that directly. The final "data_set" argument was redundant
since we have rsc->cluster.