Merge pull request #3644 from nrwahl2/nrwahl2-T838
6ec6fb6272e9
Actions

Description

Merge pull request #3644 from nrwahl2/nrwahl2-T838

[2.1] Fix: libcrmcommon: Drop xmlRegisterNodeDefault() and xmlDeregisterNodeDefault()

Details

Provenance

nrwahl2	Authored on Sep 10 2024, 8:11 PM
GitHub <noreply@github.com>	Committed on Sep 10 2024, 8:11 PM

Parents

rP6227fff7a856: Doc: Pacemaker Development: New XML section
rPed381f50edef: Merge pull request #3641 from kgaillot/backport

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP6ec6fb6272e9: Merge pull request #3644 from nrwahl2/nrwahl2-T838 (authored by nrwahl2).Sep 10 2024, 8:11 PM

Merged Changes

6227fff7a856 Doc: Pacemaker Development: New XML section
Author
nrwahl2
Browse Repository
No Audits
cd519c833277 Refactor: libcrmcommon: Drop redundant calls to pcmk__xml_mark_created()
Author
nrwahl2
Browse Repository
No Audits
446a63afffa7 Doc: libcrmcommon: Update XML unit test setup/teardown comments
Author
nrwahl2
Browse Repository
No Audits
46b540d67f39 Fix: libcrmcommon: Drop xmlRegisterNodeDefault()
Author
nrwahl2
Browse Repository
No Audits
75a2fb122c91 Refactor: libcrmcommon: Improve pcmk__xe_set_content() error checking
Author
nrwahl2
Browse Repository
No Audits
d2d50c43d0aa Refactor: libpacemaker: Limit xmlNewDocRawNode() to pcmk__xe_create()
Author
nrwahl2
Browse Repository
No Audits
8ee39aeb9ace Refactor: libcrmcommon: Avoid xmlCopyNode() and xmlDocCopyNode()
Author
nrwahl2
Browse Repository
No Audits
81ae818ea1dc Test: cts-cli: Improve a couple of replacements
Author
nrwahl2
Browse Repository
No Audits
5016f65ca670 Refactor: libcrmcommon: Move pcmk__xc functions to xml_comment.c
Author
nrwahl2
Browse Repository
No Audits
c4f9ad52103f Refactor: libcrmcommon, libpacemaker: New pcmk__xc_create()
Author
nrwahl2
Browse Repository
No Audits
32576df49829 Low: libcrmcommon: NULL-check pcmk__xml_tree_foreach() argument
Author
nrwahl2
Browse Repository
No Audits
1811031a00db Refactor: libcrmcommon: Limit xmlRemoveProp() to pcmk__xa_remove()
Author
nrwahl2
Browse Repository
No Audits
0d3c2fd6cdd5 Refactor: libcrmcommon: remove_xe_attr() -> pcmk__xa_remove()
Author
nrwahl2
Browse Repository
No Audits
d0a539400194 Refactor: libcrmcommon: Avoid xmlUnsetProp()
Author
nrwahl2
Browse Repository
No Audits
86bf474aaa75 Refactor: libcrmcommon: XML best practices in HTML output functions
Author
nrwahl2
Browse Repository
No Audits
74deba6f0ac4 Refactor: various: Limit xmlSetProp() to pcmk__xe_set_attr_force()
Author
nrwahl2
Browse Repository
No Audits
5af31585adbd Refactor: libcrmcommon: New pcmk__xml_free_doc()
Author
nrwahl2
Browse Repository
No Audits
d0f42be68161 Refactor: libcrmcommon: New pcmk__xml_new_doc()
Author
nrwahl2
Browse Repository
No Audits
c06ff6503b6b Refactor: libcrmcommon: Add XML test teardown function
Author
nrwahl2
Browse Repository
No Audits
892dfeb983ca Refactor: various: Use free_xml() instead of xmlFreeNode()
Author
nrwahl2
Browse Repository
No Audits
94206f7cc582 Refactor: libcrmcommon: Move XML private magic to lib-private header
Author
nrwahl2
Browse Repository
No Audits

Changes (64)

Path

Size

cts/

cli/

regression.acls.exp

regression.tools.exp

regression.validity.exp

cts-cli.in

doc/

sphinx/

Pacemaker_Development/

c.rst

include/

crm/

common/

unittest_internal.h

	xml_comment_internal.h
	schemas.h

xml_internal.h

crm_internal.h

lib/

common/

tests/

acl/

xml_acl_denied_test.c

xml_acl_enabled_test.c

iso8601/

pcmk__add_time_from_xml_test.c

nodes/

pcmk__xe_add_node_test.c

nvpair/

pcmk__xe_attr_is_true_test.c

pcmk__xe_get_bool_attr_test.c

pcmk__xe_get_datetime_test.c

pcmk__xe_set_bool_attr_test.c

probes/

pcmk_xe_is_probe_test.c

pcmk_xe_mask_probe_failure_test.c

rules/

pcmk__evaluate_attr_expression_test.c

pcmk__evaluate_condition_test.c

pcmk__evaluate_date_expression_test.c

pcmk__evaluate_date_spec_test.c

pcmk__evaluate_op_expression_test.c

pcmk__evaluate_rsc_expression_test.c

pcmk__unpack_duration_test.c

pcmk_evaluate_rule_test.c

schemas/

pcmk__build_schema_xml_node_test.c

xml/

Makefile.am

crm_xml_init_test.c

pcmk__xc_create_test.c

pcmk__xe_copy_attrs_test.c

pcmk__xe_first_child_test.c

pcmk__xe_foreach_child_test.c

pcmk__xe_set_score_test.c

pcmk__xml_escape_test.c

pcmk__xml_needs_escape_test.c

pcmk__xml_new_doc_test.c

pacemaker/

pcmk_sched_constraints.c

tests/

pcmk_resource/

pcmk_resource_delete_test.c

pcmk_ticket/

pcmk__get_ticket_state_test.c

pcmk_ticket_constraints_test.c

pcmk_ticket_delete_test.c

pcmk_ticket_get_attr_test.c

pcmk_ticket_info_test.c

pcmk_ticket_remove_attr_test.c

pcmk_ticket_set_attr_test.c

pcmk_ticket_state_test.c

tools/

crm_resource_print.c

rP6ec6fb6272e9

View Options

cts/cli/regression.acls.exp

View Options

cts/cli/regression.tools.exp

View Options

cts/cli/regression.validity.exp

View Options

cts/cts-cli.in

View Options

doc/sphinx/Pacemaker_Development/c.rst

View Options

include/crm/common/unittest_internal.h

View Options

include/crm/common/xml_comment_internal.h

View Options

include/crm/common/xml_internal.h

View Options

include/crm_internal.h

View Options

lib/common/Makefile.am

View Options

lib/common/acl.c

View Options

lib/common/crmcommon_private.h

View Options

lib/common/nvpair.c

View Options

lib/common/output.c

View Options

lib/common/output_html.c

View Options

lib/common/patchset.c

View Options

lib/common/schemas.c

View Options

lib/common/tests/acl/xml_acl_denied_test.c

View Options

lib/common/tests/acl/xml_acl_enabled_test.c

View Options

lib/common/tests/iso8601/pcmk__add_time_from_xml_test.c

View Options

lib/common/tests/nodes/pcmk__xe_add_node_test.c

View Options

lib/common/tests/nvpair/pcmk__xe_attr_is_true_test.c

View Options

lib/common/tests/nvpair/pcmk__xe_get_bool_attr_test.c

View Options

lib/common/tests/nvpair/pcmk__xe_get_datetime_test.c

View Options

lib/common/tests/nvpair/pcmk__xe_set_bool_attr_test.c

View Options

lib/common/tests/probes/pcmk_xe_is_probe_test.c

View Options

lib/common/tests/probes/pcmk_xe_mask_probe_failure_test.c

View Options

lib/common/tests/rules/pcmk__evaluate_attr_expression_test.c

View Options

lib/common/tests/rules/pcmk__evaluate_condition_test.c

View Options

lib/common/tests/rules/pcmk__evaluate_date_expression_test.c

View Options

lib/common/tests/rules/pcmk__evaluate_date_spec_test.c

View Options

lib/common/tests/rules/pcmk__evaluate_op_expression_test.c

View Options

lib/common/tests/rules/pcmk__evaluate_rsc_expression_test.c

View Options

lib/common/tests/rules/pcmk__unpack_duration_test.c

View Options

lib/common/tests/rules/pcmk_evaluate_rule_test.c

View Options

lib/common/tests/schemas/pcmk__build_schema_xml_node_test.c

View Options

lib/common/tests/xml/Makefile.am

View Options

lib/common/tests/xml/crm_xml_init_test.c

View Options

lib/common/tests/xml/pcmk__xc_create_test.c

View Options

lib/common/tests/xml/pcmk__xe_copy_attrs_test.c

View Options

lib/common/tests/xml/pcmk__xe_first_child_test.c

View Options

lib/common/tests/xml/pcmk__xe_foreach_child_test.c

View Options

lib/common/tests/xml/pcmk__xe_set_score_test.c

View Options

lib/common/tests/xml/pcmk__xml_escape_test.c

View Options

lib/common/tests/xml/pcmk__xml_needs_escape_test.c

View Options

lib/common/tests/xml/pcmk__xml_new_doc_test.c

View Options

lib/common/unittest.c

View Options

lib/common/xml.c

View Options

lib/common/xml_attr.c

View Options

lib/common/xml_comment.c

View Options

lib/common/xml_io.c

View Options

lib/pacemaker/pcmk_acl.c

View Options

lib/pacemaker/pcmk_output.c

View Options

lib/pacemaker/pcmk_sched_constraints.c

View Options

lib/pacemaker/tests/pcmk_resource/pcmk_resource_delete_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk__get_ticket_state_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_constraints_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_delete_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_get_attr_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_info_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_remove_attr_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_set_attr_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_state_test.c

View Options

tools/crm_resource_print.c

Merge pull request #3644 from nrwahl2/nrwahl2-T8386ec6fb6272e9Actions

Description

Details

Event Timeline

Merged Changes

Changes (64)

rP6ec6fb6272e9

cts/cli/regression.acls.exp

cts/cli/regression.tools.exp

cts/cli/regression.validity.exp

cts/cts-cli.in

doc/sphinx/Pacemaker_Development/c.rst

include/crm/common/unittest_internal.h

include/crm/common/xml_comment_internal.h

include/crm/common/xml_internal.h

include/crm_internal.h

lib/common/Makefile.am

lib/common/acl.c

lib/common/crmcommon_private.h

lib/common/nvpair.c

lib/common/output.c

lib/common/output_html.c

lib/common/patchset.c

lib/common/schemas.c

lib/common/tests/acl/xml_acl_denied_test.c

lib/common/tests/acl/xml_acl_enabled_test.c

lib/common/tests/iso8601/pcmk__add_time_from_xml_test.c

lib/common/tests/nodes/pcmk__xe_add_node_test.c

lib/common/tests/nvpair/pcmk__xe_attr_is_true_test.c

lib/common/tests/nvpair/pcmk__xe_get_bool_attr_test.c

lib/common/tests/nvpair/pcmk__xe_get_datetime_test.c

lib/common/tests/nvpair/pcmk__xe_set_bool_attr_test.c

lib/common/tests/probes/pcmk_xe_is_probe_test.c

lib/common/tests/probes/pcmk_xe_mask_probe_failure_test.c

lib/common/tests/rules/pcmk__evaluate_attr_expression_test.c

lib/common/tests/rules/pcmk__evaluate_condition_test.c

lib/common/tests/rules/pcmk__evaluate_date_expression_test.c

lib/common/tests/rules/pcmk__evaluate_date_spec_test.c

lib/common/tests/rules/pcmk__evaluate_op_expression_test.c

lib/common/tests/rules/pcmk__evaluate_rsc_expression_test.c

lib/common/tests/rules/pcmk__unpack_duration_test.c

lib/common/tests/rules/pcmk_evaluate_rule_test.c

lib/common/tests/schemas/pcmk__build_schema_xml_node_test.c

lib/common/tests/xml/Makefile.am

lib/common/tests/xml/crm_xml_init_test.c

lib/common/tests/xml/pcmk__xc_create_test.c

lib/common/tests/xml/pcmk__xe_copy_attrs_test.c

lib/common/tests/xml/pcmk__xe_first_child_test.c

lib/common/tests/xml/pcmk__xe_foreach_child_test.c

lib/common/tests/xml/pcmk__xe_set_score_test.c

lib/common/tests/xml/pcmk__xml_escape_test.c

lib/common/tests/xml/pcmk__xml_needs_escape_test.c

lib/common/tests/xml/pcmk__xml_new_doc_test.c

lib/common/unittest.c

lib/common/xml.c

lib/common/xml_attr.c

lib/common/xml_comment.c

lib/common/xml_io.c

lib/pacemaker/pcmk_acl.c

lib/pacemaker/pcmk_output.c

lib/pacemaker/pcmk_sched_constraints.c

lib/pacemaker/tests/pcmk_resource/pcmk_resource_delete_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk__get_ticket_state_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_constraints_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_delete_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_get_attr_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_info_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_remove_attr_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_set_attr_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_state_test.c

tools/crm_resource_print.c

Merge pull request #3644 from nrwahl2/nrwahl2-T838
6ec6fb6272e9
Actions