HomeClusterLabs Projects

Fix: libcrmcommon: Show deprecated option aliases in outputs

Description

Fix: libcrmcommon: Show deprecated option aliases in outputs

This fixes a regression introduced by commits 37b87dca and c0d90ba1. The
options "stop-orphan-resources" and "stop-orphan-actions" no longer
appeared in the output of crm_attribute --list-options=cluster. This
broke workflows that use pcs to set those properties.

The issue is not specific to those two options, but rather affects any
option with the alt_name field set. Those are currently the only ones,
however.

For the "default" display, we build up the aliases list separately from
the deprecated list. Creating a temporary pcmkcluster_option_t object
on the stack and allocating/freeing only one desc string at a time turns
out to be simpler than building a list of heap-allocated temporary
pcmk
cluster_option_t objects.

Fixes T998
Fixes RHEL-112591

Signed-off-by: Reid Wahl <nrwahl@protonmail.com>