Refactor: cts-exec-helper: best practices for generate_params()

Add a doxygen block, return a standard Pacemaker return code,
and improve log messages, comments, and formatting.

Drop a NULL test for rsc_id that the caller already did.