Refactor: scheduler: best practices for pcmk__set_instance_roles()

Add a doxygen block, drop unused argument and return value, and declare in
library-private header.