HomeClusterLabs Projects

Fix: libcrmservices: Add another place to finalize Start/Stop ops
a31d3e5cfab7Unpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Fix: libcrmservices: Add another place to finalize Start/Stop ops

The comment should explain this pretty well. What was happening was that
an executor regression test was failing because the operation never gets
finalized. Essentially, services__finalize_async_op() never gets called
for a unit that doesn't exist.

We typically want this to happen as part of the systemd callback that's
registered in the executor, but this callback will never get called in
this case because there's no systemd message that will make it through
our filter and trigger the callback. JobRemoved won't get sent because
there's no job to remove.

It seems like we could look for a failure from LoadUnit for units that
don't exist, but pacemaker always writes an override unit file which
means the unit will always exist.

Details

Provenance
clumensAuthored on Jan 21 2025, 3:49 PM
nrwahl2Committed on Feb 5 2025, 3:46 PM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.