Merge pull request #3366 from kgaillot/best-practices
a586196f1c16
Actions

Description

Merge pull request #3366 from kgaillot/best-practices

Move a few rule-related functions to libcrmcommon

Details

Provenance

kgaillot	Authored on Feb 19 2024, 6:11 PM
GitHub <noreply@github.com>	Committed on Feb 19 2024, 6:11 PM

Parents

rP58d8b9cf1c11: Refactor: libcrmcommon: best practices for parse_xml_duration()
rP84ea872120b0: Merge pull request #3368 from nrwahl2/nrwahl2-quote

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPa586196f1c16: Merge pull request #3366 from kgaillot/best-practices (authored by kgaillot).Feb 19 2024, 6:11 PM

Merged Changes

58d8b9cf1c11 Refactor: libcrmcommon: best practices for parse_xml_duration()
Author
kgaillot
Browse Repository
No Audits
52c0c1ccb288 Refactor: libcrmcommon: functionize getting time component attribute and…
Author
kgaillot
Browse Repository
No Audits
1893cd76dcc4 Refactor: libcrmcommon: functionize parsing date/time from XML
Author
kgaillot
Browse Repository
No Audits
6c462f29ddf3 Refactor: libcrmcommon: best practices for crm_time_set_if_earlier()
Author
kgaillot
Browse Repository
No Audits

Changes (14)

Path

Size

include/

crm/

common/

iso8601_internal.h

nvpair_internal.h

rules_internal.h

lib/

common/

iso8601.c

nvpair.c

rules.c

tests/

iso8601/

Makefile.am

pcmk__set_time_if_earlier_test.c

nvpair/

Makefile.am

pcmk__xe_get_datetime_test.c

rules/

Makefile.am

pcmk__unpack_duration_test.c

pengine/

rules.c

tools/

crm_resource_ban.c

rPa586196f1c16

View Options

include/crm/common/iso8601_internal.h

View Options

include/crm/common/nvpair_internal.h

View Options

include/crm/common/rules_internal.h

View Options

lib/common/iso8601.c

View Options

lib/common/nvpair.c

View Options

lib/common/rules.c

View Options

lib/common/tests/iso8601/Makefile.am

View Options

lib/common/tests/iso8601/pcmk__set_time_if_earlier_test.c

View Options

lib/common/tests/nvpair/Makefile.am

View Options

lib/common/tests/nvpair/pcmk__xe_get_datetime_test.c

View Options

lib/common/tests/rules/Makefile.am

View Options

lib/common/tests/rules/pcmk__unpack_duration_test.c

View Options

lib/pengine/rules.c

View Options

Merge pull request #3366 from kgaillot/best-practicesa586196f1c16Actions

Description

Details

Event Timeline

Merged Changes

Changes (14)

rPa586196f1c16

include/crm/common/iso8601_internal.h

include/crm/common/nvpair_internal.h

include/crm/common/rules_internal.h

lib/common/iso8601.c

lib/common/nvpair.c

lib/common/rules.c

lib/common/tests/iso8601/Makefile.am

lib/common/tests/iso8601/pcmk__set_time_if_earlier_test.c

lib/common/tests/nvpair/Makefile.am

lib/common/tests/nvpair/pcmk__xe_get_datetime_test.c

lib/common/tests/rules/Makefile.am

lib/common/tests/rules/pcmk__unpack_duration_test.c

lib/pengine/rules.c

tools/crm_resource_ban.c

Merge pull request #3366 from kgaillot/best-practices
a586196f1c16
Actions