HomeClusterLabs Projects

Low: executor: handle remote server socket consistently

Description

Low: executor: handle remote server socket consistently

Sometimes we used -1 to indicate not connected, sometimes 0 (which technically
is a valid fd even if it will never be used for a server socket). We even
attempted to close the socket when it was guaranteed to be -1 (which was
detected by static analysis).

Now, we always use -1 to indicate not connected, and close the socket
only when non-negative.

Details

Provenance
kgaillotAuthored on Oct 1 2019, 11:53 AM
Parents
rP379f24e72376: Doc: include: add comment describing purpose of compatibility.h
Branches
Unknown
Tags
Unknown

Event Timeline