HomeClusterLabs Projects

Low: libcrmcommon: ignore NULL first ID in pcmk__cmp_nvpair_blocks()
c47248ae999fUnpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Low: libcrmcommon: ignore NULL first ID in pcmk__cmp_nvpair_blocks()

pcmk__cmp_nvpair_blocks() can treat a particular XML ID as always having
the highest priority.

Previously, it assumed unpack_data->first_id was non-NULL. Now, skip the
check if it's NULL.

This did not matter for internal callers since the sorted blocks should
always have an ID (and thus not match a NULL first_id). It could
theoretically matter in a CIB with schema validation disabled and blocks
without IDs.

Details

Provenance
kgaillotAuthored on Tue, Oct 29, 6:34 PM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.