HomeClusterLabs Projects

Refactor: tools: Change the --xml-simple-list block in crm_resource.

Description

Refactor: tools: Change the --xml-simple-list block in crm_resource.

Previously, we listed those commands that need --xml-simple-list and
defaulted all others to the <list> style of list. However, as we are
trying to phase this out, it helps to know exactly what uses it.

Turns out, there's only four commands that create lists with begin_list.
All others do one of the following:

  • Don't use formatted output at all (cmd_delete_param, cmd_fail, cmd_set_param, crm_set_property).
  • Create a list with pcmk__output_xml_create_parent or create XML nodes outside of any list wrapper (cmd_cleanup, cmd_digests, cmd_list_alternatives, cmd_list_agents, cmd_list_providers, cmd_locate, cmd_metadata, cmd_refresh, cmd_why).
  • Only use out->info(), out->err(), or out->output_xml() (cmd_ban, cmd_clear, cmd_cts, cmd_delete, cmd_move, cmd_restart, cmd_wait).

Changing this block means that any future changes around formatted
output here will default to not using <list> and will have to write
their own new schema blobs, meaning fewer things for us to change later.

However, note that tool regression testing does not cover every single
command here. It's possible I have missed something and changed output.

Details

Provenance
clumensAuthored on Feb 20 2024, 1:04 PM
Parents
rPd4f389e48d31: Merge pull request #3370 from wenningerk/fix_cib_compat
Branches
Unknown
Tags
Unknown