Refactor: scheduler: best practices for pcmk__evaluate_condition()

Improve argument validation, log messages, comments, variable names, and
formatting. Since all evaluation functions now log their result, we don't need
to do that here.