Refactor: controller: best practices for do_resource_update()

Rename to controld_update_resource_history() for clarity (and planned
relocation), add a doxygen block, make rsc argument const, return void,
and improve variable names, comments, and formatting.

This also drops the CIB call ID from a log message, which wasn't particularly
helpful, and the corresponding argument to log_executor_event().