Page MenuHomeClusterLabs Projects
Create Task
Maniphest T817

Deprecate --sync-call cibadmin option
Open, LowPublic
Actions

Assigned To
nrwahl2
Authored By
nrwahl2
Apr 29 2024, 3:53 PM
Tags
  • Restricted Project
  • Restricted Project
Referenced Files
None
Subscribers
kgaillot
nrwahl2

Description

All calls are effectively synchronous, because the tool doesn't exit until it gets a response even in async mode. Yet we maintain two separate code paths: one for --sync-call/cib_sync_call, and one that uses a main loop.

This task is to deprecate the --sync-call CLI option and use the cib_sync_call code path unconditionally.

Ref: https://github.com/ClusterLabs/pacemaker/pull/3403#discussion_r1580492741

This is an easy change but I don't want to grow CLPR#3403 further.

Related Objects
Search...

StatusAssignedTask
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 Opennrwahl2T817 Deprecate --sync-call cibadmin option

Event Timeline

nrwahl2 triaged this task as Low priority.Apr 29 2024, 3:53 PM
nrwahl2 created this task.
nrwahl2 created this object with edit policy "Restricted Project (Project)".
nrwahl2 updated the task description. (Show Details)
nrwahl2 added a comment.Apr 29 2024, 3:58 PM

From the GitHub discussion:

I believe it was originally for testing the code paths. Not needed anymore

Optionally, we could have a (possibly hidden) --async-call option for developer use, that starts a mainloop and runs a callback function that processes the reply.

kgaillot added a parent task: Restricted Maniphest Task.Apr 29 2024, 4:05 PM
kgaillot added a subscriber: kgaillot.
In T817#12112, @nrwahl2 wrote:

From the GitHub discussion:

I believe it was originally for testing the code paths. Not needed anymore

Optionally, we could have a (possibly hidden) --async-call option for developer use, that starts a mainloop and runs a callback function that processes the reply.

not necessary