All calls are effectively synchronous, because the tool doesn't exit until it gets a response even in async mode. Yet we maintain two separate code paths: one for --sync-call/cib_sync_call, and one that uses a main loop.
This task is to deprecate the --sync-call CLI option and use the cib_sync_call code path unconditionally.
Ref: https://github.com/ClusterLabs/pacemaker/pull/3403#discussion_r1580492741
This is an easy change but I don't want to grow CLPR#3403 further.
| rP Pacemaker | |||
| rPd41c79a84e50 Refactor: tools: Use cib_sync_call unconditionally in cibadmin | |||
| rPf6a8298f5e03 Feature: tools: Deprecate cibadmin --sync-call | |||
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Restricted Maniphest Task | ||||
| Restricted Maniphest Task | ||||
| Restricted Maniphest Task | ||||
| Merged | nrwahl2 | T817 Deprecate --sync-call cibadmin option |
From the GitHub discussion:
I believe it was originally for testing the code paths. Not needed anymore
Optionally, we could have a (possibly hidden) --async-call option for developer use, that starts a mainloop and runs a callback function that processes the reply.