Merge pull request #3853 from nrwahl2/nrwahl2-refactors
26904603f34e
Actions

Description

Merge pull request #3853 from nrwahl2/nrwahl2-refactors

XML refactors/deprecations: xml_accept_changes() to xml_calculate_significant_changes()

Details

Provenance

clumens	Authored on Tue, Apr 22, 10:13 AM
GitHub <noreply@github.com>	Committed on Tue, Apr 22, 10:13 AM

Parents

rP13a9a87b2453: Merge pull request #3864 from clumens/ipc-no-compression
rP761ee74772bb: Refactor: libcrmcommon: Best practices in mark_child_moved()

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP26904603f34e: Merge pull request #3853 from nrwahl2/nrwahl2-refactors (authored by clumens).Tue, Apr 22, 10:13 AM

Merged Changes

761ee74772bb Refactor: libcrmcommon: Best practices in mark_child_moved()
Author
nrwahl2
Browse Repository
No Audits
7d2b858de0c0 API: libcrmcommon: Deprecate xml_calculate_significant_changes()
Author
nrwahl2
Browse Repository
No Audits
fe6c5cd9206c Refactor: libcrmcommon: Replace xml_calculate_significant_changes()
Author
nrwahl2
Browse Repository
No Audits
96d2d32a2141 API: libcrmcommon: Deprecate xml_calculate_changes()
Author
nrwahl2
Browse Repository
No Audits
f63ff09ffbc9 Refactor: libcrmcommon: New pcmk__xml_mark_changes()
Author
nrwahl2
Browse Repository
No Audits
542b16246edc Refactor: libcrmcommon: Make pcmk__xc_match_child() static
Author
nrwahl2
Browse Repository
No Audits
2348975e4eb6 Refactor: libcrmcommon: Drop pcmk__xf_processed flag
Author
nrwahl2
Browse Repository
No Audits
b235359522d7 Low: libcrmcommon: Always free temp node in mark_child_deleted()
Author
nrwahl2
Browse Repository
No Audits
bb20fd9334ec Low: libcrmcommon: Fix XML matching when marking changes
Author
nrwahl2
Browse Repository
No Audits
ff3a1a32e760 Refactor: libcrmcommon: Functionize matching XML comment content
Author
nrwahl2
Browse Repository
No Audits
0df52a1509f2 Refactor: libcrmcommon: Best practices in pcmk__xc_match()
Author
nrwahl2
Browse Repository
No Audits
03dc3df183a7 Refactor: libcrmcommon: Drop old_xml NULL case from mark_xml_changes()
Author
nrwahl2
Browse Repository
No Audits
6df5e378cadd Refactor: libcrmcommon: Some best practices in mark_xml_changes()
Author
nrwahl2
Browse Repository
No Audits
1855585c3079 Refactor: libcrmcommon: Drop redundant check from mark_child_deleted()
Author
nrwahl2
Browse Repository
No Audits
32a27946f8c3 Refactor: libcrmcommon: Make pcmk__xml_match() static
Author
nrwahl2
Browse Repository
No Audits
5643b3ba85ab Refactor: libcrmcommon: Rename pcmk__xf_lazy to pcmk__xf_ignore_attr_pos
Author
nrwahl2
Browse Repository
No Audits
ffecf525f87e Doc: libcrmcommon: Document bug in xml_calculate_significant_changes()
Author
nrwahl2
Browse Repository
No Audits
e160a980d617 Refactor: libcrmcommon: Don't set XML private flags without tracking
Author
nrwahl2
Browse Repository
No Audits
4c77fcb8af21 API: libcrmcommon: Deprecate xml_track_changes()
Author
nrwahl2
Browse Repository
No Audits
f4cbf82177d8 Refactor: libcib, libcrmcommon: Drop xml_track_changes() internally
Author
nrwahl2
Browse Repository
No Audits
18379a00f9fd Refactor: libcrmcommon: Don't reuse doc in pcmk__xc_create() unit test
Author
nrwahl2
Browse Repository
No Audits
6fb789945622 Refactor: libcib: Avoid cib_acl_enabled() duplication
Author
nrwahl2
Browse Repository
No Audits
135a90f01bf0 Refactor: libcrmcommon, tools: Drop redundant xml_track_changes() calls
Author
nrwahl2
Browse Repository
No Audits
dcc42c568570 Refactor: libcrmcommon: Rename xml_private_flags to pcmk__xml_flags
Author
nrwahl2
Browse Repository
No Audits
5c9848348abf API: libcrmcommon: Deprecate xml_accept_changes()
Author
nrwahl2
Browse Repository
No Audits
253ca4251976 Refactor: libcrmcommon: New pcmk__xml_commit_changes()
Author
nrwahl2
Browse Repository
No Audits

Changes (18)

Path

Size

daemons/

based/

based_callbacks.c

include/

crm/

common/

lib/

cib/

common/

tests/

patchset/

pcmk__cib_element_in_patchset_test.c

xml/

pcmk__xml_new_doc_test.c

xml_comment/

pcmk__xc_create_test.c

xml_element/

pcmk__xe_sort_attrs_test.c

tools/

rP26904603f34e

View Options

daemons/based/based_callbacks.c

View Options

include/crm/common/acl_internal.h

View Options

include/crm/common/xml.h

View Options

include/crm/common/xml_compat.h

View Options

include/crm/common/xml_internal.h

View Options

lib/cib/cib_utils.c

View Options

lib/common/acl.c

View Options

lib/common/crmcommon_private.h

View Options

lib/common/patchset.c

View Options

lib/common/tests/patchset/pcmk__cib_element_in_patchset_test.c

View Options

lib/common/tests/xml/pcmk__xml_new_doc_test.c

View Options

lib/common/tests/xml_comment/pcmk__xc_create_test.c

View Options

lib/common/tests/xml_element/pcmk__xe_sort_attrs_test.c

View Options

lib/common/xml.c

View Options

lib/common/xml_comment.c

View Options

lib/common/xml_element.c

View Options

tools/crm_diff.c

View Options

Merge pull request #3853 from nrwahl2/nrwahl2-refactors26904603f34eActions

Description

Details

Event Timeline

Merged Changes

Changes (18)

rP26904603f34e

daemons/based/based_callbacks.c

include/crm/common/acl_internal.h

include/crm/common/xml.h

include/crm/common/xml_compat.h

include/crm/common/xml_internal.h

lib/cib/cib_utils.c

lib/common/acl.c

lib/common/crmcommon_private.h

lib/common/patchset.c

lib/common/tests/patchset/pcmk__cib_element_in_patchset_test.c

lib/common/tests/xml/pcmk__xml_new_doc_test.c

lib/common/tests/xml_comment/pcmk__xc_create_test.c

lib/common/tests/xml_element/pcmk__xe_sort_attrs_test.c

lib/common/xml.c

lib/common/xml_comment.c

lib/common/xml_element.c

tools/crm_diff.c

tools/crm_shadow.c

Merge pull request #3853 from nrwahl2/nrwahl2-refactors
26904603f34e
Actions