Refactor: scheduler: best practices for promotable_constraints()

Rename promotable_constraints() to pcmk__order_promotable_instances(),
declare in library-private header, add a doxygen block, drop a redundant
argument, and improve variable names, comments, and formatting.