Refactor: scheduler: best practices for promote_demote_constraints()

Rename promote_demote_constraints() to pcmk__promotable_restart_ordering(),
move it to pcmk_sched_ordering.c since it applies to both clones and bundles,
declare it in library-private header, drop redundant data_set argument,
add a doxygen block, and improve comments and formatting.