Merge pull request #2985 from nrwahl2/nrwahl2-T108_new
2ed3ca208b7b
Actions

Description

Merge pull request #2985 from nrwahl2/nrwahl2-T108_new

XML logging best practices and log_data_element() deprecation

Details

Provenance

kgaillot	Authored on Jan 4 2023, 10:05 AM
GitHub <noreply@github.com>	Committed on Jan 4 2023, 10:05 AM

Parents

rPdf4d3433f3dc: Merge pull request #2986 from kgaillot/fixes
rPc8a19d120019: Refactor: libcrmcommon: Avoid some dynamic memory in XML loggers

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP2ed3ca208b7b: Merge pull request #2985 from nrwahl2/nrwahl2-T108_new (authored by kgaillot).Jan 4 2023, 10:05 AM

Merged Changes

c8a19d120019 Refactor: libcrmcommon: Avoid some dynamic memory in XML loggers
Author
nrwahl2
Browse Repository
No Audits
fd5b910bb0a1 Refactor: libcrmcommon: Rename insert_prefix() to insert_spaces()
Author
nrwahl2
Browse Repository
No Audits
c90237d878e2 Refactor: libcrmcommon: Use XML created prefix constant in more places
Author
nrwahl2
Browse Repository
No Audits
6e9e9327b51d API: libcrmcommon: Deprecate log_data_element()
Author
nrwahl2
Browse Repository
No Audits
58342ffa22f9 API: libcrmcommon: Replace do_crm_log_xml() with a function
Author
nrwahl2
Browse Repository
No Audits
3ca5a175a47f Refactor: libcrmcommon: Remove internal uses of log_data_element()
Author
nrwahl2
Browse Repository
No Audits
f1a41f44965a Low: libcrmcommon: Improve prefix spacing in XML logging functions
Author
nrwahl2
Browse Repository
No Audits
73c0afba68f1 Refactor: libcrmcommon: Best practices in xml_log_changes()
Author
nrwahl2
Browse Repository
No Audits
93f8f22f868d Refactor: libcrmcommon: Best practices in log_data_element()
Author
nrwahl2
Browse Repository
No Audits
9e2543a71f68 Refactor: libcrmcommon: Best practices for log_xml_changes()
Author
nrwahl2
Browse Repository
No Audits
400212a8f208 Refactor: libcrmcommon: Split log_xml_node_and_children: element/comment
Author
nrwahl2
Browse Repository
No Audits
dfb794650472 Refactor: libcrmcommon: Best practices in log_xml_node_and_children()
Author
nrwahl2
Browse Repository
No Audits
4ec9c8ae03a5 API: libcrmcommon: patchset argument of xml_log_patchset() is now const
Author
nrwahl2
Browse Repository
No Audits
e5287660421d API: libcrmcommon: xml argument of xml_log_changes() is now const
Author
nrwahl2
Browse Repository
No Audits
327ef1990cba Refactor: libcrmcommon: Functionize xml_log_patchset_header()
Author
nrwahl2
Browse Repository
No Audits
dd17e4da88f5 Refactor: libcrmcommon: Split xml_log_patchset() into v1 and v2
Author
nrwahl2
Browse Repository
No Audits
8544118cb3aa Refactor: libcrmcommon: Best practices in xml_log_patchset()
Author
nrwahl2
Browse Repository
No Audits

Changes (8)

Path

Size

include/

crm/

common/

lib/

common/

rP2ed3ca208b7b

View Options

include/crm/common/logging.h

View Options

include/crm/common/logging_compat.h

View Options

include/crm/common/xml.h

View Options

include/crm/common/xml_internal.h

View Options

lib/common/crmcommon_private.h

View Options

lib/common/logging.c

View Options

lib/common/patchset.c

View Options

Merge pull request #2985 from nrwahl2/nrwahl2-T108_new2ed3ca208b7bActions

Description

Details

Event Timeline

Merged Changes

Changes (8)

rP2ed3ca208b7b

include/crm/common/logging.h

include/crm/common/logging_compat.h

include/crm/common/xml.h

include/crm/common/xml_internal.h

lib/common/crmcommon_private.h

lib/common/logging.c

lib/common/patchset.c

lib/common/xml.c

Merge pull request #2985 from nrwahl2/nrwahl2-T108_new
2ed3ca208b7b
Actions