Merge pull request #3301 from nrwahl2/nrwahl2-meta
5144ca5f20f4
Actions

Description

Merge pull request #3301 from nrwahl2/nrwahl2-meta

Some meta-attribute best practices

Details

Provenance

kgaillot	Authored on Jan 4 2024, 10:23 AM
GitHub <noreply@github.com>	Committed on Jan 4 2024, 10:23 AM

Parents

rP97dfa5c93987: Refactor: various: Use meta constants in comments/logs where appropriate
rPef68f89f82c1: Merge pull request #3303 from nrwahl2/nrwahl2-xml_attrs

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP5144ca5f20f4: Merge pull request #3301 from nrwahl2/nrwahl2-meta (authored by kgaillot).Jan 4 2024, 10:23 AM

Merged Changes

This commit merges a very large number of changes. Only the first 50 are shown.

97dfa5c93987 Refactor: various: Use meta constants in comments/logs where appropriate
Author
nrwahl2
Browse Repository
No Audits
4ee57f9bf3b1 API: libcrmcommon: Move meta-attrs and rsc instance attrs to options.h
Author
nrwahl2
Browse Repository
No Audits
7fc8e4ce0356 Doc: libcrmcommon: Clarify XML symbol naming conventions
Author
nrwahl2
Browse Repository
No Audits
c502b86efccb API: libcrmcommon: New PCMK_META_ALLOW_UNHEALTHY_NODES string constant
Author
nrwahl2
Browse Repository
No Audits
9c8db9205636 Refactor: fencer, libpe_status: Use XML_{EXPR_,}ATTR_TYPE correctly
Author
nrwahl2
Browse Repository
No Audits
40029deefe83 API: libcrmcommon: Deprecate XML_REMOTE_ATTR_RECONNECT_INTERVAL
Author
nrwahl2
Browse Repository
No Audits
83093902f4f3 API: libcrmcommon: New PCMK_REMOTE_RA_RECONNECT_INTERVAL constant
Author
nrwahl2
Browse Repository
No Audits
5f91c809aae9 API: libcrmcommon: Deprecate XML_RSC_ATTR_REMOTE_RA_PORT
Author
nrwahl2
Browse Repository
No Audits
867913b39724 API: libcrmcommon: New PCMK_REMOTE_RA_PORT string constant
Author
nrwahl2
Browse Repository
No Audits
fe6893f95e4e API: libcrmcommon: Deprecate XML_RSC_ATTR_REMOTE_RA_SERVER
Author
nrwahl2
Browse Repository
No Audits
6fc8746f81fa API: libcrmcommon: New PCMK_REMOTE_RA_SERVER string constant
Author
nrwahl2
Browse Repository
No Audits
811729358623 API: libcrmcommon: Deprecate XML_RSC_ATTR_REMOTE_RA_ADDR
Author
nrwahl2
Browse Repository
No Audits
702cdeee2e90 API: libcrmcommon: New PCMK_REMOTE_RA_ADDR string constant
Author
nrwahl2
Browse Repository
No Audits
e4bbd144f326 Doc: books: Document remote-allow-migrate
Author
nrwahl2
Browse Repository
No Audits
1b9df1209563 Doc: Pacemaker Explained: Convert rsc meta-attr table to list-table
Author
nrwahl2
Browse Repository
No Audits
220c8b2aa264 API: libcrmcommon: Deprecate XML_BOOLEAN_NO
Author
nrwahl2
Browse Repository
No Audits
40e3759514f1 API: libcrmcommon: Deprecate XML_BOOLEAN_YES
Author
nrwahl2
Browse Repository
No Audits
a105517c504b Refactor: controller, libpacemaker: Drop XML_BOOLEAN_{YES,NO} internally
Author
nrwahl2
Browse Repository
No Audits
c27857213ef1 Refactor: libpe_status: Use XML_RSC_ATTR_REMOTE_RA_PORT
Author
nrwahl2
Browse Repository
No Audits
037eaad576b0 Refactor: libpacemaker: Rename pcmk__add_bundle_meta_to_xml()
Author
nrwahl2
Browse Repository
No Audits
3e917eac6ad5 Refactor: libcrmcommon: Rename PCMK__ENV_PHYSICAL_HOST to PCMK__META
Author
nrwahl2
Browse Repository
No Audits
f83ee60f5a8e API: libcrmcommon: Add new PCMK_META_PRIORITY string constant
Author
nrwahl2
Browse Repository
No Audits
ee7b68067ea3 API: libcrmcommon: Deprecate XML_OP_ATTR_ALLOW_MIGRATE
Author
nrwahl2
Browse Repository
No Audits
ed322f3aa6a4 API: libcrmcommon: New PCMK_META_ALLOW_MIGRATE string constant
Author
nrwahl2
Browse Repository
No Audits
86581457d567 API: libcrmcommon: New PCMK_META_REMOTE_ALLOW_MIGRATE string constant
Author
nrwahl2
Browse Repository
No Audits
4c9548c1e744 API: libcrmcommon: New PCMK_META_REMOTE_CONNECT_TIMEOUT string constant
Author
nrwahl2
Browse Repository
No Audits
d22b6fb71d15 API: libcrmcommon: New PCMK_META_REMOTE_PORT string constant
Author
nrwahl2
Browse Repository
No Audits
11f73f0a0a3e API: libcrmcommon: New PCMK_META_REMOTE_ADDR string constant
Author
nrwahl2
Browse Repository
No Audits
850d4001ae9a API: libcrmcommon: Deprecate XML_RSC_ATTR_CRITICAL
Author
nrwahl2
Browse Repository
No Audits
1ef4d3419625 API: libcrmcommon: New PCMK_META_CRITICAL string constant
Author
nrwahl2
Browse Repository
No Audits
28efdd632706 API: libcrmcommon: Deprecate XML_RSC_ATTR_CLEAR_INTERVAL
Author
nrwahl2
Browse Repository
No Audits
1d867976773a API: libcrmcommon: Deprecate XML_RSC_ATTR_CLEAR_OP
Author
nrwahl2
Browse Repository
No Audits
659f6ca05d29 Refactor: libcrmcommon: New PCMK__META_CLEAR_FAILURE_{OP,INTERVAL}
Author
nrwahl2
Browse Repository
No Audits
d8148203c1e8 API: libcrmcommon: Deprecate XML_RSC_ATTR_REMOTE_NODE
Author
nrwahl2
Browse Repository
No Audits
80cffd0b3e1b API: libcrmcommon: New PCMK_META_REMOTE_NODE string constant
Author
nrwahl2
Browse Repository
No Audits
1f3da9f85762 API: libcrmcommon: Deprecate XML_RSC_ATTR_MAINTENANCE
Author
nrwahl2
Browse Repository
No Audits
166e7297b091 API: libcrmcommon: New PCMK_META_MAINTENANCE string constant
Author
nrwahl2
Browse Repository
No Audits
782ad9a8caef API: libcrmcommon: Deprecate XML_RSC_ATTR_INTERNAL_RSC
Author
nrwahl2
Browse Repository
No Audits
34d1497a31bf Refactor: libcrmcommon: New PCMK__META_INTERNAL_RSC string constant
Author
nrwahl2
Browse Repository
No Audits
38f8edfc4a7b API: libcrmcommon: Deprecate XML_RSC_ATTR_CONTAINER
Author
nrwahl2
Browse Repository
No Audits
d3cd3def669d Refactor: libcrmcommon: New PCMK__META_CONTAINER string constant
Author
nrwahl2
Browse Repository
No Audits
e19bbf8eb84e API: libcrmcommon: Deprecate XML_RSC_ATTR_REQUIRES
Author
nrwahl2
Browse Repository
No Audits
504e03b16d55 API: libcrmcommon: New PCMK_META_REQUIRES string constant
Author
nrwahl2
Browse Repository
No Audits
724cdc88b54d API: libcrmcommon: Deprecate XML_RSC_ATTR_MULTIPLE
Author
nrwahl2
Browse Repository
No Audits
3996c53bafe2 API: libcrmcommon: New PCMK_META_MULTIPLE_ACTIVE string constant
Author
nrwahl2
Browse Repository
No Audits
2b092711bbd3 API: libcrmcommon: Deprecate XML_RSC_ATTR_STICKINESS
Author
nrwahl2
Browse Repository
No Audits
d00ca0a68c9b API: libcrmcommon: New PCMK_META_RESOURCE_STICKINESS constant
Author
nrwahl2
Browse Repository
No Audits
d091bad5b62e API: libcrmcommon: Deprecate XML_RSC_ATTR_NOTIFY
Author
nrwahl2
Browse Repository
No Audits
6bf56af174f3 API: libcrmcommon: New PCMK_META_NOTIFY string constant
Author
nrwahl2
Browse Repository
No Audits
cb48827ac138 API: libcrmcommon: Deprecate XML_RSC_ATTR_UNIQUE
Author
nrwahl2
Browse Repository
No Audits

Changes (54)

Path

Size

daemons/

controld/

fenced/

doc/

sphinx/

Pacemaker_Explained/

resources.rst

Pacemaker_Remote/

options.rst

include/

crm/

common/

lib/

cib/

common/

tests/

utils/

crm_meta_name_test.c

crm_meta_value_test.c

pacemaker/

libpacemaker_private.h

pcmk_graph_producer.c

pcmk_sched_colocation.c

pcmk_sched_group.c

pcmk_sched_instances.c

pcmk_sched_nodes.c

pcmk_sched_ordering.c

pcmk_sched_primitive.c

pcmk_sched_probes.c

pcmk_sched_remote.c

pcmk_sched_resource.c

pengine/

tools/

crm_resource_runtime.c

rP5144ca5f20f4

View Options

daemons/controld/controld_cib.c

View Options

daemons/controld/controld_election.c

View Options

daemons/controld/controld_execd.c

View Options

daemons/controld/controld_messages.c

View Options

daemons/controld/controld_remote_ra.c

View Options

daemons/fenced/fenced_scheduler.c

View Options

doc/sphinx/Pacemaker_Explained/resources.rst

View Options

doc/sphinx/Pacemaker_Remote/options.rst

View Options

include/crm/common/actions.h

View Options

include/crm/common/options.h

View Options

include/crm/common/options_internal.h

View Options

include/crm/common/resources.h

View Options

include/crm/common/scheduler.h

View Options

include/crm/common/xml_internal.h

View Options

include/crm/msg_xml.h

View Options

include/crm/msg_xml_compat.h

View Options

lib/cib/cib_attrs.c

View Options

lib/cib/cib_utils.c

View Options

lib/common/agents.c

View Options

lib/common/attrs.c

View Options

lib/common/tests/utils/crm_meta_name_test.c

View Options

lib/common/tests/utils/crm_meta_value_test.c

View Options

lib/pacemaker/libpacemaker_private.h

View Options

lib/pacemaker/pcmk_graph_producer.c

View Options

lib/pacemaker/pcmk_injections.c

View Options

lib/pacemaker/pcmk_output.c

View Options

lib/pacemaker/pcmk_sched_actions.c

View Options

lib/pacemaker/pcmk_sched_bundle.c

View Options

lib/pacemaker/pcmk_sched_clone.c

View Options

lib/pacemaker/pcmk_sched_colocation.c

View Options

lib/pacemaker/pcmk_sched_group.c

View Options

lib/pacemaker/pcmk_sched_instances.c

View Options

lib/pacemaker/pcmk_sched_nodes.c

View Options

lib/pacemaker/pcmk_sched_ordering.c

View Options

lib/pacemaker/pcmk_sched_primitive.c

View Options

lib/pacemaker/pcmk_sched_probes.c

View Options

lib/pacemaker/pcmk_sched_remote.c

View Options

lib/pacemaker/pcmk_sched_resource.c

View Options

lib/pengine/bundle.c

View Options

lib/pengine/clone.c

View Options

lib/pengine/common.c

View Options

lib/pengine/complex.c

View Options

lib/pengine/group.c

View Options

lib/pengine/native.c

View Options

lib/pengine/pe_actions.c

View Options

lib/pengine/pe_digest.c

View Options

lib/pengine/pe_notif.c

View Options

lib/pengine/pe_output.c

View Options

lib/pengine/remote.c

View Options

lib/pengine/unpack.c

View Options

lib/pengine/utils.c

View Options

tools/cibadmin.c

View Options

tools/crm_resource.c

View Options

tools/crm_resource_runtime.c

Merge pull request #3301 from nrwahl2/nrwahl2-meta5144ca5f20f4Actions

Description

Details

Event Timeline

Merged Changes

Changes (54)

rP5144ca5f20f4

daemons/controld/controld_cib.c

daemons/controld/controld_election.c

daemons/controld/controld_execd.c

daemons/controld/controld_messages.c

daemons/controld/controld_remote_ra.c

daemons/fenced/fenced_scheduler.c

doc/sphinx/Pacemaker_Explained/resources.rst

doc/sphinx/Pacemaker_Remote/options.rst

include/crm/common/actions.h

include/crm/common/options.h

include/crm/common/options_internal.h

include/crm/common/resources.h

include/crm/common/scheduler.h

include/crm/common/xml_internal.h

include/crm/msg_xml.h

include/crm/msg_xml_compat.h

lib/cib/cib_attrs.c

lib/cib/cib_utils.c

lib/common/agents.c

lib/common/attrs.c

lib/common/tests/utils/crm_meta_name_test.c

lib/common/tests/utils/crm_meta_value_test.c

lib/pacemaker/libpacemaker_private.h

lib/pacemaker/pcmk_graph_producer.c

lib/pacemaker/pcmk_injections.c

lib/pacemaker/pcmk_output.c

lib/pacemaker/pcmk_sched_actions.c

lib/pacemaker/pcmk_sched_bundle.c

lib/pacemaker/pcmk_sched_clone.c

lib/pacemaker/pcmk_sched_colocation.c

lib/pacemaker/pcmk_sched_group.c

lib/pacemaker/pcmk_sched_instances.c

lib/pacemaker/pcmk_sched_nodes.c

lib/pacemaker/pcmk_sched_ordering.c

lib/pacemaker/pcmk_sched_primitive.c

lib/pacemaker/pcmk_sched_probes.c

lib/pacemaker/pcmk_sched_remote.c

lib/pacemaker/pcmk_sched_resource.c

lib/pengine/bundle.c

lib/pengine/clone.c

lib/pengine/common.c

lib/pengine/complex.c

lib/pengine/group.c

lib/pengine/native.c

lib/pengine/pe_actions.c

lib/pengine/pe_digest.c

lib/pengine/pe_notif.c

lib/pengine/pe_output.c

lib/pengine/remote.c

lib/pengine/unpack.c

lib/pengine/utils.c

tools/cibadmin.c

tools/crm_resource.c

tools/crm_resource_runtime.c

Merge pull request #3301 from nrwahl2/nrwahl2-meta
5144ca5f20f4
Actions