Merge pull request #2940 from nrwahl2/nrwahl2-T239
8928e04d4fb1
Actions

Description

Merge pull request #2940 from nrwahl2/nrwahl2-T239

Refactor: controller: Make global variables easier to follow

Details

Provenance

kgaillot	Authored on Nov 17 2022, 6:25 PM
GitHub <noreply@github.com>	Committed on Nov 17 2022, 6:25 PM

Parents

rPeec430e38d20: Merge pull request #2945 from nrwahl2/nrwahl2-schema_fix
rP708715291220: Refactor: controller: Remove unneeded arg from FSA state/action getters

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP8928e04d4fb1: Merge pull request #2940 from nrwahl2/nrwahl2-T239 (authored by kgaillot).Nov 17 2022, 6:25 PM

Merged Changes

708715291220 Refactor: controller: Remove unneeded arg from FSA state/action getters
Author
nrwahl2
Browse Repository
No Audits
7f31f94ea2bd Refactor: controller: Use pcmk__str_eq() with pcmk__str_null_matches
Author
nrwahl2
Browse Repository
No Audits
e0d57eafe5a0 Refactor: controller: trigger_graph_processing -> trigger_graph_as
Author
nrwahl2
Browse Repository
No Audits
a467dca21982 Refactor: controller: Make fsa_timer_t internal to controld_timers.c
Author
nrwahl2
Browse Repository
No Audits
edfbe4e1268a Refactor: controller: Static-ize timer stop/start functions
Author
nrwahl2
Browse Repository
No Audits
459dacf562e2 Refactor: controller: Static-ize shutdown_escalation_timer
Author
nrwahl2
Browse Repository
No Audits
c892c51ba4b9 Refactor: controller: Static-ize controld_timers.c:finalization_timer
Author
nrwahl2
Browse Repository
No Audits
18a2fc305f74 Refactor: controller: Static-ize controld_timers.c:integration_timer
Author
nrwahl2
Browse Repository
No Audits
d9eeb513dfce Refactor: controller: Static-ize controld_timers.c:election_timer
Author
nrwahl2
Browse Repository
No Audits
274bda607e59 Refactor: controller: Static-ize controld_timers.c:recheck_timer
Author
nrwahl2
Browse Repository
No Audits
e87a0a289c31 Refactor: controller: Static-ize controld_timers.c:wait_timer
Author
nrwahl2
Browse Repository
No Audits
9b719b87c38d Refactor: controller: Static-ize controld_timers.c:recheck_interval_ms
Author
nrwahl2
Browse Repository
No Audits
6e780ee6b483 Refactor: controller: Move throttle config to its own file
Author
nrwahl2
Browse Repository
No Audits
5d7b3aaf1bec Refactor: controller: Move election config to its own file
Author
nrwahl2
Browse Repository
No Audits
a5a3bc9806f9 Refactor: controller: Move fencing config to its own file
Author
nrwahl2
Browse Repository
No Audits
d94196871b61 Refactor: controller: Move timers config into timers file
Author
nrwahl2
Browse Repository
No Audits
a466e68eb293 Refactor: controller: Remove controller_option()
Author
nrwahl2
Browse Repository
No Audits
6af017c25d18 Refactor: controller: Remove redundant recheck_by global
Author
nrwahl2
Browse Repository
No Audits
cf86417a5dda Refactor: libpacemaker: Add recheck_by to pcmk__graph_t
Author
nrwahl2
Browse Repository
No Audits
b0af4cbb624f Refactor: controller: Remove redundant failed stop/start offset globals
Author
nrwahl2
Browse Repository
No Audits
5c8050427b69 Refactor: libpacemaker: Add failed stop, start offsets to pcmk__graph_t
Author
nrwahl2
Browse Repository
No Audits
65619286d153 Refactor: controller: Static-ize controld_te_actions.c:te_graph_fns
Author
nrwahl2
Browse Repository
No Audits
935da8691ef5 Refactor: controller: Add transition_graph to globals struct
Author
nrwahl2
Browse Repository
No Audits
ffd3cbacdf58 Refactor: controller: Add te_uuid to globals struct
Author
nrwahl2
Browse Repository
No Audits
0e1750e8bfc2 Refactor: controller: Add logger_out to globals struct
Author
nrwahl2
Browse Repository
No Audits
a691c5fed7f7 Refactor: controller: Add last_resource_update to globals struct
Author
nrwahl2
Browse Repository
No Audits
b197286fb985 Refactor: controller: Add saved_ccm_membership_id to globals struct
Author
nrwahl2
Browse Repository
No Audits
ffb3e86d67c5 Refactor: controller: Add fsa_pe_ref to globals struct
Author
nrwahl2
Browse Repository
No Audits
94f510acb630 Refactor: controller: Add fsa_cib_conn to globals struct
Author
nrwahl2
Browse Repository
No Audits
66cfffadf477 Refactor: controller: Add fsa_message_queue to globals struct
Author
nrwahl2
Browse Repository
No Audits
0515deff48c6 Refactor: controller: Static-ize controld_fsa.c:fsa_trigger
Author
nrwahl2
Browse Repository
No Audits

Changes (34)

Path

Size

daemons/

controld/

controld_execd_state.c

	controld_globals.h
	pacemaker-controld.h

controld_join_client.c

controld_join_dc.c

controld_matrix.c

controld_membership.c

controld_messages.c

controld_schedulerd.c

controld_te_actions.c

controld_te_callbacks.c

controld_transition.c

controld_transition.h

include/

pcmki/

pcmki_transition.h

lib/

pacemaker/

pcmk_graph_consumer.c

rP8928e04d4fb1

View Options

daemons/controld/Makefile.am

View Options

daemons/controld/controld_based.c

View Options

daemons/controld/controld_callbacks.c

View Options

daemons/controld/controld_control.c

View Options

daemons/controld/controld_election.c

View Options

daemons/controld/controld_execd.c

View Options

daemons/controld/controld_execd_state.c

View Options

daemons/controld/controld_fencing.c

View Options

daemons/controld/controld_fencing.h

View Options

daemons/controld/controld_fsa.c

View Options

daemons/controld/controld_fsa.h

View Options

daemons/controld/controld_globals.h

View Options

daemons/controld/controld_join_client.c

View Options

daemons/controld/controld_join_dc.c

View Options

daemons/controld/controld_matrix.c

View Options

daemons/controld/controld_membership.c

View Options

daemons/controld/controld_messages.c

View Options

daemons/controld/controld_schedulerd.c

View Options

daemons/controld/controld_te_actions.c

View Options

daemons/controld/controld_te_callbacks.c

View Options

daemons/controld/controld_te_events.c

View Options

daemons/controld/controld_te_utils.c

View Options

daemons/controld/controld_throttle.c

View Options

daemons/controld/controld_throttle.h

View Options

daemons/controld/controld_timers.c

View Options

daemons/controld/controld_timers.h

View Options

daemons/controld/controld_transition.c

View Options

daemons/controld/controld_transition.h

View Options

daemons/controld/controld_utils.c

View Options

daemons/controld/controld_utils.h

View Options

daemons/controld/pacemaker-controld.c

View Options

daemons/controld/pacemaker-controld.h

View Options

include/pcmki/pcmki_transition.h

View Options

lib/pacemaker/pcmk_graph_consumer.c

Merge pull request #2940 from nrwahl2/nrwahl2-T2398928e04d4fb1Actions

Description

Details

Event Timeline

Merged Changes

Changes (34)

rP8928e04d4fb1

daemons/controld/Makefile.am

daemons/controld/controld_based.c

daemons/controld/controld_callbacks.c

daemons/controld/controld_control.c

daemons/controld/controld_election.c

daemons/controld/controld_execd.c

daemons/controld/controld_execd_state.c

daemons/controld/controld_fencing.c

daemons/controld/controld_fencing.h

daemons/controld/controld_fsa.c

daemons/controld/controld_fsa.h

daemons/controld/controld_globals.h

daemons/controld/controld_join_client.c

daemons/controld/controld_join_dc.c

daemons/controld/controld_matrix.c

daemons/controld/controld_membership.c

daemons/controld/controld_messages.c

daemons/controld/controld_schedulerd.c

daemons/controld/controld_te_actions.c

daemons/controld/controld_te_callbacks.c

daemons/controld/controld_te_events.c

daemons/controld/controld_te_utils.c

daemons/controld/controld_throttle.c

daemons/controld/controld_throttle.h

daemons/controld/controld_timers.c

daemons/controld/controld_timers.h

daemons/controld/controld_transition.c

daemons/controld/controld_transition.h

daemons/controld/controld_utils.c

daemons/controld/controld_utils.h

daemons/controld/pacemaker-controld.c

daemons/controld/pacemaker-controld.h

include/pcmki/pcmki_transition.h

lib/pacemaker/pcmk_graph_consumer.c

Merge pull request #2940 from nrwahl2/nrwahl2-T239
8928e04d4fb1
Actions