Merge pull request #3843 from nrwahl2/nrwahl2-refactors
8e0443587d10
Actions

Description

Merge pull request #3843 from nrwahl2/nrwahl2-refactors

XML deprecations: xpath_search() through dedupXpathResults()

Details

Provenance

clumens	Authored on Fri, Mar 21, 2:57 PM
GitHub <noreply@github.com>	Committed on Fri, Mar 21, 2:57 PM

Parents

rP3c3eec8d9f4e: Refactor: various: NULL-check pcmk__xpath_result() return value
rP4263b0ac7e86: Merge pull request #3848 from gao-yan/pcmk_rc_no_dc-desc

Branches

Tags

Event Timeline

GitHub <noreply@github.com> committed rP8e0443587d10: Merge pull request #3843 from nrwahl2/nrwahl2-refactors (authored by clumens).Fri, Mar 21, 2:57 PM

Merged Changes

3c3eec8d9f4e Refactor: various: NULL-check pcmk__xpath_result() return value
Author
nrwahl2
Browse Repository
No Audits
2917f3756f30 Refactor: libcrmcommon: Ensure pcmk__xpath_num_results returns >= 0
Author
nrwahl2
Browse Repository
No Audits
15e7a52a6f53 API: libcrmcommon: Deprecate dedupXpathResults()
Author
nrwahl2
Browse Repository
No Audits
dcaf991ce416 Refactor: libcib: Drop dedupXpathResults() internally
Author
nrwahl2
Browse Repository
No Audits
bbb01939d504 Refactor: libcib: Skip dedupXpathResults() when there are no results
Author
nrwahl2
Browse Repository
No Audits
44fc9056e995 Refactor: libcib: Some best practices in cib_process_xpath()
Author
nrwahl2
Browse Repository
No Audits
8accd1a8013f Refactor: libcrmcommon: Reduce duplication in pcmk__check_acl()
Author
nrwahl2
Browse Repository
No Audits
047efb301ab4 Refactor: libcrmcommon: Improve argument name in pcmk__check_acl()
Author
nrwahl2
Browse Repository
No Audits
5fde764ca98b Refactor: libcrmcommon: Limit scope of xpath in pcmk__check_acl()
Author
nrwahl2
Browse Repository
No Audits
6cbc19b1a28a Refactor: libcrmcommon: Limit parent scope in pcmk__check_acl()
Author
nrwahl2
Browse Repository
No Audits
d763119b0967 Refactor: libcrmcommon: Remove level of nesting in pcmk__check_acl()
Author
nrwahl2
Browse Repository
No Audits
3d53058fbfb7 API: libcrmcommon: Deprecate freeXpathObject()
Author
nrwahl2
Browse Repository
No Audits
83a9215831e6 Refactor: various: Drop internal calls to freeXpathObject()
Author
nrwahl2
Browse Repository
No Audits
5fe98f4d2506 Fix: libcib: Don't match element based on XPath matching an attribute
Author
nrwahl2
Browse Repository
No Audits
89a44762a782 API: libcrmcommon: Deprecate getXpathResult()
Author
nrwahl2
Browse Repository
No Audits
012f8c5995fb Refactor: libcrmcommon: New pcmk__xpath_result()
Author
nrwahl2
Browse Repository
No Audits
62e27fe97959 Refactor: libstonithd: Query stonith devices more clearly
Author
nrwahl2
Browse Repository
No Audits
96801aab333a Refactor: libcrmcommon: Make xml_element_type_text() library-private
Author
nrwahl2
Browse Repository
No Audits
5fbfafae51f8 API: libcrmcommon: Deprecate numXpathResults()
Author
nrwahl2
Browse Repository
No Audits
bd4a6cc458d2 Refactor: libcrmcommon: New pcmk__xpath_num_results()
Author
nrwahl2
Browse Repository
No Audits
74bbcb2ea135 API: libcrmcommon: Deprecate xpath_search()
Author
nrwahl2
Browse Repository
No Audits
f87588f9b0cf Refactor: libcrmcommon: New pcmk__xpath_search()
Author
nrwahl2
Browse Repository
No Audits
628eeab266a9 Refactor: libcrmcommon: Move internal XPath functions to own header
Author
nrwahl2
Browse Repository
No Audits
651dc0653946 Refactor: various: Drop includes of stddef.h
Author
nrwahl2
Browse Repository
No Audits

Changes (36)

Path

Size

configure.ac

cts/

cli/

regression.acls.exp

daemons/

based/

based_callbacks.c

controld/

controld_remote_ra.c

controld_schedulerd.c

controld_te_callbacks.c

controld_te_events.c

fenced/

fenced_cib.c

fenced_commands.c

include/

crm/

common/

lib/

cib/

common/

fencing/

pacemaker/

tests/

pcmk_ticket/

pcmk__get_ticket_state_test.c

pcmk_ticket_constraints_test.c

pcmk_ticket_get_attr_test.c

pcmk_ticket_info_test.c

pcmk_ticket_state_test.c

pengine/

tools/

crm_resource_runtime.c

rP8e0443587d10

View Options

configure.ac

View Options

cts/cli/regression.acls.exp

View Options

daemons/based/based_callbacks.c

View Options

daemons/controld/controld_remote_ra.c

View Options

daemons/controld/controld_schedulerd.c

View Options

daemons/controld/controld_te_callbacks.c

View Options

daemons/controld/controld_te_events.c

View Options

daemons/fenced/fenced_cib.c

View Options

daemons/fenced/fenced_commands.c

View Options

include/crm/common/acl_internal.h

View Options

include/crm/common/unittest_internal.h

View Options

include/crm/common/xml.h

View Options

include/crm/common/xml_compat.h

View Options

include/crm/common/xml_internal.h

View Options

include/crm/common/xpath_internal.h

View Options

lib/cib/cib_ops.c

View Options

lib/common/acl.c

View Options

lib/common/crmcommon_private.h

View Options

lib/common/mock.c

View Options

lib/common/xml.c

View Options

lib/common/xml_io.c

View Options

lib/common/xpath.c

View Options

lib/fencing/st_client.c

View Options

lib/fencing/st_rhcs.c

View Options

lib/pacemaker/pcmk_rule.c

View Options

lib/pacemaker/pcmk_status.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk__get_ticket_state_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_constraints_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_get_attr_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_info_test.c

View Options

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_state_test.c

View Options

lib/pengine/failcounts.c

View Options

lib/pengine/unpack.c

View Options

tools/crm_resource.c

View Options

tools/crm_resource_ban.c

View Options

tools/crm_resource_runtime.c

Merge pull request #3843 from nrwahl2/nrwahl2-refactors8e0443587d10Actions

Description

Details

Event Timeline

Merged Changes

Changes (36)

rP8e0443587d10

configure.ac

cts/cli/regression.acls.exp

daemons/based/based_callbacks.c

daemons/controld/controld_remote_ra.c

daemons/controld/controld_schedulerd.c

daemons/controld/controld_te_callbacks.c

daemons/controld/controld_te_events.c

daemons/fenced/fenced_cib.c

daemons/fenced/fenced_commands.c

include/crm/common/acl_internal.h

include/crm/common/unittest_internal.h

include/crm/common/xml.h

include/crm/common/xml_compat.h

include/crm/common/xml_internal.h

include/crm/common/xpath_internal.h

lib/cib/cib_ops.c

lib/common/acl.c

lib/common/crmcommon_private.h

lib/common/mock.c

lib/common/xml.c

lib/common/xml_io.c

lib/common/xpath.c

lib/fencing/st_client.c

lib/fencing/st_rhcs.c

lib/pacemaker/pcmk_rule.c

lib/pacemaker/pcmk_status.c

lib/pacemaker/tests/pcmk_ticket/pcmk__get_ticket_state_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_constraints_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_get_attr_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_info_test.c

lib/pacemaker/tests/pcmk_ticket/pcmk_ticket_state_test.c

lib/pengine/failcounts.c

lib/pengine/unpack.c

tools/crm_resource.c

tools/crm_resource_ban.c

tools/crm_resource_runtime.c

Merge pull request #3843 from nrwahl2/nrwahl2-refactors
8e0443587d10
Actions