Merge pull request #3386 from nrwahl2/nrwahl2-xml_attrs2
a966aeea6093
Actions

Description

Merge pull request #3386 from nrwahl2/nrwahl2-xml_attrs2

XML improvements: pcmkxe_create() through pcmkxe_remove_attr()

Details

Provenance

nrwahl2	Authored on Mar 25 2024, 11:34 PM
GitHub <noreply@github.com>	Committed on Mar 25 2024, 11:34 PM

Parents

rPbba877a63302: Merge pull request #3391 from kgaillot/best-practices
rP7d7182d8e86a: Refactor: libcrmcommon: Avoid copying for "%s" in pcmk__xe_set_content()

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPa966aeea6093: Merge pull request #3386 from nrwahl2/nrwahl2-xml_attrs2 (authored by nrwahl2).Mar 25 2024, 11:34 PM

Merged Changes

7d7182d8e86a Refactor: libcrmcommon: Avoid copying for "%s" in pcmk__xe_set_content()
Author
nrwahl2
Browse Repository
No Audits
7e908ca0a63d Refactor: libpe_status: Null-check pe__calculate_digests scheduler arg
Author
nrwahl2
Browse Repository
No Audits
9e0e4906a0a5 Refactor: libpe_status: Drop unused arg from pe__add_bundle_remote_name
Author
nrwahl2
Browse Repository
No Audits
c9d79f467ce3 Refactor: libcrmcommon: Drop pcmk__xe_first_child_any()
Author
nrwahl2
Browse Repository
No Audits
4a45a679f667 API: libcrmcommon: Deprecate xml_remove_prop()
Author
nrwahl2
Browse Repository
No Audits
d045c4a2f7d4 Refactor: various: xml_remove_prop -> pcmk__xe_remove_attr internally
Author
nrwahl2
Browse Repository
No Audits
8472e8d4bcac Refactor: libcrmcommon: Functionize removing XML attributes
Author
nrwahl2
Browse Repository
No Audits
ed4690b07bee API: libcrmcommon: Deprecate crm_next_same_xml()
Author
nrwahl2
Browse Repository
No Audits
ee8156dae307 Refactor: libcrmcommon: New pcmk__xe_next_same()
Author
nrwahl2
Browse Repository
No Audits
b29053c5cad8 API: libcrmcommon: Deprecate find_xml_node()
Author
nrwahl2
Browse Repository
No Audits
6e54efbf7a0e Refactor: various: Replace find_xml_node() with pcmk__xe_first_child()
Author
nrwahl2
Browse Repository
No Audits
f53075413575 Refactor: libcib: Ensure that find_xml_node() 2nd argument is non-NULL
Author
nrwahl2
Browse Repository
No Audits
a8d7a3aec4d4 API: libcrmcommon: Deprecate first_named_child()
Author
nrwahl2
Browse Repository
No Audits
d496f66b6a14 Refactor: libcrmcommon: first_named_child() -> pcmk__xe_first_child()
Author
nrwahl2
Browse Repository
No Audits
1b68fafcb80c Refactor: libcrmcommon: pcmk__xe_match() -> pcmk__xe_first_child()
Author
nrwahl2
Browse Repository
No Audits
a94e1f59ca29 Refactor: libcrmcommon: Rename pcmk__xe_first_child -> ..._any
Author
nrwahl2
Browse Repository
No Audits
20d4bfecf4dc Refactor: libcrmcommon: Accept NULL parent in pcmk__xe_match()
Author
nrwahl2
Browse Repository
No Audits
871f90134cad Refactor: libcrmcommon: Minor changes to pcmk__xe_match()
Author
nrwahl2
Browse Repository
No Audits
7c94f5a200a9 API: libcrmcommon: Deprecate pcmk_create_html_node()
Author
nrwahl2
Browse Repository
No Audits
b181294803ec Refactor: libcrmcommon: New pcmk__html_create()
Author
nrwahl2
Browse Repository
No Audits
a93af7929126 Refactor: libcrmcommon: Accept a format string in pcmk__xe_set_content()
Author
nrwahl2
Browse Repository
No Audits
497d7fb88459 API: libcrmcommon: Deprecate pcmk_create_xml_text_node()
Author
nrwahl2
Browse Repository
No Audits
1d083c43653f Refactor: libcrmcommon: Drop pcmk_create_xml_text_node() internally
Author
nrwahl2
Browse Repository
No Audits
4a562eb64b8f API: libcrmcommon: Deprecate create_xml_node()
Author
nrwahl2
Browse Repository
No Audits
5601c7a2f4ef Refactor: libcrmcommon: New pcmk__xe_create()
Author
nrwahl2
Browse Repository
No Audits

Changes (121)

Path

Size

daemons/

attrd/

based/

controld/

controld_execd_state.c

controld_join_client.c

controld_join_dc.c

controld_membership.c

controld_messages.c

controld_metadata.c

controld_remote_ra.c

controld_schedulerd.c

controld_te_actions.c

controld_te_callbacks.c

execd/

fenced/

pacemakerd/

schedulerd/

schedulerd_messages.c

include/

crm/

common/

pengine/

lib/

cib/

cluster/

common/

tests/

acl/

xml_acl_denied_test.c

xml_acl_enabled_test.c

actions/

copy_in_properties_test.c

expand_plus_plus_test.c

fix_plus_plus_recursive_test.c

nodes/

pcmk__xe_add_node_test.c

schemas/

pcmk__build_schema_xml_node_test.c

xml/

Makefile.am

	pcmk__xe_first_child_test.c
	pcmk__xe_match_test.c

pcmk__xe_match_test.c

fencing/

lrmd/

pacemaker/

pcmk_graph_consumer.c

pcmk_graph_producer.c

pcmk_sched_colocation.c

pcmk_sched_constraints.c

pcmk_sched_location.c

pcmk_sched_ordering.c

pcmk_sched_recurring.c

pengine/

tools/

crm_resource_runtime.c

crm_shadow.c

crm_simulate.c

crm_ticket.c

rPa966aeea6093

View Options

daemons/attrd/attrd_alerts.c

View Options

daemons/attrd/attrd_attributes.c

View Options

daemons/attrd/attrd_cib.c

View Options

daemons/attrd/attrd_corosync.c

View Options

daemons/attrd/attrd_ipc.c

View Options

daemons/attrd/attrd_messages.c

View Options

daemons/attrd/attrd_sync.c

View Options

daemons/based/based_callbacks.c

View Options

daemons/based/based_io.c

View Options

daemons/based/based_messages.c

View Options

daemons/based/based_notify.c

View Options

daemons/based/based_remote.c

View Options

daemons/based/based_transaction.c

View Options

daemons/controld/controld_cib.c

View Options

daemons/controld/controld_control.c

View Options

daemons/controld/controld_election.c

View Options

daemons/controld/controld_execd.c

View Options

daemons/controld/controld_execd_state.c

View Options

daemons/controld/controld_join_client.c

View Options

daemons/controld/controld_join_dc.c

View Options

daemons/controld/controld_membership.c

View Options

daemons/controld/controld_messages.c

View Options

daemons/controld/controld_metadata.c

View Options

daemons/controld/controld_remote_ra.c

View Options

daemons/controld/controld_schedulerd.c

View Options

daemons/controld/controld_te_actions.c

View Options

daemons/controld/controld_te_callbacks.c

View Options

daemons/controld/controld_te_utils.c

View Options

daemons/execd/execd_commands.c

View Options

daemons/execd/remoted_proxy.c

View Options

daemons/fenced/fenced_cib.c

View Options

daemons/fenced/fenced_commands.c

View Options

daemons/fenced/fenced_history.c

View Options

daemons/fenced/fenced_remote.c

View Options

daemons/fenced/pacemaker-fenced.c

View Options

daemons/pacemakerd/pcmkd_messages.c

View Options

daemons/schedulerd/schedulerd_messages.c

View Options

include/crm/common/output_internal.h

View Options

include/crm/common/xml.h

View Options

include/crm/common/xml_compat.h

View Options

include/crm/common/xml_internal.h

View Options

include/crm/pengine/internal.h

View Options

lib/cib/cib_attrs.c

View Options

lib/cib/cib_client.c

View Options

lib/cib/cib_file.c

View Options

lib/cib/cib_native.c

View Options

lib/cib/cib_ops.c

View Options

lib/cib/cib_remote.c

View Options

lib/cib/cib_utils.c

View Options

lib/cluster/corosync.c

View Options

lib/common/acl.c

View Options

lib/common/actions.c

View Options

lib/common/ipc_attrd.c

View Options

lib/common/ipc_client.c

View Options

lib/common/ipc_controld.c

View Options

lib/common/ipc_server.c

View Options

lib/common/messages.c

View Options

lib/common/nvpair.c

View Options

lib/common/options.c

View Options

lib/common/output_html.c

View Options

lib/common/output_log.c

View Options

lib/common/output_xml.c

View Options

lib/common/patchset.c

View Options

lib/common/patchset_display.c

View Options

lib/common/rules.c

View Options

lib/common/schemas.c

View Options

lib/common/tests/acl/xml_acl_denied_test.c

View Options

lib/common/tests/acl/xml_acl_enabled_test.c

View Options

lib/common/tests/actions/copy_in_properties_test.c

View Options

lib/common/tests/actions/expand_plus_plus_test.c

View Options

lib/common/tests/actions/fix_plus_plus_recursive_test.c

View Options

lib/common/tests/nodes/pcmk__xe_add_node_test.c

View Options

lib/common/tests/schemas/pcmk__build_schema_xml_node_test.c

View Options

lib/common/tests/xml/Makefile.am

View Options

lib/common/tests/xml/pcmk__xe_first_child_test.c

View Options

lib/common/tests/xml/pcmk__xe_match_test.c

View Options

lib/common/xml.c

View Options

lib/fencing/st_client.c

View Options

lib/fencing/st_rhcs.c

View Options

lib/lrmd/lrmd_client.c

View Options

lib/lrmd/proxy_common.c

View Options

lib/pacemaker/pcmk_graph_consumer.c

View Options

lib/pacemaker/pcmk_graph_producer.c

View Options

lib/pacemaker/pcmk_injections.c

View Options

lib/pacemaker/pcmk_output.c

View Options

lib/pacemaker/pcmk_resource.c

View Options

lib/pacemaker/pcmk_sched_actions.c

View Options

lib/pacemaker/pcmk_sched_bundle.c

View Options

lib/pacemaker/pcmk_sched_colocation.c

View Options

lib/pacemaker/pcmk_sched_constraints.c

View Options

lib/pacemaker/pcmk_sched_location.c

View Options

lib/pacemaker/pcmk_sched_ordering.c

View Options

lib/pacemaker/pcmk_sched_recurring.c

View Options

lib/pacemaker/pcmk_sched_tickets.c

View Options

lib/pacemaker/pcmk_simulate.c

View Options

lib/pacemaker/pcmk_verify.c

View Options

lib/pengine/bundle.c

View Options

lib/pengine/clone.c

View Options

lib/pengine/complex.c

View Options

lib/pengine/group.c

View Options

lib/pengine/native.c

View Options

lib/pengine/pe_actions.c

View Options

lib/pengine/pe_digest.c

View Options

lib/pengine/pe_output.c

View Options

lib/pengine/remote.c

View Options

lib/pengine/rules.c

View Options

lib/pengine/rules_alerts.c

View Options

lib/pengine/status.c

View Options

lib/pengine/unpack.c

View Options

lib/pengine/utils.c

View Options

tools/cibadmin.c

View Options

tools/crm_diff.c

View Options

tools/crm_mon.c

View Options

tools/crm_node.c

View Options

tools/crm_resource.c

View Options

tools/crm_resource_ban.c

View Options

tools/crm_resource_print.c

View Options

tools/crm_resource_runtime.c

View Options

tools/crm_shadow.c

View Options

tools/crm_simulate.c

View Options

Merge pull request #3386 from nrwahl2/nrwahl2-xml_attrs2a966aeea6093Actions

Description

Details

Event Timeline

Merged Changes

Changes (121)

rPa966aeea6093

daemons/attrd/attrd_alerts.c

daemons/attrd/attrd_attributes.c

daemons/attrd/attrd_cib.c

daemons/attrd/attrd_corosync.c

daemons/attrd/attrd_ipc.c

daemons/attrd/attrd_messages.c

daemons/attrd/attrd_sync.c

daemons/based/based_callbacks.c

daemons/based/based_io.c

daemons/based/based_messages.c

daemons/based/based_notify.c

daemons/based/based_remote.c

daemons/based/based_transaction.c

daemons/controld/controld_cib.c

daemons/controld/controld_control.c

daemons/controld/controld_election.c

daemons/controld/controld_execd.c

daemons/controld/controld_execd_state.c

daemons/controld/controld_join_client.c

daemons/controld/controld_join_dc.c

daemons/controld/controld_membership.c

daemons/controld/controld_messages.c

daemons/controld/controld_metadata.c

daemons/controld/controld_remote_ra.c

daemons/controld/controld_schedulerd.c

daemons/controld/controld_te_actions.c

daemons/controld/controld_te_callbacks.c

daemons/controld/controld_te_utils.c

daemons/execd/execd_commands.c

daemons/execd/remoted_proxy.c

daemons/fenced/fenced_cib.c

daemons/fenced/fenced_commands.c

daemons/fenced/fenced_history.c

daemons/fenced/fenced_remote.c

daemons/fenced/pacemaker-fenced.c

daemons/pacemakerd/pcmkd_messages.c

daemons/schedulerd/schedulerd_messages.c

include/crm/common/output_internal.h

include/crm/common/xml.h

include/crm/common/xml_compat.h

include/crm/common/xml_internal.h

include/crm/pengine/internal.h

lib/cib/cib_attrs.c

lib/cib/cib_client.c

lib/cib/cib_file.c

lib/cib/cib_native.c

lib/cib/cib_ops.c

lib/cib/cib_remote.c

lib/cib/cib_utils.c

lib/cluster/corosync.c

lib/common/acl.c

lib/common/actions.c

lib/common/ipc_attrd.c

lib/common/ipc_client.c

lib/common/ipc_controld.c

lib/common/ipc_server.c

lib/common/messages.c

lib/common/nvpair.c

lib/common/options.c

lib/common/output_html.c

lib/common/output_log.c

lib/common/output_xml.c

lib/common/patchset.c

lib/common/patchset_display.c

lib/common/rules.c

lib/common/schemas.c

lib/common/tests/acl/xml_acl_denied_test.c

lib/common/tests/acl/xml_acl_enabled_test.c

lib/common/tests/actions/copy_in_properties_test.c

lib/common/tests/actions/expand_plus_plus_test.c

lib/common/tests/actions/fix_plus_plus_recursive_test.c

lib/common/tests/nodes/pcmk__xe_add_node_test.c

lib/common/tests/schemas/pcmk__build_schema_xml_node_test.c

Merge pull request #3386 from nrwahl2/nrwahl2-xml_attrs2
a966aeea6093
Actions