Merge pull request #2887 from kgaillot/best-practices
c6c7816551e1
Actions

Description

Merge pull request #2887 from kgaillot/best-practices

Best practices for primitive-related functions in libpacemaker

Details

Provenance

kgaillot	Authored on Sep 28 2022, 10:12 AM
GitHub <noreply@github.com>	Committed on Sep 28 2022, 10:12 AM

Parents

rP517706f52de3: Doc: scheduler: note ignored argument to primitive action_flags() implementation
rPb7bf3a643e8a: Merge pull request #2882 from nrwahl2/nrwahl2-T152_imp

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPc6c7816551e1: Merge pull request #2887 from kgaillot/best-practices (authored by kgaillot).Sep 28 2022, 10:12 AM

Merged Changes

517706f52de3 Doc: scheduler: note ignored argument to primitive action_flags() implementation
Author
kgaillot
Browse Repository
No Audits
dc4948431b84 Refactor: scheduler: drop redundant argument from schedule_restart_actions()
Author
kgaillot
Browse Repository
No Audits
8502d22af903 Test: cts-cli: update expected outputs for function rename
Author
kgaillot
Browse Repository
No Audits
e7f492709192 Refactor: scheduler: rename pcmk__assign_primitive()
Author
kgaillot
Browse Repository
No Audits
8dfa3b06cb2b Refactor: scheduler: rename rsc_location() resource method
Author
kgaillot
Browse Repository
No Audits
5f55f48e81fb Refactor: scheduler: use pcmk__apply_location() as primitive resource method
Author
kgaillot
Browse Repository
No Audits
64ca7641754c Refactor: scheduler: reverse argument order to pcmk__apply_location()
Author
kgaillot
Browse Repository
No Audits
724ab9559abe Refactor: scheduler: best practices for native_action_flags()
Author
kgaillot
Browse Repository
No Audits
e5b5fe840e71 Refactor: scheduler: make node argument to action_flags() const
Author
kgaillot
Browse Repository
No Audits
48cb63d65bba Refactor: libpe_status: all arguments to find_first_action() are now const
Author
kgaillot
Browse Repository
No Audits
dd3a4dbcec4b Refactor: scheduler: best practices for native_internal_constraints()
Author
kgaillot
Browse Repository
No Audits
1f75d5a81f0a Doc: scheduler: add a doxygen block to rsc_avoids_remote_nodes()
Author
kgaillot
Browse Repository
No Audits
5a8a9d3d5759 Refactor: scheduler: best practices for native_create_actions()
Author
kgaillot
Browse Repository
No Audits
e514d3c09036 Refactor: scheduler: functionize bringing resource to next role
Author
kgaillot
Browse Repository
No Audits
856c7c8758c8 Refactor: scheduler: functionize creating pending start
Author
kgaillot
Browse Repository
No Audits
08daef80c63b Refactor: scheduler: functionize setting resource's next role to default
Author
kgaillot
Browse Repository
No Audits

Changes (12)

Path

Size

cts/

cli/

regression.tools.exp

include/

crm/

pengine/

internal.h

pcmki/

pcmki_sched_allocate.h

pcmki_sched_utils.h

lib/

pacemaker/

libpacemaker_private.h

pcmk_sched_bundle.c

pcmk_sched_clone.c

pcmk_sched_group.c

pcmk_sched_location.c

pcmk_sched_primitive.c

pcmk_sched_resource.c

pengine/

pe_actions.c

rPc6c7816551e1

View Options

cts/cli/regression.tools.exp

View Options

include/crm/pengine/internal.h

View Options

include/pcmki/pcmki_sched_allocate.h

View Options

include/pcmki/pcmki_sched_utils.h

View Options

lib/pacemaker/libpacemaker_private.h

View Options

lib/pacemaker/pcmk_sched_bundle.c

View Options

lib/pacemaker/pcmk_sched_clone.c

View Options

lib/pacemaker/pcmk_sched_group.c

View Options

lib/pacemaker/pcmk_sched_location.c

View Options

lib/pacemaker/pcmk_sched_primitive.c

View Options

lib/pacemaker/pcmk_sched_resource.c

View Options

Merge pull request #2887 from kgaillot/best-practicesc6c7816551e1Actions

Description

Details

Event Timeline

Merged Changes

Changes (12)

rPc6c7816551e1

cts/cli/regression.tools.exp

include/crm/pengine/internal.h

include/pcmki/pcmki_sched_allocate.h

include/pcmki/pcmki_sched_utils.h

lib/pacemaker/libpacemaker_private.h

lib/pacemaker/pcmk_sched_bundle.c

lib/pacemaker/pcmk_sched_clone.c

lib/pacemaker/pcmk_sched_group.c

lib/pacemaker/pcmk_sched_location.c

lib/pacemaker/pcmk_sched_primitive.c

lib/pacemaker/pcmk_sched_resource.c

lib/pengine/pe_actions.c

Merge pull request #2887 from kgaillot/best-practices
c6c7816551e1
Actions