Merge pull request #2820 from nrwahl2/nrwahl2-T534
e5a90de67c77
Actions

Description

Merge pull request #2820 from nrwahl2/nrwahl2-T534

Refactor: libpe_status: Bring two functions up to current guidelines

Details

Provenance

kgaillot	Authored on Aug 25 2022, 10:34 AM
GitHub <noreply@github.com>	Committed on Aug 25 2022, 10:34 AM

Parents

rPccd80839f3d6: Merge pull request #2825 from nrwahl2/nrwahl2-T541
rP89860690adce: Test: libpe_status: Unit tests for pe__cmp_rsc_priority()

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPe5a90de67c77: Merge pull request #2820 from nrwahl2/nrwahl2-T534 (authored by kgaillot).Aug 25 2022, 10:34 AM

Merged Changes

89860690adce Test: libpe_status: Unit tests for pe__cmp_rsc_priority()
Author
nrwahl2
Browse Repository
No Audits
b37203d4aa37 Build: libpe_status: Expose internal library functions for unit testing
Author
nrwahl2
Browse Repository
No Audits
9b99e678a2d1 Build: libpe_rules, libpe_status: Add -DPCMK__UNIT_TESTING to test libs
Author
nrwahl2
Browse Repository
No Audits
28eed4668f74 Test: libpe_status: Unit tests for pe__cmp_node_name()
Author
nrwahl2
Browse Repository
No Audits
2e8f37e77f35 Low: libcrmcommon: NULL-check pcmk__numeric_strcasecmp()
Author
nrwahl2
Browse Repository
No Audits
be3a575a6fe3 Low: libpe_status: Let pe__cmp_node_name() handle NULL values
Author
nrwahl2
Browse Repository
No Audits
78c7f4dbb13a Refactor: libpe_status: sort_rsc_priority() -> pe__cmp_rsc_priority()
Author
nrwahl2
Browse Repository
No Audits
39e1e7b1bc49 Refactor: libpe_status: Rename sort_node_uname() pe__cmp_node_name()
Author
nrwahl2
Browse Repository
No Audits

Changes (16)

Path

Size

configure.ac

include/

crm/

pengine/

internal.h

lib/

common/

strings.c

tests/

strings/

pcmk__numeric_strcasecmp_test.c

pacemaker/

pengine/

tests/

pe__cmp_node_name_test.c

pe__cmp_rsc_priority_test.c

	utils/
	unpack/

Makefile.am

unpack.c

utils.c

rPe5a90de67c77

View Options

configure.ac

View Options

include/crm/pengine/internal.h

View Options

lib/common/strings.c

View Options

lib/common/tests/strings/pcmk__numeric_strcasecmp_test.c

View Options

lib/pacemaker/pcmk_sched_native.c

View Options

lib/pengine/Makefile.am

View Options

lib/pengine/clone.c

View Options

lib/pengine/pe_notif.c

View Options

lib/pengine/pe_status_private.h

View Options

lib/pengine/tests/Makefile.am

View Options

lib/pengine/tests/utils/Makefile.am

View Options

lib/pengine/tests/utils/pe__cmp_node_name_test.c

View Options

lib/pengine/tests/utils/pe__cmp_rsc_priority_test.c

View Options

lib/pengine/unpack.c

View Options

Merge pull request #2820 from nrwahl2/nrwahl2-T534e5a90de67c77Actions

Description

Details

Event Timeline

Merged Changes

Changes (16)

rPe5a90de67c77

configure.ac

include/crm/pengine/internal.h

lib/common/strings.c

lib/common/tests/strings/pcmk__numeric_strcasecmp_test.c

lib/pacemaker/pcmk_sched_native.c

lib/pengine/Makefile.am

lib/pengine/clone.c

lib/pengine/pe_notif.c

lib/pengine/pe_status_private.h

lib/pengine/tests/Makefile.am

lib/pengine/tests/utils/Makefile.am

lib/pengine/tests/utils/pe__cmp_node_name_test.c

lib/pengine/tests/utils/pe__cmp_rsc_priority_test.c

lib/pengine/unpack.c

lib/pengine/utils.c

Merge pull request #2820 from nrwahl2/nrwahl2-T534
e5a90de67c77
Actions