Page MenuHomeClusterLabs Projects

rpmlint make target fails
Closed (Merged)Public

Assigned To
Authored By
nrwahl2
Jan 26 2024, 2:13 AM
Tags
  • Restricted Project
  • Restricted Project
  • Restricted Project
  • Restricted Project
Referenced Files
None
Subscribers

Description

This is a regression, but there's very little impact. It's not even enabled in the CI script.

The -f rpmlintrc option is invalid; the correct option is -r rpmlintrc.

Even after fixing that, we get the following errors:

rpmlint -r rpmlintrc "/home/reid/git/pacemaker/rpm/SPECS/pacemaker.spec"
========================= rpmlint session starts =========================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('rpmlintrc')]
checks: 32, packages: 1

pacemaker.spec: E: unused-rpmlintrc-filter "E: hardcoded-library-path in %{_prefix}/lib/ocf"
pacemaker.spec: E: unused-rpmlintrc-filter "E: hardcoded-library-path in /usr/lib/os-release"
pacemaker.spec: E: unused-rpmlintrc-filter "W: invalid-url Source0:"
pacemaker.spec: E: unused-rpmlintrc-filter "W: unstripped-binary-or-object"
pacemaker.spec: E: unused-rpmlintrc-filter "W: incoherent-version-in-changelog"
pacemaker.spec: E: unused-rpmlintrc-filter "E: changelog-time-in-future"
pacemaker.spec: E: unused-rpmlintrc-filter "E: incoherent-logrotate-file /etc/logrotate.d/pacemaker"
pacemaker.spec: E: unused-rpmlintrc-filter "W: dangerous-command-in-%(pre|postun|posttrans) rm"
pacemaker.spec: E: unused-rpmlintrc-filter "W: incoherent-init-script-name pacemaker_remote"
pacemaker.spec: E: unused-rpmlintrc-filter "W: empty-%(post|pre|preun|postun|posttrans)"
 0 packages and 1 specfiles checked; 10 errors, 0 warnings, 4 filtered, 10 badness; has taken 0.2 s 
make: *** [Makefile:933: rpmlint] Error 64
make: Leaving directory '/home/reid/git/pacemaker/rpm'

rpmlint v2.0 was released in May 2021. The last time we touched anything related to rpmlint was in March 2022 (8b6412a). It's likely that our dev systems were using v1.x at the time, and that the switch to 2.0 breaks our uses of rpmlint.

https://github.com/rpm-software-management/rpmlint/releases/tag/2.0.0

Event Timeline

nrwahl2 triaged this task as Normal priority.Jan 26 2024, 2:13 AM
nrwahl2 created this task.
nrwahl2 created this object with edit policy "Restricted Project (Project)".

Inform Fabio when it's fixed

clumens changed the task status from Open to WIP.Tue, Jan 30, 2:23 PM
clumens claimed this task.
kgaillot edited projects, added Restricted Project; removed Restricted Project.Thu, Feb 1, 7:04 PM