Merge pull request #3347 from kgaillot/best-practices
0db01aa3154e
Actions

Description

Merge pull request #3347 from kgaillot/best-practices

Best practices for some scheduler functions

Details

Provenance

kgaillot	Authored on Feb 6 2024, 1:12 PM
GitHub <noreply@github.com>	Committed on Feb 6 2024, 1:12 PM

Parents

rP31fa65c1e9e4: Refactor: scheduler: drop add_hash_param()
rP5dad45a6ce2b: Merge pull request #3346 from nrwahl2/nrwahl2-xml_attrs3

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP0db01aa3154e: Merge pull request #3347 from kgaillot/best-practices (authored by kgaillot).Feb 6 2024, 1:12 PM

Merged Changes

31fa65c1e9e4 Refactor: scheduler: drop add_hash_param()
Author
kgaillot
Browse Repository
No Audits
c87b862847c5 Test: scheduler: update expected graph for meta-attribute change
Author
kgaillot
Browse Repository
No Audits
539b02c81474 Refactor: scheduler: add pcmk__insert_meta()
Author
kgaillot
Browse Repository
No Audits
dc9854cdb395 Refactor: various: assert on memory errors for hash table keys/values
Author
kgaillot
Browse Repository
No Audits
c6baad6bea5b Refactor: libcrmcommon: best practices for crm_meta_value()
Author
kgaillot
Browse Repository
No Audits
4c2ae55f9839 Refactor: libcrmcommon: best practices for crm_meta_name()
Author
kgaillot
Browse Repository
No Audits
893f67d0324e Refactor: libcrmcommon: move crm_meta_name() and crm_meta_value()
Author
kgaillot
Browse Repository
No Audits

Changes (45)

Path

Size

cts/

scheduler/

exp/

utilization-order4.exp

daemons/

controld/

fenced/

include/

crm/

common/

pengine/

lib/

common/

alerts.c

nvpair.c

strings.c

tests/

nvpair/

Makefile.am

	nvpair/
	utils/

crm_meta_name_test.c

crm_meta_value_test.c

utils/

Makefile.am

crm_meta_name_test.c

crm_meta_value_test.c

fencing/

lrmd/

pacemaker/

pcmk_graph_consumer.c

pcmk_graph_producer.c

pcmk_sched_actions.c

pcmk_sched_bundle.c

pcmk_sched_migration.c

pcmk_sched_probes.c

pcmk_sched_recurring.c

pengine/

tools/

crm_resource_runtime.c

crm_ticket.c

rP0db01aa3154e

View Options

cts/scheduler/exp/utilization-order4.exp

View Options

daemons/controld/controld_execd.c

View Options

daemons/controld/controld_messages.c

View Options

daemons/controld/controld_remote_ra.c

View Options

daemons/fenced/fenced_commands.c

View Options

include/crm/common/internal.h

View Options

include/crm/common/nvpair.h

View Options

include/crm/common/nvpair_internal.h

View Options

include/crm/common/strings_internal.h

View Options

include/crm/common/util.h

View Options

include/crm/pengine/internal.h

View Options

lib/common/alerts.c

View Options

lib/common/nvpair.c

View Options

lib/common/strings.c

View Options

lib/common/tests/nvpair/Makefile.am

View Options

lib/common/tests/nvpair/crm_meta_name_test.c

View Options

lib/common/tests/nvpair/crm_meta_value_test.c

View Options

lib/common/tests/utils/Makefile.am

View Options

lib/common/tests/utils/crm_meta_name_test.c

View Options

lib/common/tests/utils/crm_meta_value_test.c

View Options

lib/common/utils.c

View Options

lib/fencing/st_actions.c

View Options

lib/fencing/st_client.c

View Options

lib/lrmd/lrmd_client.c

View Options

lib/pacemaker/pcmk_graph_consumer.c

View Options

lib/pacemaker/pcmk_graph_producer.c

View Options

lib/pacemaker/pcmk_sched_actions.c

View Options

lib/pacemaker/pcmk_sched_bundle.c

View Options

lib/pacemaker/pcmk_sched_migration.c

View Options

lib/pacemaker/pcmk_sched_probes.c

View Options

lib/pacemaker/pcmk_sched_recurring.c

View Options

lib/pacemaker/pcmk_sched_remote.c

View Options

lib/pengine/bundle.c

View Options

lib/pengine/clone.c

View Options

lib/pengine/common.c

View Options

lib/pengine/complex.c

View Options

lib/pengine/failcounts.c

View Options

lib/pengine/native.c

View Options

lib/pengine/pe_actions.c

View Options

lib/pengine/pe_notif.c

View Options

lib/pengine/rules.c

View Options

lib/pengine/rules_alerts.c

View Options

lib/pengine/unpack.c

View Options

tools/crm_resource_runtime.c

View Options

Merge pull request #3347 from kgaillot/best-practices0db01aa3154eActions

Description

Details

Event Timeline

Merged Changes

Changes (45)

rP0db01aa3154e

cts/scheduler/exp/utilization-order4.exp

daemons/controld/controld_execd.c

daemons/controld/controld_messages.c

daemons/controld/controld_remote_ra.c

daemons/fenced/fenced_commands.c

include/crm/common/internal.h

include/crm/common/nvpair.h

include/crm/common/nvpair_internal.h

include/crm/common/strings_internal.h

include/crm/common/util.h

include/crm/pengine/internal.h

lib/common/alerts.c

lib/common/nvpair.c

lib/common/strings.c

lib/common/tests/nvpair/Makefile.am

lib/common/tests/nvpair/crm_meta_name_test.c

lib/common/tests/nvpair/crm_meta_value_test.c

lib/common/tests/utils/Makefile.am

lib/common/tests/utils/crm_meta_name_test.c

lib/common/tests/utils/crm_meta_value_test.c

lib/common/utils.c

lib/fencing/st_actions.c

lib/fencing/st_client.c

lib/lrmd/lrmd_client.c

lib/pacemaker/pcmk_graph_consumer.c

lib/pacemaker/pcmk_graph_producer.c

lib/pacemaker/pcmk_sched_actions.c

lib/pacemaker/pcmk_sched_bundle.c

lib/pacemaker/pcmk_sched_migration.c

lib/pacemaker/pcmk_sched_probes.c

lib/pacemaker/pcmk_sched_recurring.c

lib/pacemaker/pcmk_sched_remote.c

lib/pengine/bundle.c

lib/pengine/clone.c

lib/pengine/common.c

lib/pengine/complex.c

lib/pengine/failcounts.c

lib/pengine/native.c

lib/pengine/pe_actions.c

lib/pengine/pe_notif.c

lib/pengine/rules.c

lib/pengine/rules_alerts.c

lib/pengine/unpack.c

tools/crm_resource_runtime.c

tools/crm_ticket.c

Merge pull request #3347 from kgaillot/best-practices
0db01aa3154e
Actions