Merge pull request #1454 from kgaillot/changes20
40519e21140f
Actions

Description

Merge pull request #1454 from kgaillot/changes20

Fix issues found by static analysis

Details

Provenance

kgaillot	Authored on Apr 6 2018, 10:57 PM
GitHub <noreply@github.com>	Committed on Apr 6 2018, 10:57 PM

Parents

rPa40c1d32362f: Build: update shared object versions for 2.0.0-rc2
rP54e5b206dd74: Merge pull request #1452 from jnpkrn/schema-upgrade-temporary-fix

Branches

Tags

Event Timeline

Merged Changes

a40c1d32362f Build: update shared object versions for 2.0.0-rc2
Author
kgaillot
Browse Repository
No Audits
f6e5b216e0a8 Refactor: libcrmcommon: add a byte to pid file holder
Author
kgaillot
Browse Repository
No Audits
0a21e9ca3c1e Test: cts-cli: update schema message
Author
kgaillot
Browse Repository
No Audits
e3d137764cb7 Test: cts: remove cts-pengine-autofix for now
Author
kgaillot
Browse Repository
No Audits
55b023527ad8 Low: attrd,cib,libcrmcommon: avoid %z
Author
kgaillot
Browse Repository
No Audits
cfbfa00ebea8 Doc: Pacemaker Development: more detail on how to configure executables
Author
kgaillot
Browse Repository
No Audits
bbbb744cf455 Build: configure: update copyright
Author
kgaillot
Browse Repository
No Audits
673ca443d902 Low: crmd: avoid memory leak when synthesizing operation result
Author
kgaillot
Browse Repository
No Audits
4427c3f11aab Low: tools: avoid memory leak on invalid resource
Author
kgaillot
Browse Repository
No Audits
ae0916dbfff6 Log: crmd: log rc code as extended information
Author
kgaillot
Browse Repository
No Audits
9651ff6d0c28 Refactor: cib: remove dead code
Author
kgaillot
Browse Repository
No Audits
53aa7af48b5e Refactor: fencing: remove dead code
Author
kgaillot
Browse Repository
No Audits
c423c14ce31e Refactor: crmd: remove dead code
Author
kgaillot
Browse Repository
No Audits
6b6113ad336d Refactor: attrd: remove dead code
Author
kgaillot
Browse Repository
No Audits
12913f29ea52 Refactor: mcp: remove dead code
Author
kgaillot
Browse Repository
No Audits
516addeaf58f Low: cib: avoid file descriptor leak on temporary file creation
Author
kgaillot
Browse Repository
No Audits
ce06b7496076 Refactor: pengine: avoid redundant test
Author
kgaillot
Browse Repository
No Audits
ea57b122ce5f Build: libcrmservice: allow compiling when LSB_ROOT_DIR is undefined
Author
kgaillot
Browse Repository
No Audits
88eaf594a3f0 Low: libcrmcommon: handle compression failures properly
Author
kgaillot
Browse Repository
No Audits
238337a96ed2 Refactor: libcrmcommon: make reading stdin XML more efficient
Author
kgaillot
Browse Repository
No Audits
103e20b10940 Build: libcrmcommon: allow compiling without monotonic clock
Author
kgaillot
Browse Repository
No Audits
8031af606a04 Refactor: libcrmcommon: improve empty string check
Author
kgaillot
Browse Repository
No Audits
4ec2425921c7 Refactor: libcrmcommon: drop unused struct members
Author
kgaillot
Browse Repository
No Audits
78721461def7 Refactor: cib: avoid function argument confusion
Author
kgaillot
Browse Repository
No Audits
9c4ec7807958 Low: various: improve NULL checks
Author
kgaillot
Browse Repository
No Audits
c9e02cd1a736 Low: libcrmcommon: improve patch xpath searches
Author
kgaillot
Browse Repository
No Audits
3ffb66924bc9 Low: libcrmcommon,tools: use format strings appropriate to variables
Author
kgaillot
Browse Repository
No Audits
1db8425644f8 Low: libcrmcommon: use correct argument type for duration
Author
kgaillot
Browse Repository
No Audits
fce929819f4f Low: libcrmcluster: avoid potential use-of-NULL
Author
kgaillot
Browse Repository
No Audits
14f6d284400f Build: make cppcheck: allow passing extra arguments to cppcheck
Author
kgaillot
Browse Repository
No Audits
778df67e2b11 Refactor: various: avoid setting and checking same variable in CRM_CHECK()
Author
kgaillot
Browse Repository
No Audits
ae63b3155bd1 Low: libcrmcommon,libstonithd: avoid resource leaks
Author
kgaillot
Browse Repository
No Audits
11c08ee2d7a4 Low: tools: get sensor lun in ipmiservicelogd before using it
Author
kgaillot
Browse Repository
No Audits
cc7103a8e560 Test: all: don't run cppcheck and clang checks by default
Author
kgaillot
Browse Repository
No Audits
9a1623398d88 Test: cts-pengine: allow specifying single tests as input file name
Author
kgaillot
Browse Repository
No Audits
014156e0a6ef Doc: Pacemaker Explained: document new add-host bundle property
Author
kgaillot
Browse Repository
No Audits

Changes (76)

Path

Size

attrd/

cib/

crmd/

cts/

cts-pengine-autofix.py

cts-pengine.in

doc/

Pacemaker_Development/

en-US/

Ch-Python.txt

Pacemaker_Explained/

en-US/

Ch-Advanced-Resources.txt

fencing/

commands.c

internal.h

include/

crm/

cib.h

cib/

internal.h

stonith-ng.h

lib/

cib/

cluster/

common/

fencing/

lrmd/

pengine/

services/

transition/

lrmd/

mcp/

pengine/

replace/

tools/

rP40519e21140f

View Options

.gitignore

View Options

GNUmakefile

View Options

attrd/attrd_common.c

View Options

attrd/attrd_common.h

View Options

attrd/commands.c

View Options

cib/callbacks.c

View Options

cib/cibio.h

View Options

cib/common.c

View Options

cib/io.c

View Options

cib/messages.c

View Options

cib/notify.c

View Options

cib/notify.h

View Options

configure.ac

View Options

crmd/control.c

View Options

crmd/election.c

View Options

crmd/fsa.c

View Options

crmd/fsa_proto.h

View Options

crmd/join_client.c

View Options

crmd/join_dc.c

View Options

crmd/lrm.c

View Options

crmd/messages.c

View Options

crmd/pengine.c

View Options

crmd/te_actions.c

View Options

crmd/tengine.c

View Options

crmd/utils.c

View Options

cts/Makefile.am

View Options

cts/cts-cli

View Options

cts/cts-pengine-autofix.py

View Options

cts/cts-pengine.in

View Options

doc/Pacemaker_Development/en-US/Ch-Python.txt

View Options

doc/Pacemaker_Explained/en-US/Ch-Advanced-Resources.txt

View Options

fencing/commands.c

View Options

fencing/internal.h

View Options

include/crm/cib.h

View Options

include/crm/cib/internal.h

View Options

include/crm/stonith-ng.h

View Options

lib/cib/Makefile.am

View Options

lib/cib/cib_ops.c

View Options

lib/cib/cib_utils.c

View Options

lib/cluster/Makefile.am

View Options

lib/cluster/election.c

View Options

lib/common/Makefile.am

View Options

lib/common/cib_secrets.c

View Options

lib/common/ipc.c

View Options

lib/common/iso8601.c

View Options

lib/common/mainloop.c

View Options

lib/common/results.c

View Options

lib/common/strings.c

View Options

lib/common/utils.c

View Options

lib/common/xml.c

View Options

lib/fencing/Makefile.am

View Options

lib/fencing/st_client.c

View Options

lib/lrmd/Makefile.am

View Options

lib/pengine/Makefile.am

View Options

lib/pengine/clone.c

View Options

lib/pengine/group.c

View Options

lib/pengine/native.c

View Options

lib/pengine/utils.c

View Options

lib/services/Makefile.am

View Options

lib/services/services.c

View Options

lib/transition/Makefile.am

View Options

lrmd/lrmd.c

View Options

lrmd/test.c

View Options

mcp/pacemaker.c

View Options

mcp/pacemaker.h

View Options

pengine/Makefile.am

View Options

pengine/allocate.c

View Options

pengine/clone.c

View Options

pengine/constraints.c

View Options

pengine/group.c

View Options

pengine/notif.c

View Options

replace/scandir.c

View Options

tools/crm_node.c

View Options

tools/crm_simulate.c

View Options

tools/fake_transition.c

View Options

Merge pull request #1454 from kgaillot/changes2040519e21140fActions

Description

Details

Event Timeline

Merged Changes

Changes (76)

rP40519e21140f

.gitignore

GNUmakefile

attrd/attrd_common.c

attrd/attrd_common.h

attrd/commands.c

cib/callbacks.c

cib/cibio.h

cib/common.c

cib/io.c

cib/messages.c

cib/notify.c

cib/notify.h

configure.ac

crmd/control.c

crmd/election.c

crmd/fsa.c

crmd/fsa_proto.h

crmd/join_client.c

crmd/join_dc.c

crmd/lrm.c

crmd/messages.c

crmd/pengine.c

crmd/te_actions.c

crmd/tengine.c

crmd/utils.c

cts/Makefile.am

cts/cts-cli

cts/cts-pengine-autofix.py

cts/cts-pengine.in

doc/Pacemaker_Development/en-US/Ch-Python.txt

doc/Pacemaker_Explained/en-US/Ch-Advanced-Resources.txt

fencing/commands.c

fencing/internal.h

include/crm/cib.h

include/crm/cib/internal.h

include/crm/stonith-ng.h

lib/cib/Makefile.am

lib/cib/cib_ops.c

lib/cib/cib_utils.c

lib/cluster/Makefile.am

lib/cluster/election.c

lib/common/Makefile.am

lib/common/cib_secrets.c

lib/common/ipc.c

lib/common/iso8601.c

lib/common/mainloop.c

lib/common/results.c

lib/common/strings.c

lib/common/utils.c

lib/common/xml.c

lib/fencing/Makefile.am

lib/fencing/st_client.c

lib/lrmd/Makefile.am

lib/pengine/Makefile.am

lib/pengine/clone.c

lib/pengine/group.c

lib/pengine/native.c

lib/pengine/utils.c

lib/services/Makefile.am

lib/services/services.c

lib/transition/Makefile.am

lrmd/lrmd.c

lrmd/test.c

mcp/pacemaker.c

mcp/pacemaker.h

pengine/Makefile.am

pengine/allocate.c

pengine/clone.c

pengine/constraints.c

pengine/group.c

pengine/notif.c

replace/scandir.c

tools/crm_node.c

Merge pull request #1454 from kgaillot/changes20
40519e21140f
Actions