Merge pull request #3134 from kgaillot/best-practices
40a261ccc332
Actions

Description

Merge pull request #3134 from kgaillot/best-practices

Finish best practices for libpacemaker

Details

Provenance

kgaillot	Authored on Jun 20 2023, 3:29 PM
GitHub <noreply@github.com>	Committed on Jun 20 2023, 3:29 PM

Parents

rPb14eb1668cca: Refactor: libpacemaker: keep all lines to maximum 80 characters
rP0b8456209750: Merge pull request #3133 from kgaillot/build

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP40a261ccc332: Merge pull request #3134 from kgaillot/best-practices (authored by kgaillot).Jun 20 2023, 3:29 PM

Merged Changes

b14eb1668cca Refactor: libpacemaker: keep all lines to maximum 80 characters
Author
kgaillot
Browse Repository
No Audits
b0a9ce2b20eb Low: scheduler: check pointer for NULL *before* dereferencing it
Author
kgaillot
Browse Repository
No Audits
0d056e00faba Refactor: libpacemaker: use pcmk__str_eq() instead of pcmk__strcmp()
Author
kgaillot
Browse Repository
No Audits
0b56aec036b7 Refactor: libpacemaker: improve formatting for consistency
Author
kgaillot
Browse Repository
No Audits
76a564a27cef Doc: scheduler: correct doxygen blocks
Author
kgaillot
Browse Repository
No Audits
69925f1af4d3 Low: scheduler: compare strings case-sensitively where appropriate
Author
kgaillot
Browse Repository
No Audits
7551cc989b9d Low: scheduler: assert on invalid usage of assignment methods
Author
kgaillot
Browse Repository
No Audits
93badc689265 Refactor: libpacemaker: use space after control statements
Author
kgaillot
Browse Repository
No Audits
12b92c9dd3e2 Refactor: libpacemaker: break up long lines
Author
kgaillot
Browse Repository
No Audits
bc343eeeb11e Refactor: libpacemaker: improve capitalization in variable names
Author
kgaillot
Browse Repository
No Audits
6a6c4a42bb88 Refactor: libpacemaker: best practices for add_maintenance_nodes()
Author
kgaillot
Browse Repository
No Audits
ee48ec50f0ff Refactor: scheduler: make schedule_reload() match GFunc signature
Author
kgaillot
Browse Repository
No Audits
2a13f7ab6e20 Refactor: scheduler: make node criteria functions match GFunc signature
Author
kgaillot
Browse Repository
No Audits
bb64a6fd2fbf Refactor: scheduler: make set_assignment_methods_for_rsc() match GFunc signature
Author
kgaillot
Browse Repository
No Audits
28db254ec375 Refactor: scheduler: create GFunc wrapper for pcmk__update_action_for_orderings…
Author
kgaillot
Browse Repository
No Audits
b092f8276de9 Refactor: scheduler: create GFunc wrapper for action_flags() method
Author
kgaillot
Browse Repository
No Audits

Changes (31)

Path

Size

lib/

pacemaker/

libpacemaker_private.h

pcmk_acl.c

pcmk_cluster_queries.c

pcmk_fence.c

pcmk_graph_consumer.c

pcmk_graph_logging.c

pcmk_graph_producer.c

pcmk_sched_colocation.c

pcmk_sched_constraints.c

pcmk_sched_fencing.c

pcmk_sched_group.c

pcmk_sched_instances.c

pcmk_sched_location.c

pcmk_sched_migration.c

pcmk_sched_nodes.c

pcmk_sched_ordering.c

pcmk_sched_primitive.c

pcmk_sched_probes.c

pcmk_sched_recurring.c

pcmk_sched_remote.c

pcmk_sched_resource.c

rP40a261ccc332

View Options

lib/pacemaker/libpacemaker_private.h

View Options

lib/pacemaker/pcmk_acl.c

View Options

lib/pacemaker/pcmk_cluster_queries.c

View Options

lib/pacemaker/pcmk_fence.c

View Options

lib/pacemaker/pcmk_graph_consumer.c

View Options

lib/pacemaker/pcmk_graph_logging.c

View Options

lib/pacemaker/pcmk_graph_producer.c

View Options

lib/pacemaker/pcmk_injections.c

View Options

lib/pacemaker/pcmk_output.c

View Options

lib/pacemaker/pcmk_resource.c

View Options

lib/pacemaker/pcmk_sched_actions.c

View Options

lib/pacemaker/pcmk_sched_bundle.c

View Options

lib/pacemaker/pcmk_sched_clone.c

View Options

lib/pacemaker/pcmk_sched_colocation.c

View Options

lib/pacemaker/pcmk_sched_constraints.c

View Options

lib/pacemaker/pcmk_sched_fencing.c

View Options

lib/pacemaker/pcmk_sched_group.c

View Options

lib/pacemaker/pcmk_sched_instances.c

View Options

lib/pacemaker/pcmk_sched_location.c

View Options

lib/pacemaker/pcmk_sched_migration.c

View Options

lib/pacemaker/pcmk_sched_nodes.c

View Options

lib/pacemaker/pcmk_sched_ordering.c

View Options

lib/pacemaker/pcmk_sched_primitive.c

View Options

lib/pacemaker/pcmk_sched_probes.c

View Options

lib/pacemaker/pcmk_sched_recurring.c

View Options

lib/pacemaker/pcmk_sched_remote.c

View Options

lib/pacemaker/pcmk_sched_resource.c

View Options

lib/pacemaker/pcmk_sched_tickets.c

View Options

lib/pacemaker/pcmk_scheduler.c

View Options

lib/pacemaker/pcmk_simulate.c

View Options

lib/pacemaker/pcmk_status.c

Merge pull request #3134 from kgaillot/best-practices40a261ccc332Actions

Description

Details

Event Timeline

Merged Changes

Changes (31)

rP40a261ccc332

lib/pacemaker/libpacemaker_private.h

lib/pacemaker/pcmk_acl.c

lib/pacemaker/pcmk_cluster_queries.c

lib/pacemaker/pcmk_fence.c

lib/pacemaker/pcmk_graph_consumer.c

lib/pacemaker/pcmk_graph_logging.c

lib/pacemaker/pcmk_graph_producer.c

lib/pacemaker/pcmk_injections.c

lib/pacemaker/pcmk_output.c

lib/pacemaker/pcmk_resource.c

lib/pacemaker/pcmk_sched_actions.c

lib/pacemaker/pcmk_sched_bundle.c

lib/pacemaker/pcmk_sched_clone.c

lib/pacemaker/pcmk_sched_colocation.c

lib/pacemaker/pcmk_sched_constraints.c

lib/pacemaker/pcmk_sched_fencing.c

lib/pacemaker/pcmk_sched_group.c

lib/pacemaker/pcmk_sched_instances.c

lib/pacemaker/pcmk_sched_location.c

lib/pacemaker/pcmk_sched_migration.c

lib/pacemaker/pcmk_sched_nodes.c

lib/pacemaker/pcmk_sched_ordering.c

lib/pacemaker/pcmk_sched_primitive.c

lib/pacemaker/pcmk_sched_probes.c

lib/pacemaker/pcmk_sched_recurring.c

lib/pacemaker/pcmk_sched_remote.c

lib/pacemaker/pcmk_sched_resource.c

lib/pacemaker/pcmk_sched_tickets.c

lib/pacemaker/pcmk_scheduler.c

lib/pacemaker/pcmk_simulate.c

lib/pacemaker/pcmk_status.c

Merge pull request #3134 from kgaillot/best-practices
40a261ccc332
Actions