Merge pull request #2894 from kgaillot/best-practices
5206e8edd96e
Actions

Description

Merge pull request #2894 from kgaillot/best-practices

Best practices for remaining primitive-related functions in libpacemaker

Details

Provenance

kgaillot	Authored on Sep 29 2022, 4:15 PM
GitHub <noreply@github.com>	Committed on Sep 29 2022, 4:15 PM

Parents

rP350ac6723ead: Refactor: scheduler: functionize banning resource from non-locked node
rPa318b2146068: Merge pull request #2892 from kgaillot/best-practices

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP5206e8edd96e: Merge pull request #2894 from kgaillot/best-practices (authored by kgaillot).Sep 29 2022, 4:15 PM

Merged Changes

350ac6723ead Refactor: scheduler: functionize banning resource from non-locked node
Author
kgaillot
Browse Repository
No Audits
449d9af69aec Refactor: scheduler: functionize ordering resource start/stop vs unfencing
Author
kgaillot
Browse Repository
No Audits
55ba38abbc6e Refactor: scheduler: clarify pointer arguments to primitive-related functions
Author
kgaillot
Browse Repository
No Audits
7d06ae5a95e8 Refactor: scheduler: first two arguments to add_utilization() method can be…
Author
kgaillot
Browse Repository
No Audits
6ac6181dc365 Refactor: scheduler: rsc argument to pcmk__release_node_capacity() can be const
Author
kgaillot
Browse Repository
No Audits
82b4baa4e9b7 Refactor: libpe_status: argument to pe__rsc_bool_str() can be const
Author
kgaillot
Browse Repository
No Audits
5b4255fe03ed Refactor: scheduler: clarify pointer arguments to apply_coloc_score() method
Author
kgaillot
Browse Repository
No Audits
5eb42a9aa88d Refactor: scheduler: clarify promotable function arguments
Author
kgaillot
Browse Repository
No Audits
ad9725277c4b Refactor: scheduler: find_compatible_child() argument can be const
Author
kgaillot
Browse Repository
No Audits
79be8d1a704a Refactor: libpe_status: pe_node_attribute_raw() argument can be const
Author
kgaillot
Browse Repository
No Audits
0cc5c6104dae Refactor: scheduler: make bundle function arguments const where possible
Author
kgaillot
Browse Repository
No Audits
9e49df057e91 Refactor: scheduler: is_child_compatible() arguments can be const
Author
kgaillot
Browse Repository
No Audits
a0ef03869ef3 Refactor: libpe_status: is_set_recursive() argument can be const
Author
kgaillot
Browse Repository
No Audits
1317a5a86006 Refactor: scheduler: clarify colocation-related pointer arguments
Author
kgaillot
Browse Repository
No Audits
ba7044a76b2c Refactor: scheduler: clarify pointer arguments to assign() method
Author
kgaillot
Browse Repository
No Audits
a1a3f1ace2de Refactor: scheduler: make assign_best_node() take const node
Author
kgaillot
Browse Repository
No Audits

Changes (14)

Path

Size

include/

crm/

pengine/

internal.h

pcmki/

pcmki_sched_allocate.h

pcmki_sched_utils.h

lib/

pacemaker/

libpacemaker_private.h

pcmk_sched_bundle.c

pcmk_sched_clone.c

pcmk_sched_colocation.c

pcmk_sched_fencing.c

pcmk_sched_group.c

pcmk_sched_primitive.c

pcmk_sched_promotable.c

pcmk_sched_utilization.c

pengine/

clone.c

common.c

rP5206e8edd96e

View Options

include/crm/pengine/internal.h

View Options

include/pcmki/pcmki_sched_allocate.h

View Options

include/pcmki/pcmki_sched_utils.h

View Options

lib/pacemaker/libpacemaker_private.h

View Options

lib/pacemaker/pcmk_sched_bundle.c

View Options

lib/pacemaker/pcmk_sched_clone.c

View Options

lib/pacemaker/pcmk_sched_colocation.c

View Options

lib/pacemaker/pcmk_sched_fencing.c

View Options

lib/pacemaker/pcmk_sched_group.c

View Options

lib/pacemaker/pcmk_sched_primitive.c

View Options

lib/pacemaker/pcmk_sched_promotable.c

View Options

lib/pacemaker/pcmk_sched_utilization.c

View Options

lib/pengine/clone.c

View Options

Merge pull request #2894 from kgaillot/best-practices5206e8edd96eActions

Description

Details

Event Timeline

Merged Changes

Changes (14)

rP5206e8edd96e

include/crm/pengine/internal.h

include/pcmki/pcmki_sched_allocate.h

include/pcmki/pcmki_sched_utils.h

lib/pacemaker/libpacemaker_private.h

lib/pacemaker/pcmk_sched_bundle.c

lib/pacemaker/pcmk_sched_clone.c

lib/pacemaker/pcmk_sched_colocation.c

lib/pacemaker/pcmk_sched_fencing.c

lib/pacemaker/pcmk_sched_group.c

lib/pacemaker/pcmk_sched_primitive.c

lib/pacemaker/pcmk_sched_promotable.c

lib/pacemaker/pcmk_sched_utilization.c

lib/pengine/clone.c

lib/pengine/common.c

Merge pull request #2894 from kgaillot/best-practices
5206e8edd96e
Actions