Merge pull request #2944 from nrwahl2/nrwahl2-T239_pt1
5249d34ced83
Actions

Description

Merge pull request #2944 from nrwahl2/nrwahl2-T239_pt1

Refactor: controller: Make global variables easier to follow (part 1)

Details

Provenance

kgaillot	Authored on Nov 17 2022, 10:39 AM
GitHub <noreply@github.com>	Committed on Nov 17 2022, 10:39 AM

Parents

rPa2a97156ec12: Refactor: controller: Add set/clear macros for global flags
rP0724d38487b2: Merge pull request #2927 from waltdisgrace/t593

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP5249d34ced83: Merge pull request #2944 from nrwahl2/nrwahl2-T239_pt1 (authored by kgaillot).Nov 17 2022, 10:39 AM

Merged Changes

a2a97156ec12 Refactor: controller: Add set/clear macros for global flags
Author
nrwahl2
Browse Repository
No Audits
8bc196a41751 Refactor: controller: Don't compare booleans in controld_membership.c
Author
nrwahl2
Browse Repository
No Audits
a515ca47c212 Low: controller: Remove CRM_CHECK in update_dc for no current DC
Author
nrwahl2
Browse Repository
No Audits
1e0bf5105ded Refactor: controller: Make controld_matrix.h a C file
Author
nrwahl2
Browse Repository
No Audits
2f1bf27d9b9c Low: controller: Prioritize globals.dc_name peer_update_callback() log
Author
nrwahl2
Browse Repository
No Audits
0a26692c6aa1 Refactor: controller: Remove AM_I_OPERATIONAL macro
Author
nrwahl2
Browse Repository
No Audits
fb147510e88e Refactor: controller: Add fsa_actions to globals struct
Author
nrwahl2
Browse Repository
No Audits
9a4e334b9333 Refactor: controller: Add fsa_input_register to globals struct
Author
nrwahl2
Browse Repository
No Audits
d5778c022274 Refactor: controller: Add fsa_state to globals struct
Author
nrwahl2
Browse Repository
No Audits
ec9b6309adcb Refactor: controller: Add fsa_our_uuid to globals struct
Author
nrwahl2
Browse Repository
No Audits
f343375dba43 Refactor: controller: Add fsa_our_uname to globals struct
Author
nrwahl2
Browse Repository
No Audits
5e56adfd288c Refactor: controller: Add fsa_our_dc_version to globals struct
Author
nrwahl2
Browse Repository
No Audits
9cd0c6bd2ca8 Refactor: controller: Add fsa_our_dc to globals struct
Author
nrwahl2
Browse Repository
No Audits
e8cb07a60b4d Refactor: controller: Add fsa_cluster_name to globals struct
Author
nrwahl2
Browse Repository
No Audits
8ef881bf985d Refactor: controller: Static-ize controld_te_utils.c:transition_trigger
Author
nrwahl2
Browse Repository
No Audits
6d41f766c6bf Refactor: controller: Remove empty log_deprecation_warnings()
Author
nrwahl2
Browse Repository
No Audits
f823544c9246 Refactor: controller: Static-ize controld_controld.c:config_read trigger
Author
nrwahl2
Browse Repository
No Audits
ed7f07b7f934 Refactor: controller: Add crmd_mainloop to controld_globals struct
Author
nrwahl2
Browse Repository
No Audits
7e9f58f11941 Refactor: controller: Replace controld_shutdown_lock_enabled with flag
Author
nrwahl2
Browse Repository
No Audits
df8094caabb1 Refactor: controller: Replace no_quorum_suicide_escalation with flag
Author
nrwahl2
Browse Repository
No Audits
3754048021fe Refactor: controller: Replace fsa_has_quorum with flag
Author
nrwahl2
Browse Repository
No Audits
a960c09a6e5d Refactor: controller: Replace ever_had_quorum global with flag
Author
nrwahl2
Browse Repository
No Audits
bcbd4b45243b Refactor: controller: Replace do_fsa_stall with global flag
Author
nrwahl2
Browse Repository
No Audits
c3d972722327 Refactor: controller: Replace controld_dc_left with global flag
Author
nrwahl2
Browse Repository
No Audits
c597777c4c65 Doc: libcrmcommon: Add missing param doxygen to pcmk__cluster_option()
Author
nrwahl2
Browse Repository
No Audits
7808209cb8b7 Refactor: controller: Improve name of controld_stop_election_timer()
Author
nrwahl2
Browse Repository
No Audits
4c6a81ad19de Refactor: controller: Rename election_trigger to election_timer
Author
nrwahl2
Browse Repository
No Audits
433d4b07833f Refactor: controller: Make get_timer_desc() static
Author
nrwahl2
Browse Repository
No Audits
5330ee742a71 Refactor: controller: Static-ize controld_te_actions.c:te_targets
Author
nrwahl2
Browse Repository
No Audits
900185a1b991 Refactor: controller: Static-ize controld_execd_state.c:lrm_state_table
Author
nrwahl2
Browse Repository
No Audits
58f93f1eae41 Refactor: controller: Use pcmk__str_update() in controld_transition.c
Author
nrwahl2
Browse Repository
No Audits
2842ef6509e3 Refactor: controller: Make register_fsa_input_adv() return void
Author
nrwahl2
Browse Repository
No Audits
b4abedb29b48 Refactor: controller: Static-ize controld_messages.c:last_data_id
Author
nrwahl2
Browse Repository
No Audits
567ba66caff7 Refactor: controller: Static-ize controld-matrix.h global variables
Author
nrwahl2
Browse Repository
No Audits
3116393cd3eb Refactor: controller: Remove unused global shuttingdown
Author
nrwahl2
Browse Repository
No Audits
91af058c4e06 Refactor: controller: Static-ize fsa_pe_query global variable
Author
nrwahl2
Browse Repository
No Audits
57de48a3c96b Refactor: controller: Remove unused global last_peer_update
Author
nrwahl2
Browse Repository
No Audits
983172fe9034 Refactor: controller: Remove unused global membership_flux_hack
Author
nrwahl2
Browse Repository
No Audits
763a34944914 Refactor: controller: Remove unused extern for num_join_invites
Author
nrwahl2
Browse Repository
No Audits
f37e116e3136 Refactor: controller: Remove unused global reannounce_count
Author
nrwahl2
Browse Repository
No Audits
734e6916c0c4 Refactor: controller: Remove unused global highest_born_on
Author
nrwahl2
Browse Repository
No Audits
631729b48466 Refactor: controller: Remove unused externs from controld_controld.c
Author
nrwahl2
Browse Repository
No Audits
f5bf18ec4f42 Refactor: controller: Static-ize controld_join_dc.c:max_generation_*
Author
nrwahl2
Browse Repository
No Audits
6e2e5d816f16 Refactor: controller: Static-ize controld_controld.c:ipcs
Author
nrwahl2
Browse Repository
No Audits
89205923f5fd Refactor: controller: Static-ize controld_based.c:cib_retries global var
Author
nrwahl2
Browse Repository
No Audits

Changes (34)

Path

Size

daemons/

controld/

controld_execd_state.c

controld_fencing.c

controld_fsa.c

controld_fsa.h

controld_join_client.c

controld_join_dc.c

	controld_matrix.c
	controld_matrix.h

controld_matrix.h

controld_membership.c

controld_messages.c

controld_messages.h

controld_remote_ra.c

controld_schedulerd.c

controld_te_actions.c

controld_te_callbacks.c

controld_te_utils.c

controld_timers.c

controld_timers.h

controld_transition.c

controld_transition.h

lib/

common/

options.c

rP5249d34ced83

View Options

daemons/controld/Makefile.am

View Options

daemons/controld/controld_alerts.c

View Options

daemons/controld/controld_attrd.c

View Options

daemons/controld/controld_based.c

View Options

daemons/controld/controld_callbacks.c

View Options

daemons/controld/controld_control.c

View Options

daemons/controld/controld_corosync.c

View Options

daemons/controld/controld_election.c

View Options

daemons/controld/controld_execd.c

View Options

daemons/controld/controld_execd_state.c

View Options

daemons/controld/controld_fencing.c

View Options

daemons/controld/controld_fsa.c

View Options

daemons/controld/controld_fsa.h

View Options

daemons/controld/controld_join_client.c

View Options

daemons/controld/controld_join_dc.c

View Options

daemons/controld/controld_matrix.c

View Options

daemons/controld/controld_matrix.h

View Options

daemons/controld/controld_membership.c

View Options

daemons/controld/controld_messages.c

View Options

daemons/controld/controld_messages.h

View Options

daemons/controld/controld_remote_ra.c

View Options

daemons/controld/controld_schedulerd.c

View Options

daemons/controld/controld_te_actions.c

View Options

daemons/controld/controld_te_callbacks.c

View Options

daemons/controld/controld_te_utils.c

View Options

daemons/controld/controld_timers.c

View Options

daemons/controld/controld_timers.h

View Options

daemons/controld/controld_transition.c

View Options

daemons/controld/controld_transition.h

View Options

daemons/controld/controld_utils.c

View Options

daemons/controld/controld_utils.h

View Options

daemons/controld/pacemaker-controld.c

View Options

daemons/controld/pacemaker-controld.h

View Options

Merge pull request #2944 from nrwahl2/nrwahl2-T239_pt15249d34ced83Actions

Description

Details

Event Timeline

Merged Changes

Changes (34)

rP5249d34ced83

daemons/controld/Makefile.am

daemons/controld/controld_alerts.c

daemons/controld/controld_attrd.c

daemons/controld/controld_based.c

daemons/controld/controld_callbacks.c

daemons/controld/controld_control.c

daemons/controld/controld_corosync.c

daemons/controld/controld_election.c

daemons/controld/controld_execd.c

daemons/controld/controld_execd_state.c

daemons/controld/controld_fencing.c

daemons/controld/controld_fsa.c

daemons/controld/controld_fsa.h

daemons/controld/controld_join_client.c

daemons/controld/controld_join_dc.c

daemons/controld/controld_matrix.c

daemons/controld/controld_matrix.h

daemons/controld/controld_membership.c

daemons/controld/controld_messages.c

daemons/controld/controld_messages.h

daemons/controld/controld_remote_ra.c

daemons/controld/controld_schedulerd.c

daemons/controld/controld_te_actions.c

daemons/controld/controld_te_callbacks.c

daemons/controld/controld_te_utils.c

daemons/controld/controld_timers.c

daemons/controld/controld_timers.h

daemons/controld/controld_transition.c

daemons/controld/controld_transition.h

daemons/controld/controld_utils.c

daemons/controld/controld_utils.h

daemons/controld/pacemaker-controld.c

daemons/controld/pacemaker-controld.h

lib/common/options.c

Merge pull request #2944 from nrwahl2/nrwahl2-T239_pt1
5249d34ced83
Actions