Merge pull request #3120 from kgaillot/best-practices
582691772286
Actions

Description

Merge pull request #3120 from kgaillot/best-practices

Isolate bundle variant data to bundle.c

Details

Provenance

kgaillot	Authored on Jun 12 2023, 2:28 PM
GitHub <noreply@github.com>	Committed on Jun 12 2023, 2:28 PM

Parents

rP3c47b98284e9: Merge pull request #3122 from clumens/cts-tests-batch-2
rPbdacffdcde2e: Refactor: scheduler: make bundle argument to pe__foreach_bundle_replica() not…

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP582691772286: Merge pull request #3120 from kgaillot/best-practices (authored by kgaillot).Jun 12 2023, 2:28 PM

Merged Changes

bdacffdcde2e Refactor: scheduler: make bundle argument to pe__foreach_bundle_replica() not…
Author
kgaillot
Browse Repository
No Audits
fe556be14129 Refactor: scheduler: make primary argument to apply_coloc_score() not const
Author
kgaillot
Browse Repository
No Audits
d958d420447f Low: scheduler: fix regression introduced by d0e103782f1
Author
kgaillot
Browse Repository
No Audits
03fe3f28319c Refactor: scheduler: drop unnecessary casts to void *
Author
kgaillot
Browse Repository
No Audits
ea6adb16b296 Refactor: scheduler: improve some bundle internal colocation tags
Author
kgaillot
Browse Repository
No Audits
3050425a94ee Log: scheduler: improve a couple of bundle messages
Author
kgaillot
Browse Repository
No Audits
49c89820767c Doc: scheduler: improve doxygen blocks for some bundle functions
Author
kgaillot
Browse Repository
No Audits
835e61470ed2 Refactor: scheduler: isolate bundle variant data to lib/pengine/bundle.c
Author
kgaillot
Browse Repository
No Audits
b51a0889f98d Test: libpe_status: use bundle iterator in native_find_rsc_test.c
Author
kgaillot
Browse Repository
No Audits
17e9f22a2162 Refactor: scheduler: functionize getting bundle's first container
Author
kgaillot
Browse Repository
No Audits
1f51d6e28689 Refactor: scheduler: move pcmk__get_rsc_in_container() to libpe_status
Author
kgaillot
Browse Repository
No Audits
498796827a7f Refactor: scheduler: use replica iterator in pcmk__output_bundle_actions()
Author
kgaillot
Browse Repository
No Audits
da30d5042d54 Refactor: scheduler: use replica iterator in pcmk__bundle_create_probe()
Author
kgaillot
Browse Repository
No Audits
c66e38e49ff7 Refactor: scheduler: use replica iterator in pcmk__bundle_expand()
Author
kgaillot
Browse Repository
No Audits
90033a5bd56c Refactor: scheduler: use replica iterator in pcmk__bundle_rsc_location()
Author
kgaillot
Browse Repository
No Audits
2e693e9981fd Refactor: scheduler: use replica iterator in pcmk__bundle_apply_coloc_score()
Author
kgaillot
Browse Repository
No Audits
21d366d9f113 Refactor: scheduler: use replica iterator in compatible_replica_for_node()
Author
kgaillot
Browse Repository
No Audits
b0be9027c7d7 Refactor: scheduler: drop redundant arguments from compatible_replica()
Author
kgaillot
Browse Repository
No Audits
094835d92ba1 Refactor: scheduler: use replica iterator in pcmk__bundle_internal_constraints()
Author
kgaillot
Browse Repository
No Audits
7fdb0423263e Refactor: scheduler: use replica iterator in pcmk__bundle_create_actions()
Author
kgaillot
Browse Repository
No Audits
d0e103782f11 Refactor: scheduler: add iterator function for bundle replicas
Author
kgaillot
Browse Repository
No Audits
8b186f83411b Refactor: scheduler: expose pe__bundle_replica_t internally
Author
kgaillot
Browse Repository
No Audits
939ffda3a7fa Refactor: scheduler: add accessor for a bundle's inner resource
Author
kgaillot
Browse Repository
No Audits
b93fbddd1d94 Refactor: scheduler: use bundle convenience functions
Author
kgaillot
Browse Repository
No Audits
4eb43282aa43 Refactor: scheduler: move is_bundle_node() to libpe_status
Author
kgaillot
Browse Repository
No Audits

Changes (11)

Path

Size

include/

crm/

pengine/

internal.h

lib/

pacemaker/

libpacemaker_private.h

pcmk_sched_bundle.c

pcmk_sched_clone.c

pcmk_sched_group.c

pcmk_sched_instances.c

pcmk_sched_primitive.c

pengine/

Makefile.am

bundle.c

tests/

native/

native_find_rsc_test.c

variant.h

rP582691772286

View Options

include/crm/pengine/internal.h

View Options

lib/pacemaker/libpacemaker_private.h

View Options

lib/pacemaker/pcmk_sched_bundle.c

View Options

lib/pacemaker/pcmk_sched_clone.c

View Options

lib/pacemaker/pcmk_sched_group.c

View Options

lib/pacemaker/pcmk_sched_instances.c

View Options

lib/pacemaker/pcmk_sched_primitive.c

View Options

lib/pengine/Makefile.am

View Options

lib/pengine/bundle.c

View Options

lib/pengine/tests/native/native_find_rsc_test.c

View Options

Merge pull request #3120 from kgaillot/best-practices582691772286Actions

Description

Details

Event Timeline

Merged Changes

Changes (11)

rP582691772286

include/crm/pengine/internal.h

lib/pacemaker/libpacemaker_private.h

lib/pacemaker/pcmk_sched_bundle.c

lib/pacemaker/pcmk_sched_clone.c

lib/pacemaker/pcmk_sched_group.c

lib/pacemaker/pcmk_sched_instances.c

lib/pacemaker/pcmk_sched_primitive.c

lib/pengine/Makefile.am

lib/pengine/bundle.c

lib/pengine/tests/native/native_find_rsc_test.c

lib/pengine/variant.h

Merge pull request #3120 from kgaillot/best-practices
582691772286
Actions