Merge pull request #3292 from kgaillot/best-practices
72309c77fdfa
Actions

Description

Merge pull request #3292 from kgaillot/best-practices

Improve scheduler logging and move related APIs to libcrmcommon

Details

Provenance

kgaillot	Authored on Dec 18 2023, 6:01 PM
GitHub <noreply@github.com>	Committed on Dec 18 2023, 6:01 PM

Parents

rP99bd528c83d4: Merge pull request #3293 from kgaillot/T137
rP4d0685e2b789: Low: scheduler: restore nvpair behavior without id-ref

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP72309c77fdfa: Merge pull request #3292 from kgaillot/best-practices (authored by kgaillot).Dec 18 2023, 6:01 PM

Merged Changes

4d0685e2b789 Low: scheduler: restore nvpair behavior without id-ref
Author
kgaillot
Browse Repository
No Audits
8894f6a17af3 Refactor: scheduler: scope variable more tightly
Author
kgaillot
Browse Repository
No Audits
abdb1e6c9c4d Fix: scheduler: use correct variable in log message
Author
kgaillot
Browse Repository
No Audits
5020a914a2dc Low: scheduler: reject expression without op sooner
Author
kgaillot
Browse Repository
No Audits
a957432ce1df Log: scheduler: improve messages (and comments) per review
Author
kgaillot
Browse Repository
No Audits
723fedaca1ca Test: cts-cli: ignore cluster_status() file and line number
Author
kgaillot
Browse Repository
No Audits
cd7fa51d2536 Refactor: scheduler: move pe_warn_once() to libcrmcommon
Author
kgaillot
Browse Repository
No Audits
c5715a0aaa8c Low: libcrmcommon: fix NULL dereference in expand_idref()
Author
kgaillot
Browse Repository
No Audits
a183dff646d4 Log: scheduler: improve logs for invalid id-ref's
Author
kgaillot
Browse Repository
No Audits
d822942ba814 Log: scheduler: overhaul usage of scheduler logging functions
Author
kgaillot
Browse Repository
No Audits
1d9a91fcfacf Log: scheduler: improve logging of invalid roles
Author
kgaillot
Browse Repository
No Audits
2ca514ab8192 Log: scheduler: improve messages when unpacking location constraints
Author
kgaillot
Browse Repository
No Audits
1a6c67828eb2 Refactor: scheduler: functionize parsing role in location constraints
Author
kgaillot
Browse Repository
No Audits
4967551ddfd6 Refactor: scheduler: drop pe_err() and pe_warn()
Author
kgaillot
Browse Repository
No Audits
9e28f3b6def4 Log: scheduler: treat config errors as processing errors
Author
kgaillot
Browse Repository
No Audits
eb605b61522c Refactor: libpe_status,libcrmcommon: move pe_proc_warn() to libcrmcommon
Author
kgaillot
Browse Repository
No Audits
895db8eedb38 Refactor: libpe_status,libcrmcommon: move pe_proc_err() to libcrmcommon
Author
kgaillot
Browse Repository
No Audits
d62ea0378df1 Refactor: libpe_status,libcrmcommon: move pe_rsc_trace() to libcrmcommon
Author
kgaillot
Browse Repository
No Audits
77576cc2e005 Refactor: libpe_status,libcrmcommon: move pe_rsc_debug() to libcrmcommon
Author
kgaillot
Browse Repository
No Audits
1ae18f967220 Refactor: libpe_status,libcrmcommon: move pe_rsc_info() to libcrmcommon
Author
kgaillot
Browse Repository
No Audits
e6e2214d36f7 API: libcrmcommon: deprecate was_processing_warning
Author
kgaillot
Browse Repository
No Audits
40138a119d0b API: libpe_status,libpe_rules,libcrmcommon: move was_processing_warning to…
Author
kgaillot
Browse Repository
No Audits
6072f536a5f1 API: libcrmcommon: deprecate was_processing_error
Author
kgaillot
Browse Repository
No Audits
afe932e3d4a6 API: libpe_status,libpe_rules,libcrmcommon: move was_processing_error to…
Author
kgaillot
Browse Repository
No Audits

Changes (48)

Path

Size

cts/

cli/

regression.tools.exp

cts-cli.in

daemons/

schedulerd/

schedulerd_messages.c

include/

crm/

common/

pengine/

lib/

common/

scheduler.c

xml.c

pacemaker/

pcmk_graph_producer.c

pcmk_sched_colocation.c

pcmk_sched_constraints.c

pcmk_sched_fencing.c

pcmk_sched_group.c

pcmk_sched_instances.c

pcmk_sched_location.c

pcmk_sched_migration.c

pcmk_sched_nodes.c

pcmk_sched_ordering.c

pcmk_sched_primitive.c

pcmk_sched_probes.c

pcmk_sched_promotable.c

pcmk_sched_recurring.c

pcmk_sched_resource.c

pcmk_sched_tickets.c

pcmk_sched_utilization.c

pengine/

tools/

crm_resource_runtime.c

rP72309c77fdfa

View Options

cts/cli/regression.tools.exp

View Options

cts/cts-cli.in

View Options

daemons/schedulerd/schedulerd_messages.c

View Options

include/crm/common/logging_internal.h

View Options

include/crm/common/scheduler.h

View Options

include/crm/common/scheduler_internal.h

View Options

include/crm/pengine/common.h

View Options

include/crm/pengine/internal.h

View Options

lib/common/scheduler.c

View Options

lib/common/xml.c

View Options

lib/pacemaker/pcmk_graph_producer.c

View Options

lib/pacemaker/pcmk_output.c

View Options

lib/pacemaker/pcmk_sched_actions.c

View Options

lib/pacemaker/pcmk_sched_bundle.c

View Options

lib/pacemaker/pcmk_sched_clone.c

View Options

lib/pacemaker/pcmk_sched_colocation.c

View Options

lib/pacemaker/pcmk_sched_constraints.c

View Options

lib/pacemaker/pcmk_sched_fencing.c

View Options

lib/pacemaker/pcmk_sched_group.c

View Options

lib/pacemaker/pcmk_sched_instances.c

View Options

lib/pacemaker/pcmk_sched_location.c

View Options

lib/pacemaker/pcmk_sched_migration.c

View Options

lib/pacemaker/pcmk_sched_nodes.c

View Options

lib/pacemaker/pcmk_sched_ordering.c

View Options

lib/pacemaker/pcmk_sched_primitive.c

View Options

lib/pacemaker/pcmk_sched_probes.c

View Options

lib/pacemaker/pcmk_sched_promotable.c

View Options

lib/pacemaker/pcmk_sched_recurring.c

View Options

lib/pacemaker/pcmk_sched_resource.c

View Options

lib/pacemaker/pcmk_sched_tickets.c

View Options

lib/pacemaker/pcmk_sched_utilization.c

View Options

lib/pacemaker/pcmk_scheduler.c

View Options

lib/pengine/bundle.c

View Options

lib/pengine/clone.c

View Options

lib/pengine/common.c

View Options

lib/pengine/complex.c

View Options

lib/pengine/failcounts.c

View Options

lib/pengine/group.c

View Options

lib/pengine/native.c

View Options

lib/pengine/pe_actions.c

View Options

lib/pengine/pe_digest.c

View Options

lib/pengine/pe_notif.c

View Options

lib/pengine/rules.c

View Options

lib/pengine/rules_alerts.c

View Options

lib/pengine/status.c

View Options

lib/pengine/unpack.c

View Options

lib/pengine/utils.c

View Options

tools/crm_resource_runtime.c

Merge pull request #3292 from kgaillot/best-practices72309c77fdfaActions

Description

Details

Event Timeline

Merged Changes

Changes (48)

rP72309c77fdfa

cts/cli/regression.tools.exp

cts/cts-cli.in

daemons/schedulerd/schedulerd_messages.c

include/crm/common/logging_internal.h

include/crm/common/scheduler.h

include/crm/common/scheduler_internal.h

include/crm/pengine/common.h

include/crm/pengine/internal.h

lib/common/scheduler.c

lib/common/xml.c

lib/pacemaker/pcmk_graph_producer.c

lib/pacemaker/pcmk_output.c

lib/pacemaker/pcmk_sched_actions.c

lib/pacemaker/pcmk_sched_bundle.c

lib/pacemaker/pcmk_sched_clone.c

lib/pacemaker/pcmk_sched_colocation.c

lib/pacemaker/pcmk_sched_constraints.c

lib/pacemaker/pcmk_sched_fencing.c

lib/pacemaker/pcmk_sched_group.c

lib/pacemaker/pcmk_sched_instances.c

lib/pacemaker/pcmk_sched_location.c

lib/pacemaker/pcmk_sched_migration.c

lib/pacemaker/pcmk_sched_nodes.c

lib/pacemaker/pcmk_sched_ordering.c

lib/pacemaker/pcmk_sched_primitive.c

lib/pacemaker/pcmk_sched_probes.c

lib/pacemaker/pcmk_sched_promotable.c

lib/pacemaker/pcmk_sched_recurring.c

lib/pacemaker/pcmk_sched_resource.c

lib/pacemaker/pcmk_sched_tickets.c

lib/pacemaker/pcmk_sched_utilization.c

lib/pacemaker/pcmk_scheduler.c

lib/pengine/bundle.c

lib/pengine/clone.c

lib/pengine/common.c

lib/pengine/complex.c

lib/pengine/failcounts.c

lib/pengine/group.c

lib/pengine/native.c

lib/pengine/pe_actions.c

lib/pengine/pe_digest.c

lib/pengine/pe_notif.c

lib/pengine/rules.c

lib/pengine/rules_alerts.c

lib/pengine/status.c

lib/pengine/unpack.c

lib/pengine/utils.c

tools/crm_resource_runtime.c

Merge pull request #3292 from kgaillot/best-practices
72309c77fdfa
Actions