HomeClusterLabs Projects
Diffusion Pacemaker 789e025b6fff

Merge pull request #2897 from kgaillot/best-practices
789e025b6fff
Actions

Description

Merge pull request #2897 from kgaillot/best-practices

Best practices for group methods in libpacemaker

Details

Provenance
kgaillotAuthored on Oct 4 2022, 2:55 PM
GitHub <noreply@github.com>Committed on Oct 4 2022, 2:55 PM
Parents
rP9db2c2e73056: Refactor: scheduler: drop redundant group orderings
rP708e532ba4e3: Merge pull request #2896 from kgaillot/best-practices
Branches
Unknown
Tags
Unknown

Merged Changes

Changes (225)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.
PathSize
cts/
cli/
scheduler/
scores/
ignore_stonith_rsc_order3.scores
honor_stonith_rsc_order1.scores
include/
crm/
pengine/
pcmki/
lib/
pacemaker/

rP789e025b6fff

View Options

cts/cli/regression.tools.exp

View Options

cts/scheduler/scores/1360.scores

View Options

cts/scheduler/scores/6-migrate-group.scores

View Options

cts/scheduler/scores/7-migrate-group-one-unmigratable.scores

View Options

cts/scheduler/scores/994-2.scores

View Options

cts/scheduler/scores/994.scores

View Options

cts/scheduler/scores/anon-instance-pending.scores

View Options

cts/scheduler/scores/anti-colocation-order.scores

View Options

cts/scheduler/scores/bnc-515172.scores

View Options

cts/scheduler/scores/bug-1572-1.scores

View Options

cts/scheduler/scores/bug-1572-2.scores

View Options

cts/scheduler/scores/bug-1573.scores

View Options

cts/scheduler/scores/bug-1718.scores

View Options

cts/scheduler/scores/bug-1820-1.scores

View Options

cts/scheduler/scores/bug-1820.scores

View Options

cts/scheduler/scores/bug-1822.scores

View Options

cts/scheduler/scores/bug-5014-GROUP-A-start-B-start.scores

View Options

cts/scheduler/scores/bug-5014-GROUP-A-stopped-B-started.scores

View Options

cts/scheduler/scores/bug-5014-GROUP-A-stopped-B-stopped.scores

View Options

cts/scheduler/scores/bug-5028-bottom.scores

View Options

cts/scheduler/scores/bug-5028-detach.scores

View Options

cts/scheduler/scores/bug-5028.scores

View Options

cts/scheduler/scores/bug-5038.scores

View Options

cts/scheduler/scores/bug-5059.scores

View Options

cts/scheduler/scores/bug-5140-require-all-false.scores

View Options

cts/scheduler/scores/bug-5143-ms-shuffle.scores

View Options

cts/scheduler/scores/bug-5186-partial-migrate.scores

View Options

cts/scheduler/scores/bug-cl-5168.scores

View Options

cts/scheduler/scores/bug-cl-5170.scores

View Options

cts/scheduler/scores/bug-cl-5212.scores

View Options

cts/scheduler/scores/bug-cl-5247.scores

View Options

cts/scheduler/scores/bug-lf-1852.scores

View Options

cts/scheduler/scores/bug-lf-2106.scores

View Options

cts/scheduler/scores/bug-lf-2153.scores

View Options

cts/scheduler/scores/bug-lf-2171.scores

View Options

cts/scheduler/scores/bug-lf-2213.scores

View Options

cts/scheduler/scores/bug-lf-2358.scores

View Options

cts/scheduler/scores/bug-lf-2422.scores

View Options

cts/scheduler/scores/bug-lf-2508.scores

View Options

cts/scheduler/scores/bug-lf-2551.scores

View Options

cts/scheduler/scores/bug-lf-2581.scores

View Options

cts/scheduler/scores/bug-lf-2613.scores

View Options

cts/scheduler/scores/bug-lf-2619.scores

View Options

cts/scheduler/scores/bug-n-385265-2.scores

View Options

cts/scheduler/scores/bug-n-385265.scores

View Options

cts/scheduler/scores/bug-n-387749.scores

View Options

cts/scheduler/scores/bug-pm-11.scores

View Options

cts/scheduler/scores/bug-pm-12.scores

View Options

cts/scheduler/scores/bug-rh-1097457.scores

View Options

cts/scheduler/scores/bug-suse-707150.scores

View Options

cts/scheduler/scores/clone-anon-dup.scores

View Options

cts/scheduler/scores/clone-anon-failcount.scores

View Options

cts/scheduler/scores/clone-fail-block-colocation.scores

View Options

cts/scheduler/scores/cloned-group-stop.scores

View Options

cts/scheduler/scores/cloned-group.scores

View Options

cts/scheduler/scores/coloc-attr.scores

View Options

cts/scheduler/scores/coloc-clone-stays-active.scores

View Options

cts/scheduler/scores/coloc-dependee-should-move.scores

View Options

cts/scheduler/scores/coloc-dependee-should-stay.scores

View Options

cts/scheduler/scores/coloc-group.scores

View Options

cts/scheduler/scores/coloc-negative-group.scores

View Options

cts/scheduler/scores/coloc-unpromoted-anti.scores

View Options

cts/scheduler/scores/colocate-primitive-with-clone.scores

View Options

cts/scheduler/scores/colocate-unmanaged-group.scores

View Options

cts/scheduler/scores/colocated-utilization-clone.scores

View Options

cts/scheduler/scores/colocated-utilization-group.scores

View Options

cts/scheduler/scores/colocation-influence.scores

View Options

cts/scheduler/scores/container-group-1.scores

View Options

cts/scheduler/scores/container-group-2.scores

View Options

cts/scheduler/scores/container-group-3.scores

View Options

cts/scheduler/scores/container-group-4.scores

View Options

cts/scheduler/scores/container-is-remote-node.scores

View Options

cts/scheduler/scores/date-2.scores

View Options

cts/scheduler/scores/date-3.scores

View Options

cts/scheduler/scores/dc-fence-ordering.scores

View Options

cts/scheduler/scores/failcount.scores

View Options

cts/scheduler/scores/force-anon-clone-max.scores

View Options

cts/scheduler/scores/group-dependents.scores

View Options

cts/scheduler/scores/group-fail.scores

View Options

cts/scheduler/scores/group-stop-ordering.scores

View Options

cts/scheduler/scores/group-unmanaged-stopped.scores

View Options

cts/scheduler/scores/group-unmanaged.scores

View Options

cts/scheduler/scores/group1.scores

View Options

cts/scheduler/scores/group10.scores

View Options

cts/scheduler/scores/group11.scores

View Options

cts/scheduler/scores/group13.scores

View Options

cts/scheduler/scores/group14.scores

View Options

cts/scheduler/scores/group15.scores

View Options

cts/scheduler/scores/group2.scores

View Options

cts/scheduler/scores/group3.scores

View Options

cts/scheduler/scores/group4.scores

View Options

cts/scheduler/scores/group5.scores

View Options

cts/scheduler/scores/group6.scores

View Options

cts/scheduler/scores/group7.scores

View Options

cts/scheduler/scores/group8.scores

View Options

cts/scheduler/scores/group9.scores

View Options

cts/scheduler/scores/history-1.scores

View Options

cts/scheduler/scores/honor_stonith_rsc_order1.scores

View Options

cts/scheduler/scores/honor_stonith_rsc_order2.scores

View Options

cts/scheduler/scores/honor_stonith_rsc_order3.scores

View Options

cts/scheduler/scores/ignore_stonith_rsc_order2.scores

View Options

cts/scheduler/scores/ignore_stonith_rsc_order3.scores

View Options

cts/scheduler/scores/ignore_stonith_rsc_order4.scores

View Options

cts/scheduler/scores/inc12.scores

View Options

cts/scheduler/scores/migrate-5.scores

View Options

cts/scheduler/scores/migrate-fencing.scores

View Options

cts/scheduler/scores/migrate-partial-4.scores

View Options

cts/scheduler/scores/migrate-shutdown.scores

View Options

cts/scheduler/scores/migrate-start-complex.scores

View Options

cts/scheduler/scores/migrate-start.scores

View Options

cts/scheduler/scores/migrate-stop-complex.scores

View Options

cts/scheduler/scores/migrate-stop-start-complex.scores

View Options

cts/scheduler/scores/migrate-stop.scores

View Options

cts/scheduler/scores/migrate-stop_start.scores

View Options

cts/scheduler/scores/monitor-recovery.scores

View Options

cts/scheduler/scores/multiple-active-block-group.scores

View Options

cts/scheduler/scores/not-reschedule-unneeded-monitor.scores

View Options

cts/scheduler/scores/order-first-probes.scores

View Options

cts/scheduler/scores/ordered-set-natural.scores

View Options

cts/scheduler/scores/probe-2.scores

View Options

cts/scheduler/scores/probe-3.scores

View Options

cts/scheduler/scores/probe-4.scores

View Options

cts/scheduler/scores/probe-pending-node.scores

View Options

cts/scheduler/scores/promoted-13.scores

View Options

cts/scheduler/scores/promoted-4.scores

View Options

cts/scheduler/scores/promoted-5.scores

View Options

cts/scheduler/scores/promoted-6.scores

View Options

cts/scheduler/scores/promoted-7.scores

View Options

cts/scheduler/scores/promoted-8.scores

View Options

cts/scheduler/scores/promoted-9.scores

View Options

cts/scheduler/scores/promoted-colocation.scores

View Options

cts/scheduler/scores/promoted-demote-2.scores

View Options

cts/scheduler/scores/promoted-failed-demote-2.scores

View Options

cts/scheduler/scores/promoted-failed-demote.scores

View Options

cts/scheduler/scores/promoted-group.scores

View Options

cts/scheduler/scores/promoted-move.scores

View Options

cts/scheduler/scores/promoted-ordering.scores

View Options

cts/scheduler/scores/promoted-partially-demoted-group.scores

View Options

cts/scheduler/scores/promoted-probed-score.scores

View Options

cts/scheduler/scores/promoted-promotion-constraint.scores

View Options

cts/scheduler/scores/promoted-pseudo.scores

View Options

cts/scheduler/scores/promoted-reattach.scores

View Options

cts/scheduler/scores/promoted-unmanaged-monitor.scores

View Options

cts/scheduler/scores/quorum-5.scores

View Options

cts/scheduler/scores/rec-node-11.scores

View Options

cts/scheduler/scores/rec-node-13.scores

View Options

cts/scheduler/scores/rec-node-15.scores

View Options

cts/scheduler/scores/rec-node-2.scores

View Options

cts/scheduler/scores/rec-rsc-9.scores

View Options

cts/scheduler/scores/remote-orphaned.scores

View Options

cts/scheduler/scores/remote-reconnect-delay.scores

View Options

cts/scheduler/scores/remote-stale-node-entry.scores

View Options

cts/scheduler/scores/resource-discovery.scores

View Options

cts/scheduler/scores/rsc-maintenance.scores

View Options

cts/scheduler/scores/rsc-sets-clone-1.scores

View Options

cts/scheduler/scores/simple8.scores

View Options

cts/scheduler/scores/standby.scores

View Options

cts/scheduler/scores/stonith-0.scores

View Options

cts/scheduler/scores/stonith-1.scores

View Options

cts/scheduler/scores/stonith-2.scores

View Options

cts/scheduler/scores/stonith-3.scores

View Options

cts/scheduler/scores/stop-all-resources.scores

View Options

cts/scheduler/scores/stop-unexpected.scores

View Options

cts/scheduler/scores/template-clone-group.scores

View Options

cts/scheduler/scores/ticket-group-1.scores

View Options

cts/scheduler/scores/ticket-group-10.scores

View Options

cts/scheduler/scores/ticket-group-11.scores

View Options

cts/scheduler/scores/ticket-group-12.scores

View Options

cts/scheduler/scores/ticket-group-13.scores

View Options

cts/scheduler/scores/ticket-group-14.scores

View Options

cts/scheduler/scores/ticket-group-15.scores

View Options

cts/scheduler/scores/ticket-group-16.scores

View Options

cts/scheduler/scores/ticket-group-17.scores

View Options

cts/scheduler/scores/ticket-group-18.scores

View Options

cts/scheduler/scores/ticket-group-19.scores

View Options

cts/scheduler/scores/ticket-group-2.scores

View Options

cts/scheduler/scores/ticket-group-20.scores

View Options

cts/scheduler/scores/ticket-group-21.scores

View Options

cts/scheduler/scores/ticket-group-22.scores

View Options

cts/scheduler/scores/ticket-group-23.scores

View Options

cts/scheduler/scores/ticket-group-24.scores

View Options

cts/scheduler/scores/ticket-group-3.scores

View Options

cts/scheduler/scores/ticket-group-4.scores

View Options

cts/scheduler/scores/ticket-group-5.scores

View Options

cts/scheduler/scores/ticket-group-6.scores

View Options

cts/scheduler/scores/ticket-group-7.scores

View Options

cts/scheduler/scores/ticket-group-8.scores

View Options

cts/scheduler/scores/ticket-group-9.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-1.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-10.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-11.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-12.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-13.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-14.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-2.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-3.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-4.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-5.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-6.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-7.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-8.scores

View Options

cts/scheduler/scores/ticket-rsc-sets-9.scores

View Options

cts/scheduler/scores/unmanaged-block-restart.scores

View Options

cts/scheduler/scores/unmanaged-promoted.scores

View Options

cts/scheduler/scores/unmanaged-stop-3.scores

View Options

cts/scheduler/scores/unmanaged-stop-4.scores

View Options

cts/scheduler/scores/unrunnable-1.scores

View Options

cts/scheduler/scores/use-after-free-merge.scores

View Options

cts/scheduler/scores/utilization-complex.scores

View Options

cts/scheduler/scores/utilization-order4.scores

View Options

cts/scheduler/scores/utilization-shuffle.scores

View Options

cts/scheduler/scores/whitebox-asymmetric.scores

View Options

cts/scheduler/scores/whitebox-ms-ordering-move.scores

View Options

cts/scheduler/scores/whitebox-nested-group.scores

View Options

cts/scheduler/scores/whitebox-orphan-ms.scores

View Options

include/crm/pengine/internal.h

View Options

include/pcmki/pcmki_sched_allocate.h

View Options

lib/pacemaker/libpacemaker_private.h

View Options

lib/pacemaker/pcmk_sched_group.c

View Options

lib/pacemaker/pcmk_sched_migration.c

View Options

lib/pacemaker/pcmk_sched_ordering.c

View Options

lib/pacemaker/pcmk_sched_primitive.c

View Options

lib/pacemaker/pcmk_sched_probes.c

View Options

lib/pacemaker/pcmk_sched_remote.c

View Options

lib/pacemaker/pcmk_sched_resource.c