Merge pull request #3395 from nrwahl2/nrwahl2-xml_escape
86787fccdd8b
Actions

Description

Merge pull request #3395 from nrwahl2/nrwahl2-xml_escape

Fix: libcrmcommon: Escape newlines and tabs in XML attribute values

Details

Provenance

kgaillot	Authored on Mar 28 2024, 6:59 PM
GitHub <noreply@github.com>	Committed on Mar 28 2024, 6:59 PM

Parents

rP6acac7f2b21d: Merge pull request #3401 from kgaillot/best-practices
rPb5d323e57f5a: Doc: Pacemaker Explained: Document whitespace in attribute values

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP86787fccdd8b: Merge pull request #3395 from nrwahl2/nrwahl2-xml_escape (authored by kgaillot).Mar 28 2024, 6:59 PM

Merged Changes

b5d323e57f5a Doc: Pacemaker Explained: Document whitespace in attribute values
Author
nrwahl2
Browse Repository
No Audits
13b467bbccb4 Refactor: libcrmcommon: New PCMK__XML_ENTITY string constants
Author
nrwahl2
Browse Repository
No Audits
0fdd73fbbf5f Fix: libcrmcommon: Escape some chars in XML attribute text output
Author
nrwahl2
Browse Repository
No Audits
9434efe7db8b Test: libcrmcommon: Add unit tests for pcmk__xml_escape_attr_pretty
Author
nrwahl2
Browse Repository
No Audits
6ee3a0ad1684 Refactor: libcrmcommon: New helper in pcmk__xml_escape test
Author
nrwahl2
Browse Repository
No Audits
24720364afe5 Refactor: libcrmcommon: New pcmk__xml_escape_attr_pretty enum value
Author
nrwahl2
Browse Repository
No Audits
bf22fe296ce8 Refactor: libcrmcommon: New enum pcmk__xml_escape_type
Author
nrwahl2
Browse Repository
No Audits
7b572b9fe7fe Refactor: libcrmcommon: Drop replace_text() from pcmk__xml_escape()
Author
nrwahl2
Browse Repository
No Audits
acfbd5e01a86 Refactor: libstonithd: Avoid unnecessary allocs in stonith__lha_metadata
Author
nrwahl2
Browse Repository
No Audits
99be2e027f96 Refactor: libcrmcommon: Avoid strlen() in pcmk__xml_needs_escape()
Author
nrwahl2
Browse Repository
No Audits
d6daa67bfb49 Refactor: libcrmcommon: Sanity-check utf8_bytes() result
Author
nrwahl2
Browse Repository
No Audits
a791b0f295c7 Fix: libcrmcommon: Escape newlines and tabs in XML attribute values
Author
nrwahl2
Browse Repository
No Audits
781d971396cd Refactor: libcrmcommon: Capital letters in hex XML character references
Author
nrwahl2
Browse Repository
No Audits
4f9b75383b40 Refactor: libcrmcommon: Don't escape when creating XML
Author
nrwahl2
Browse Repository
No Audits

Changes (15)

Path

Size

doc/

sphinx/

Pacemaker_Explained/

nodes.rst

include/

crm/

common/

xml_internal.h

lib/

common/

crmcommon_private.h

tests/

xml/

pcmk__xml_escape_test.c

pcmk__xml_needs_escape_test.c

fencing/

pacemaker/

pengine/

services/

tools/

rP86787fccdd8b

View Options

doc/sphinx/Pacemaker_Explained/nodes.rst

View Options

include/crm/common/xml_internal.h

View Options

lib/common/crmcommon_private.h

View Options

lib/common/tests/xml/pcmk__xml_escape_test.c

View Options

lib/common/tests/xml/pcmk__xml_needs_escape_test.c

View Options

lib/common/xml.c

View Options

lib/common/xml_attr.c

View Options

lib/common/xml_display.c

View Options

lib/common/xml_io.c

View Options

lib/fencing/st_lha.c

View Options

lib/pacemaker/pcmk_output.c

View Options

lib/pengine/pe_output.c

View Options

lib/services/services_lsb.c

View Options

lib/services/systemd.c

View Options

Merge pull request #3395 from nrwahl2/nrwahl2-xml_escape86787fccdd8bActions

Description

Details

Event Timeline

Merged Changes

Changes (15)

rP86787fccdd8b

doc/sphinx/Pacemaker_Explained/nodes.rst

include/crm/common/xml_internal.h

lib/common/crmcommon_private.h

lib/common/tests/xml/pcmk__xml_escape_test.c

lib/common/tests/xml/pcmk__xml_needs_escape_test.c

lib/common/xml.c

lib/common/xml_attr.c

lib/common/xml_display.c

lib/common/xml_io.c

lib/fencing/st_lha.c

lib/pacemaker/pcmk_output.c

lib/pengine/pe_output.c

lib/services/services_lsb.c

lib/services/systemd.c

tools/crm_attribute.c

Merge pull request #3395 from nrwahl2/nrwahl2-xml_escape
86787fccdd8b
Actions