Merge pull request #3371 from kgaillot/best-practices
8785c8efe180
Actions

Description

Merge pull request #3371 from kgaillot/best-practices

Move date expression evaluation to libcrmcommon

Details

Provenance

kgaillot	Authored on Feb 26 2024, 5:52 PM
GitHub <noreply@github.com>	Committed on Feb 26 2024, 5:52 PM

Parents

rP477b7bdd19b7: Merge pull request #3365 from clumens/hide-simple-xml
rP887aca7f19c5: Log: tools: trace-log XML datetime errors

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP8785c8efe180: Merge pull request #3371 from kgaillot/best-practices (authored by kgaillot).Feb 26 2024, 5:52 PM

Merged Changes

887aca7f19c5 Log: tools: trace-log XML datetime errors
Author
kgaillot
Browse Repository
No Audits
91418fa0c0b8 Test: libcrmcommon: add unit tests for pcmk__evaluate_date_expression()
Author
kgaillot
Browse Repository
No Audits
01bb75e139d2 Doc: Pacemaker Explained: improve documentation of date_expression options
Author
kgaillot
Browse Repository
No Audits
ec469edb410e Refactor: libcrmcommon: best practices for pe__eval_date_expr()
Author
kgaillot
Browse Repository
No Audits
7d66fee105aa Refactor: libcrmcommon: functionize checking less than date/time
Author
kgaillot
Browse Repository
No Audits
237f30a2eebe Refactor: libcrmcommon: functionize checking greater than date/time
Author
kgaillot
Browse Repository
No Audits
913f5bba3730 Refactor: libcrmcommon: functionize checking date/time in range
Author
kgaillot
Browse Repository
No Audits
b2aaecfc0653 API: libcrmcommon: add PCMK_VALUE_IN_RANGE string constant
Author
kgaillot
Browse Repository
No Audits
6562654d3dbe Refactor: libcrmcommon: make some functions library-private
Author
kgaillot
Browse Repository
No Audits
8785983fe0ea Refactor: libpe_rules,libcrmcommon: move pe__eval_date_expr()
Author
kgaillot
Browse Repository
No Audits

Changes (18)

Path

Size

doc/

sphinx/

Pacemaker_Explained/

local-options.rst

rules.rst

include/

crm/

common/

pengine/

lib/

common/

crmcommon_private.h

iso8601.c

rules.c

tests/

iso8601/

pcmk__add_time_from_xml_test.c

pcmk__set_time_if_earlier_test.c

rules/

Makefile.am

pcmk__evaluate_date_expression_test.c

pcmk__evaluate_date_spec_test.c

pcmk__unpack_duration_test.c

pacemaker/

pcmk_rule.c

pengine/

rules.c

tools/

crm_resource_ban.c

rP8785c8efe180

View Options

doc/sphinx/Pacemaker_Explained/local-options.rst

View Options

doc/sphinx/Pacemaker_Explained/rules.rst

View Options

include/crm/common/iso8601_internal.h

View Options

include/crm/common/options.h

View Options

include/crm/common/rules_internal.h

View Options

include/crm/pengine/rules_internal.h

View Options

lib/common/crmcommon_private.h

View Options

lib/common/iso8601.c

View Options

lib/common/rules.c

View Options

lib/common/tests/iso8601/pcmk__add_time_from_xml_test.c

View Options

lib/common/tests/iso8601/pcmk__set_time_if_earlier_test.c

View Options

lib/common/tests/rules/Makefile.am

View Options

lib/common/tests/rules/pcmk__evaluate_date_expression_test.c

View Options

lib/common/tests/rules/pcmk__evaluate_date_spec_test.c

View Options

lib/common/tests/rules/pcmk__unpack_duration_test.c

View Options

lib/pacemaker/pcmk_rule.c

View Options

lib/pengine/rules.c

View Options

Merge pull request #3371 from kgaillot/best-practices8785c8efe180Actions

Description

Details

Event Timeline

Merged Changes

Changes (18)

rP8785c8efe180

doc/sphinx/Pacemaker_Explained/local-options.rst

doc/sphinx/Pacemaker_Explained/rules.rst

include/crm/common/iso8601_internal.h

include/crm/common/options.h

include/crm/common/rules_internal.h

include/crm/pengine/rules_internal.h

lib/common/crmcommon_private.h

lib/common/iso8601.c

lib/common/rules.c

lib/common/tests/iso8601/pcmk__add_time_from_xml_test.c

lib/common/tests/iso8601/pcmk__set_time_if_earlier_test.c

lib/common/tests/rules/Makefile.am

lib/common/tests/rules/pcmk__evaluate_date_expression_test.c

lib/common/tests/rules/pcmk__evaluate_date_spec_test.c

lib/common/tests/rules/pcmk__unpack_duration_test.c

lib/pacemaker/pcmk_rule.c

lib/pengine/rules.c

tools/crm_resource_ban.c

Merge pull request #3371 from kgaillot/best-practices
8785c8efe180
Actions