Merge pull request #3966 from nrwahl2/nrwahl2-refactors
b290466cb374
Actions

Description

Merge pull request #3966 from nrwahl2/nrwahl2-refactors

Simplify pacemakerd child code, deprecate pcmk_daemon_user() and crm_user_lookup()

Details

Provenance

clumens	Authored on Tue, Sep 23, 4:44 PM
GitHub <noreply@github.com>	Committed on Tue, Sep 23, 4:44 PM

Parents

rPf679edbb0a8b: Merge pull request #3969 from clumens/minor-pychecks
rP96627bf52e94: Refactor: based: Correct return codes in check_group_membership()

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPb290466cb374: Merge pull request #3966 from nrwahl2/nrwahl2-refactors (authored by clumens).Tue, Sep 23, 4:44 PM

Merged Changes

96627bf52e94 Refactor: based: Correct return codes in check_group_membership()
Author
nrwahl2
Browse Repository
No Audits
59b28a3483aa Refactor: libcib: cib_file_write_live() returns standard code
Author
nrwahl2
Browse Repository
No Audits
e289c014e40d Refactor: libcrmcommon: Use bool instead of gboolean values in io.c
Author
nrwahl2
Browse Repository
No Audits
e789fa0a4eb3 Refactor: pacemakerd: Drop redundant uid_t/gid_t variables
Author
nrwahl2
Browse Repository
No Audits
287297db58e1 Refactor: libcrmcommon: Drop PCMK__PW_BUFFER_LEN
Author
nrwahl2
Browse Repository
No Audits
7812c54e22e3 API: libcrmcommon: Deprecate crm_user_lookup()
Author
nrwahl2
Browse Repository
No Audits
05b9a76aec6d API: libcrmservice: Change services_action_user() not-found return code
Author
nrwahl2
Browse Repository
No Audits
3f3949141db8 API: libcrmcommon: Deprecate pcmk_daemon_user()
Author
nrwahl2
Browse Repository
No Audits
f3ae64746edb Refactor: libcrmcommon: New pcmk__daemon_user()
Author
nrwahl2
Browse Repository
No Audits
5014c98b285c Refactor: pacemakerd: Simplify child_liveness() somewhat
Author
nrwahl2
Browse Repository
No Audits
4d0d105930c9 Refactor: pacemakerd: Remove more nesting in child_liveness()
Author
nrwahl2
Browse Repository
No Audits
22127cb3f875 Refactor: pacemakerd: Drop pid_active variable
Author
nrwahl2
Browse Repository
No Audits
2eb07de373e3 Refactor: pacemakerd: Remove some nesting in child_liveness()
Author
nrwahl2
Browse Repository
No Audits
6a054f675fbd Refactor: pacemakerd: Rename pcmk_child_t to pcmkd_child_t
Author
nrwahl2
Browse Repository
No Audits
205f396ff87d Refactor: pacemakerd: New child_as_root flag for pcmk_child_t
Author
nrwahl2
Browse Repository
No Audits
b531520fcf5f Refactor: pacemakerd: Remove more nesting in start_child()
Author
nrwahl2
Browse Repository
No Audits
b1c0fcda9144 Refactor: pacemakerd: Reduce nesting in pcmk_subdaemons.c:start_child()
Author
nrwahl2
Browse Repository
No Audits

Changes (24)

Path

Size

daemons/

based/

pacemakerd/

include/

crm/

common/

internal.h

util.h

util_compat.h

lib/

cib/

common/

tests/

utils/

Makefile.am

crm_user_lookup_test.c

pcmk__daemon_user_test.c

pcmk__lookup_user_test.c

pcmk_daemon_user_test.c

utils.c

services/

services.c

mk/

tap.mk

rPb290466cb374

View Options

daemons/based/based_remote.c

View Options

daemons/based/pacemaker-based.c

View Options

daemons/pacemakerd/pacemakerd.c

View Options

daemons/pacemakerd/pcmkd_corosync.c

View Options

daemons/pacemakerd/pcmkd_subdaemons.c

View Options

include/crm/common/internal.h

View Options

include/crm/common/util.h

View Options

include/crm/common/util_compat.h

View Options

lib/cib/cib_file.c

View Options

lib/common/crmcommon_private.h

View Options

lib/common/io.c

View Options

lib/common/ipc_client.c

View Options

lib/common/ipc_server.c

View Options

lib/common/logging.c

View Options

lib/common/mock.c

View Options

lib/common/mock_private.h

View Options

lib/common/tests/utils/Makefile.am

View Options

lib/common/tests/utils/crm_user_lookup_test.c

View Options

lib/common/tests/utils/pcmk__daemon_user_test.c

View Options

lib/common/tests/utils/pcmk__lookup_user_test.c

View Options

lib/common/tests/utils/pcmk_daemon_user_test.c

View Options

lib/common/utils.c

View Options

lib/services/services.c

View Options

Merge pull request #3966 from nrwahl2/nrwahl2-refactorsb290466cb374Actions

Description

Details

Event Timeline

Merged Changes

Changes (24)

rPb290466cb374

daemons/based/based_remote.c

daemons/based/pacemaker-based.c

daemons/pacemakerd/pacemakerd.c

daemons/pacemakerd/pcmkd_corosync.c

daemons/pacemakerd/pcmkd_subdaemons.c

include/crm/common/internal.h

include/crm/common/util.h

include/crm/common/util_compat.h

lib/cib/cib_file.c

lib/common/crmcommon_private.h

lib/common/io.c

lib/common/ipc_client.c

lib/common/ipc_server.c

lib/common/logging.c

lib/common/mock.c

lib/common/mock_private.h

lib/common/tests/utils/Makefile.am

lib/common/tests/utils/crm_user_lookup_test.c

lib/common/tests/utils/pcmk__daemon_user_test.c

lib/common/tests/utils/pcmk__lookup_user_test.c

lib/common/tests/utils/pcmk_daemon_user_test.c

lib/common/utils.c

lib/services/services.c

mk/tap.mk

Merge pull request #3966 from nrwahl2/nrwahl2-refactors
b290466cb374
Actions