Merge pull request #3355 from kgaillot/best-practices
bc5596299458
Actions

Description

Merge pull request #3355 from kgaillot/best-practices

Bring INFINITY constants up to current guidelines

Details

Provenance

kgaillot	Authored on Feb 8 2024, 6:17 PM
GitHub <noreply@github.com>	Committed on Feb 8 2024, 6:17 PM

Parents

rPc45442386f2d: Merge pull request #3356 from clumens/validate
rP2ff610ae4abc: API: libcrmcommon: deprecate INFINITY integer constant

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPbc5596299458: Merge pull request #3355 from kgaillot/best-practices (authored by kgaillot).Feb 8 2024, 6:17 PM

Merged Changes

2ff610ae4abc API: libcrmcommon: deprecate INFINITY integer constant
Author
kgaillot
Browse Repository
No Audits
62428bd72291 API: libcrmcommon: deprecate CRM_SCORE_INFINITY integer constant
Author
kgaillot
Browse Repository
No Audits
b0245c5f1a77 API: libcrmcommon: add PCMK_SCORE_INFINITY constant
Author
kgaillot
Browse Repository
No Audits
026eccc0caec Refactor: libcrmcommon: separate score-related APIs into their own headers
Author
kgaillot
Browse Repository
No Audits
162cef6dbe84 API: libcrmcommon: deprecate MINUS_INFINITY_S string constant
Author
kgaillot
Browse Repository
No Audits
4c68150450b6 API: libcrmcommon: deprecate INFINITY_S string constant
Author
kgaillot
Browse Repository
No Audits
63390bbc7fdb API: libcrmcommon: deprecate CRM_MINUS_INFINITY_S
Author
kgaillot
Browse Repository
No Audits
93104301a480 API: libcrmcommon: add PCMK_VALUE_MINUS_INFINITY string constant
Author
kgaillot
Browse Repository
No Audits
7c6df87bf1ee API: libcrmcommon: deprecate CRM_PLUS_INFINITY_S
Author
kgaillot
Browse Repository
No Audits
f0a461087b40 API: libcrmcommon: add PCMK_VALUE_PLUS_INFINITY string constant
Author
kgaillot
Browse Repository
No Audits
fd0239eac798 API: libcrmcommon: deprecate CRM_INFINITY_S
Author
kgaillot
Browse Repository
No Audits
14a597f0a81f API: libcrmcommon: add PCMK_VALUE_INFINITY string constant
Author
kgaillot
Browse Repository
No Audits

Changes (49)

Path

Size

daemons/

attrd/

controld/

controld_membership.c

controld_te_callbacks.c

controld_te_events.c

controld_te_utils.c

controld_transition.c

include/

crm/

common/

	common/

	scores.h
	cib_compat.h

crm.h

crm_compat.h

lib/

common/

scores.c

tests/

scores/

char2score_test.c

pcmk__add_scores_test.c

pcmk_readable_score_test.c

utils.c

xml.c

pacemaker/

pcmk_graph_consumer.c

pcmk_sched_bundle.c

pcmk_sched_clone.c

pcmk_sched_colocation.c

pcmk_sched_group.c

pcmk_sched_instances.c

pcmk_sched_location.c

pcmk_sched_nodes.c

pcmk_sched_primitive.c

pcmk_sched_promotable.c

pcmk_sched_resource.c

pcmk_sched_tickets.c

pcmk_sched_utilization.c

pengine/

tools/

rPbc5596299458

View Options

daemons/attrd/attrd_utils.c

View Options

daemons/controld/controld_callbacks.c

View Options

daemons/controld/controld_fencing.c

View Options

daemons/controld/controld_join_dc.c

View Options

daemons/controld/controld_membership.c

View Options

daemons/controld/controld_te_callbacks.c

View Options

daemons/controld/controld_te_events.c

View Options

daemons/controld/controld_te_utils.c

View Options

daemons/controld/controld_transition.c

View Options

include/crm/common/Makefile.am

View Options

include/crm/common/internal.h

View Options

include/crm/common/options.h

View Options

include/crm/common/scores.h

View Options

include/crm/common/scores_compat.h

View Options

include/crm/common/scores_internal.h

View Options

include/crm/common/util.h

View Options

include/crm/common/util_compat.h

View Options

include/crm/crm.h

View Options

include/crm/crm_compat.h

View Options

lib/common/scores.c

View Options

lib/common/tests/scores/char2score_test.c

View Options

lib/common/tests/scores/pcmk__add_scores_test.c

View Options

lib/common/tests/scores/pcmk_readable_score_test.c

View Options

lib/common/utils.c

View Options

lib/common/xml.c

View Options

lib/pacemaker/pcmk_graph_consumer.c

View Options

lib/pacemaker/pcmk_sched_bundle.c

View Options

lib/pacemaker/pcmk_sched_clone.c

View Options

lib/pacemaker/pcmk_sched_colocation.c

View Options

lib/pacemaker/pcmk_sched_group.c

View Options

lib/pacemaker/pcmk_sched_instances.c

View Options

lib/pacemaker/pcmk_sched_location.c

View Options

lib/pacemaker/pcmk_sched_nodes.c

View Options

lib/pacemaker/pcmk_sched_primitive.c

View Options

lib/pacemaker/pcmk_sched_promotable.c

View Options

lib/pacemaker/pcmk_sched_resource.c

View Options

lib/pacemaker/pcmk_sched_tickets.c

View Options

lib/pacemaker/pcmk_sched_utilization.c

View Options

lib/pacemaker/pcmk_scheduler.c

View Options

lib/pacemaker/pcmk_simulate.c

View Options

lib/pengine/bundle.c

View Options

lib/pengine/clone.c

View Options

lib/pengine/complex.c

View Options

lib/pengine/native.c

View Options

lib/pengine/pe_health.c

View Options

lib/pengine/pe_notif.c

View Options

lib/pengine/unpack.c

View Options

lib/pengine/utils.c

View Options

Merge pull request #3355 from kgaillot/best-practicesbc5596299458Actions

Description

Details

Event Timeline

Merged Changes

Changes (49)

rPbc5596299458

daemons/attrd/attrd_utils.c

daemons/controld/controld_callbacks.c

daemons/controld/controld_fencing.c

daemons/controld/controld_join_dc.c

daemons/controld/controld_membership.c

daemons/controld/controld_te_callbacks.c

daemons/controld/controld_te_events.c

daemons/controld/controld_te_utils.c

daemons/controld/controld_transition.c

include/crm/common/Makefile.am

include/crm/common/internal.h

include/crm/common/options.h

include/crm/common/scores.h

include/crm/common/scores_compat.h

include/crm/common/scores_internal.h

include/crm/common/util.h

include/crm/common/util_compat.h

include/crm/crm.h

include/crm/crm_compat.h

lib/common/scores.c

lib/common/tests/scores/char2score_test.c

lib/common/tests/scores/pcmk__add_scores_test.c

lib/common/tests/scores/pcmk_readable_score_test.c

lib/common/utils.c

lib/common/xml.c

lib/pacemaker/pcmk_graph_consumer.c

lib/pacemaker/pcmk_sched_bundle.c

lib/pacemaker/pcmk_sched_clone.c

lib/pacemaker/pcmk_sched_colocation.c

lib/pacemaker/pcmk_sched_group.c

lib/pacemaker/pcmk_sched_instances.c

lib/pacemaker/pcmk_sched_location.c

lib/pacemaker/pcmk_sched_nodes.c

lib/pacemaker/pcmk_sched_primitive.c

lib/pacemaker/pcmk_sched_promotable.c

lib/pacemaker/pcmk_sched_resource.c

lib/pacemaker/pcmk_sched_tickets.c

lib/pacemaker/pcmk_sched_utilization.c

lib/pacemaker/pcmk_scheduler.c

lib/pacemaker/pcmk_simulate.c

lib/pengine/bundle.c

lib/pengine/clone.c

lib/pengine/complex.c

lib/pengine/native.c

lib/pengine/pe_health.c

lib/pengine/pe_notif.c

lib/pengine/unpack.c

lib/pengine/utils.c

tools/crm_resource_ban.c

Merge pull request #3355 from kgaillot/best-practices
bc5596299458
Actions