Merge pull request #2747 from kgaillot/best-practices
d1ee5c9fdcdf
Actions

Description

Merge pull request #2747 from kgaillot/best-practices

Best practices for some clone-related functions

Details

Provenance

kgaillot	Authored on Jul 6 2022, 12:00 PM
GitHub <noreply@github.com>	Committed on Jul 6 2022, 12:00 PM

Parents

rP3c4fbfabe5f2: Merge pull request #2727 from kgaillot/fencing
rP7ae9293280a0: Refactor: scheduler: best practices for sort_promotable_instance()

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPd1ee5c9fdcdf: Merge pull request #2747 from kgaillot/best-practices (authored by kgaillot).Jul 6 2022, 12:00 PM

Merged Changes

7ae9293280a0 Refactor: scheduler: best practices for sort_promotable_instance()
Author
kgaillot
Browse Repository
No Audits
f59582edd813 Refactor: scheduler: pcmk__node_available() optionally checks guest
Author
kgaillot
Browse Repository
No Audits
356d4a745c92 Refactor: scheduler: pcmk__node_available() optionally checks score
Author
kgaillot
Browse Repository
No Audits
76391835aa10 Refactor: scheduler: best practices for node_to_be_promoted_on()
Author
kgaillot
Browse Repository
No Audits
127fd57c4aa3 Refactor: scheduler: best practices for apply_promoted_location()
Author
kgaillot
Browse Repository
No Audits
a7195a62f44d Refactor: scheduler: best practices when checking for role changes
Author
kgaillot
Browse Repository
No Audits
8b7b4294109e Refactor: scheduler: best practices when ordering instance demotion
Author
kgaillot
Browse Repository
No Audits
f04c1ea97475 Refactor: scheduler: drop dead code in child_demoting_constraints()
Author
kgaillot
Browse Repository
No Audits
ce2f07fb1cce Refactor: scheduler: drop unnecessary arguments to child_demoting_constraints()
Author
kgaillot
Browse Repository
No Audits
1297c2cca413 Refactor: scheduler: best practices when ordering instance promotion
Author
kgaillot
Browse Repository
No Audits
edd3855f2741 Refactor: scheduler: drop dead code in child_promoting_constraints()
Author
kgaillot
Browse Repository
No Audits
60e5315d6ccf Refactor: scheduler: drop unnecessary arguments to child_promoting_constraints()
Author
kgaillot
Browse Repository
No Audits
77d2364d1abd Refactor: scheduler: make more clone variant members into flags
Author
kgaillot
Browse Repository
No Audits
8bd6c8e5d148 Refactor: scheduler: make "ordered" clone variant member a flag
Author
kgaillot
Browse Repository
No Audits

Changes (12)

Path

Size

include/

crm/

pengine/

internal.h

lib/

pacemaker/

libpacemaker_private.h

pcmk_sched_promotable.c

pcmk_sched_resource.c

pcmk_sched_utilization.c

pengine/

clone.c

utils.c

variant.h

rPd1ee5c9fdcdf

View Options

include/crm/pengine/internal.h

View Options

lib/pacemaker/libpacemaker_private.h

View Options

lib/pacemaker/pcmk_sched_actions.c

View Options

lib/pacemaker/pcmk_sched_clone.c

View Options

lib/pacemaker/pcmk_sched_native.c

View Options

lib/pacemaker/pcmk_sched_nodes.c

View Options

lib/pacemaker/pcmk_sched_promotable.c

View Options

lib/pacemaker/pcmk_sched_resource.c

View Options

lib/pacemaker/pcmk_sched_utilization.c

View Options

lib/pengine/clone.c

View Options

lib/pengine/utils.c

View Options

Merge pull request #2747 from kgaillot/best-practicesd1ee5c9fdcdfActions

Description

Details

Event Timeline

Merged Changes

Changes (12)

rPd1ee5c9fdcdf

include/crm/pengine/internal.h

lib/pacemaker/libpacemaker_private.h

lib/pacemaker/pcmk_sched_actions.c

lib/pacemaker/pcmk_sched_clone.c

lib/pacemaker/pcmk_sched_native.c

lib/pacemaker/pcmk_sched_nodes.c

lib/pacemaker/pcmk_sched_promotable.c

lib/pacemaker/pcmk_sched_resource.c

lib/pacemaker/pcmk_sched_utilization.c

lib/pengine/clone.c

lib/pengine/utils.c

lib/pengine/variant.h

Merge pull request #2747 from kgaillot/best-practices
d1ee5c9fdcdf
Actions