Merge pull request #2646 from kgaillot/best-practices
d682d15abe3e
Actions

Description

Merge pull request #2646 from kgaillot/best-practices

Best practices for libpacemaker node functions

Details

Provenance

kgaillot	Authored on Feb 23 2022, 10:33 AM
GitHub <noreply@github.com>	Committed on Feb 23 2022, 10:33 AM

Parents

rPf465f1b86a84: Test: libcrmcommon: add unit test for pcmk__add_scores()
rP250a6b0d7a83: Merge pull request #2643 from kgaillot/nls

Branches

Unknown

Tags

Unknown

Event Timeline

Merged Changes

f465f1b86a84 Test: libcrmcommon: add unit test for pcmk__add_scores()
Author
kgaillot
Browse Repository
No Audits
821dd218f620 Test: libcrmcommon: update unit tests for recent source file changes
Author
kgaillot
Browse Repository
No Audits
d29b6477f4b9 Test: cts-scheduler: fix option name typo in some inputs
Author
kgaillot
Browse Repository
No Audits
cdc3b377a389 Refactor: scheduler: set red/yellow/green values when unpacking configuration
Author
kgaillot
Browse Repository
No Audits
c187d8d7e065 Refactor: libcrmcommon,libpe_status: move and rename score adding function
Author
kgaillot
Browse Repository
No Audits
3ade3ab9106b Refactor: libcrmcommon: best practices when converting score to string
Author
kgaillot
Browse Repository
No Audits
a5f42d67d79c Refactor: libcrmcommon: best practices when converting score to string buffer
Author
kgaillot
Browse Repository
No Audits
f26bf8e3ba19 Refactor: libcrmcommon: best practices when converting string to score
Author
kgaillot
Browse Repository
No Audits
a6a9f306083e Refactor: libcrmcommon: separate score-related code into own source file
Author
kgaillot
Browse Repository
No Audits
bb49b103c6b1 Refactor: scheduler: best practices when applying node health values
Author
kgaillot
Browse Repository
No Audits
ccc954291e7c Refactor: scheduler: best practices when adding node health values
Author
kgaillot
Browse Repository
No Audits
059dd2d67a3a Refactor: scheduler: make some node functions library-private
Author
kgaillot
Browse Repository
No Audits
5e2c850f12ea Refactor: scheduler: move node health-related functions to pcmk_sched_nodes.c
Author
kgaillot
Browse Repository
No Audits

Changes (34)

Path

Size

configure.ac

cts/

scheduler/

xml/

include/

crm/

common/

util.h

pengine/

internal.h

pcmki/

pcmki_sched_utils.h

lib/

common/

tests/

pcmk__add_scores_test.c

	scores/
	io/

Makefile.am

	scores/
	utils/

char2score_test.c

score2char_stack_test.c

score2char_test.c

utils/

Makefile.am

char2score_test.c

score2char_stack_test.c

score2char_test.c

utils.c

pacemaker/

libpacemaker_private.h

pcmk_sched_allocate.c

pcmk_sched_colocation.c

pcmk_sched_location.c

pcmk_sched_native.c

pcmk_sched_nodes.c

pcmk_sched_promotable.c

pengine/

rPd682d15abe3e

View Options

configure.ac

View Options

cts/scheduler/xml/systemhealthm1.xml

View Options

cts/scheduler/xml/systemhealthn1.xml

View Options

cts/scheduler/xml/systemhealtho1.xml

View Options

cts/scheduler/xml/systemhealthp1.xml

View Options

include/crm/common/util.h

View Options

include/crm/pengine/internal.h

View Options

include/pcmki/pcmki_sched_utils.h

View Options

lib/common/Makefile.am

View Options

lib/common/scores.c

View Options

lib/common/tests/Makefile.am

View Options

lib/common/tests/scores/Makefile.am

View Options

lib/common/tests/scores/char2score_test.c

View Options

lib/common/tests/scores/pcmk__add_scores_test.c

View Options

lib/common/tests/scores/score2char_stack_test.c

View Options

lib/common/tests/scores/score2char_test.c

View Options

lib/common/tests/utils/Makefile.am

View Options

lib/common/tests/utils/char2score_test.c

View Options

lib/common/tests/utils/score2char_stack_test.c

View Options

lib/common/tests/utils/score2char_test.c

View Options

lib/common/utils.c

View Options

lib/pacemaker/libpacemaker_private.h

View Options

lib/pacemaker/pcmk_sched_allocate.c

View Options

lib/pacemaker/pcmk_sched_colocation.c

View Options

lib/pacemaker/pcmk_sched_location.c

View Options

lib/pacemaker/pcmk_sched_native.c

View Options

lib/pacemaker/pcmk_sched_nodes.c

View Options

lib/pacemaker/pcmk_sched_promotable.c

View Options

lib/pengine/common.c

View Options

lib/pengine/complex.c

View Options

lib/pengine/failcounts.c

View Options

lib/pengine/unpack.c

View Options

Merge pull request #2646 from kgaillot/best-practicesd682d15abe3eActions

Description

Details

Event Timeline

Merged Changes

Changes (34)

rPd682d15abe3e

configure.ac

cts/scheduler/xml/systemhealthm1.xml

cts/scheduler/xml/systemhealthn1.xml

cts/scheduler/xml/systemhealtho1.xml

cts/scheduler/xml/systemhealthp1.xml

include/crm/common/util.h

include/crm/pengine/internal.h

include/pcmki/pcmki_sched_utils.h

lib/common/Makefile.am

lib/common/scores.c

lib/common/tests/Makefile.am

lib/common/tests/scores/Makefile.am

lib/common/tests/scores/char2score_test.c

lib/common/tests/scores/pcmk__add_scores_test.c

lib/common/tests/scores/score2char_stack_test.c

lib/common/tests/scores/score2char_test.c

lib/common/tests/utils/Makefile.am

lib/common/tests/utils/char2score_test.c

lib/common/tests/utils/score2char_stack_test.c

lib/common/tests/utils/score2char_test.c

lib/common/utils.c

lib/pacemaker/libpacemaker_private.h

lib/pacemaker/pcmk_sched_allocate.c

lib/pacemaker/pcmk_sched_colocation.c

lib/pacemaker/pcmk_sched_location.c

lib/pacemaker/pcmk_sched_native.c

lib/pacemaker/pcmk_sched_nodes.c

lib/pacemaker/pcmk_sched_promotable.c

lib/pengine/common.c

lib/pengine/complex.c

lib/pengine/failcounts.c

lib/pengine/unpack.c

lib/pengine/utils.c

Merge pull request #2646 from kgaillot/best-practices
d682d15abe3e
Actions