Merge pull request #2838 from nrwahl2/nrwahl2-T95
dbf31514847f
Actions

Description

Merge pull request #2838 from nrwahl2/nrwahl2-T95

libcrmcommon, tools: Various refactors and improvements

Details

Provenance

kgaillot	Authored on Sep 7 2022, 3:18 PM
GitHub <noreply@github.com>	Committed on Sep 7 2022, 3:18 PM

Parents

rPc5b5088805c4: Refactor: tools: Use while in crm_error when we modify loop var in body
rP0670602e4f0e: Merge pull request #2844 from kgaillot/best-practices

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPdbf31514847f: Merge pull request #2838 from nrwahl2/nrwahl2-T95 (authored by kgaillot).Sep 7 2022, 3:18 PM

Merged Changes

c5b5088805c4 Refactor: tools: Use while in crm_error when we modify loop var in body
Author
nrwahl2
Browse Repository
No Audits
b601af37371b Refactor: tools: Use pcmk__str_any_of() in crm_error list loop
Author
nrwahl2
Browse Repository
No Audits
5b5ba9ebca5b Refactor: tools: Improve loop bounds in crm_error
Author
nrwahl2
Browse Repository
No Audits
3a6fcad06058 Feature: libcrmcommon: New function to get bounds of given rc family
Author
nrwahl2
Browse Repository
No Audits
d987fd9ae2c9 Low: tools: Use dynamic widths in crm_error list
Author
nrwahl2
Browse Repository
No Audits
5c572218f13a Feature: libcrmcommon: Internal constant for number of Pacemaker RCs
Author
nrwahl2
Browse Repository
No Audits
01714fc91dd4 Refactor: libcrmcommon: Use PCMK__NELEM() to compute PCMK__N_RC
Author
nrwahl2
Browse Repository
No Audits
c58dc149b3bf Refactor: tools: Use pcmk_result_get_strings() in crm_error
Author
nrwahl2
Browse Repository
No Audits
9e9693740f04 API: libcrmcommon: New pcmk_result_get_strings() function
Author
nrwahl2
Browse Repository
No Audits
3931c2b1964d Fix: tools: crm_error should use last rc format given
Author
nrwahl2
Browse Repository
No Audits
a970124a4d72 API: libcrmcommon: New pcmk_result_type enum
Author
nrwahl2
Browse Repository
No Audits
dc0aea05792e Feature: tools: List all RCs if none are specified for crm_error
Author
nrwahl2
Browse Repository
No Audits
975b55fff643 Refactor: tools: Remove main-scope rc variable in crm_error
Author
nrwahl2
Browse Repository
No Audits
b2aa1b7a5b26 Refactor: tools: Make lpc a loop-scope variable in crm_error
Author
nrwahl2
Browse Repository
No Audits
2387e0a841f1 Fix: crm_error: Handle negative return code arguments
Author
nrwahl2
Browse Repository
No Audits
668597145605 Doc: libcrmcommon: Note pcmk__str_none in pcmk__strcmp doxygen comment
Author
nrwahl2
Browse Repository
No Audits

Changes (5)

Path

Size

include/

crm/

common/

results.h

results_internal.h

lib/

common/

results.c

strings.c

tools/

crm_error.c

rPdbf31514847f

View Options

include/crm/common/results.h

View Options

include/crm/common/results_internal.h

View Options

lib/common/results.c

View Options

lib/common/strings.c

View Options

Merge pull request #2838 from nrwahl2/nrwahl2-T95dbf31514847fActions

Description

Details

Event Timeline

Merged Changes

Changes (5)

rPdbf31514847f

include/crm/common/results.h

include/crm/common/results_internal.h

lib/common/results.c

lib/common/strings.c

tools/crm_error.c

Merge pull request #2838 from nrwahl2/nrwahl2-T95
dbf31514847f
Actions