Merge pull request #3062 from nrwahl2/nrwahl2-fixes
51544f4ed0ef
Actions

Description

Merge pull request #3062 from nrwahl2/nrwahl2-fixes

Various cleanups and fixes: mostly libcib, based, and controller

Details

Provenance

kgaillot	Authored on Apr 4 2023, 10:24 AM
GitHub <noreply@github.com>	Committed on Apr 4 2023, 10:24 AM

Parents

rPde272530347a: Refactor: controller: Make lrm_state_create() static
rP3bbeab0a2375: Merge pull request #3066 from kgaillot/scheduler

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP51544f4ed0ef: Merge pull request #3062 from nrwahl2/nrwahl2-fixes (authored by kgaillot).Apr 4 2023, 10:24 AM

Merged Changes

de272530347a Refactor: controller: Make lrm_state_create() static
Author
nrwahl2
Browse Repository
No Audits
3428086dd991 Low: controller: Unlocked lrm_resource should include cleared/expired
Author
nrwahl2
Browse Repository
No Audits
d6f349d734c5 Refactor: controller: Add shutdown-lock-limit to controller_options
Author
nrwahl2
Browse Repository
No Audits
c459e6321511 Refactor: controller: Don't destroy outside events table until shutdown
Author
nrwahl2
Browse Repository
No Audits
f6c61d375ce6 Low: controller: Ensure we don't ignore relevant CIB replacements
Author
nrwahl2
Browse Repository
No Audits
260d625daf56 Refactor: controller: New controld_globals.cib_client_id member
Author
nrwahl2
Browse Repository
No Audits
bcc9a53bfaf5 API: libcib: New cib_api_operations_t:client_id() method
Author
nrwahl2
Browse Repository
No Audits
a824b46212c9 Log: based: Use correct local-only diff logic
Author
nrwahl2
Browse Repository
No Audits
15678b7c8ac8 Refactor: based: Make CIB diff/replace notify more similar
Author
nrwahl2
Browse Repository
No Audits
f604ff091ef5 Refactor: based: Make attach_cib_generation() static
Author
nrwahl2
Browse Repository
No Audits
67af9725a71b Refactor: based: Defunctionize do_cib_notify()
Author
nrwahl2
Browse Repository
No Audits
a980f534cae5 Refactor: based, libcib: Drop F_CIB_CALLBACK_TOKEN
Author
nrwahl2
Browse Repository
No Audits
0aea09ec8a67 API: libcib: Deprecate the cib_api_operations_t:update() method
Author
nrwahl2
Browse Repository
No Audits
2dac62aac9ab Refactor: various: Replace cib_api_operations_t:update() with modify()
Author
nrwahl2
Browse Repository
No Audits
742e50643493 Refactor: controller: Make controld_globals.resource_update file-scope
Author
nrwahl2
Browse Repository
No Audits
c7207b08e547 API: libcrmcommon: Deprecate XML_CIB_ATTR_REPLACE
Author
nrwahl2
Browse Repository
No Audits
03e54ebecf1c Refactor: libcib: Add compat note for XML_CIB_ATTR_REPLACE code
Author
nrwahl2
Browse Repository
No Audits
c76dbce9606f Refactor: various: Remove unnecessary SUPPORT_COROSYNC guards
Author
nrwahl2
Browse Repository
No Audits
d9ce979d20cd Refactor: pacemakerd: Make need_root_group global
Author
nrwahl2
Browse Repository
No Audits
47df3543d749 API: libcib: Deprecate cib_database
Author
nrwahl2
Browse Repository
No Audits
faef6ae8f115 Refactor: tools: Remove sole internal use of cib_database
Author
nrwahl2
Browse Repository
No Audits
d1bff5d11f27 API: libcib: Deprecate cib_quorum_override
Author
nrwahl2
Browse Repository
No Audits
44d7783095c4 Refactor: various: Remove all internal uses of cib_quorum_override
Author
nrwahl2
Browse Repository
No Audits
8f21e4b55384 Refactor: tools: Remove checks for pcmk_rc_no_quorum
Author
nrwahl2
Browse Repository
No Audits
0772d7e49133 Refactor: based: Remove struct cib_operation_s:needs_quorum
Author
nrwahl2
Browse Repository
No Audits
d4152a4ff751 Refactor: based: Remove global_update variable from cib_op_can_run()
Author
nrwahl2
Browse Repository
No Audits
0d7c16c8b802 Refactor: based: Remove dead code in cib_op_can_run()
Author
nrwahl2
Browse Repository
No Audits

Changes (44)

Path

Size

cts/

cli/

regression.daemons.exp

daemons/

attrd/

based/

controld/

controld_execd_state.c

controld_membership.c

controld_messages.c

controld_te_actions.c

controld_te_callbacks.c

controld_te_events.c

controld_transition.h

controld_utils.c

pacemakerd/

pcmkd_subdaemons.c

include/

crm/

cib/

cib_types.h

internal.h

msg_xml.h

lib/

cib/

cluster/

pengine/

tools/

rP51544f4ed0ef

View Options

cts/cli/regression.daemons.exp

View Options

daemons/attrd/attrd_cib.c

View Options

daemons/attrd/pacemaker-attrd.c

View Options

daemons/based/based_callbacks.c

View Options

daemons/based/based_common.c

View Options

daemons/based/based_notify.c

View Options

daemons/based/based_remote.c

View Options

daemons/based/pacemaker-based.h

View Options

daemons/controld/controld_cib.c

View Options

daemons/controld/controld_cib.h

View Options

daemons/controld/controld_control.c

View Options

daemons/controld/controld_election.c

View Options

daemons/controld/controld_execd_state.c

View Options

daemons/controld/controld_fencing.c

View Options

daemons/controld/controld_fsa.h

View Options

daemons/controld/controld_globals.h

View Options

daemons/controld/controld_join_dc.c

View Options

daemons/controld/controld_lrm.h

View Options

daemons/controld/controld_membership.c

View Options

daemons/controld/controld_messages.c

View Options

daemons/controld/controld_te_actions.c

View Options

daemons/controld/controld_te_callbacks.c

View Options

daemons/controld/controld_te_events.c

View Options

daemons/controld/controld_transition.h

View Options

daemons/controld/controld_utils.c

View Options

daemons/pacemakerd/pcmkd_subdaemons.c

View Options

include/crm/cib/cib_types.h

View Options

include/crm/cib/internal.h

View Options

include/crm/msg_xml.h

View Options

lib/cib/cib_attrs.c

View Options

lib/cib/cib_client.c

View Options

lib/cib/cib_file.c

View Options

lib/cib/cib_native.c

View Options

lib/cib/cib_ops.c

View Options

lib/cib/cib_remote.c

View Options

lib/cib/cib_utils.c

View Options

lib/cluster/cluster.c

View Options

lib/pengine/common.c

View Options

tools/cibadmin.c

View Options

tools/crm_mon.c

View Options

tools/crm_resource.c

View Options

tools/crm_resource_ban.c

View Options

tools/crm_shadow.c

View Options

Merge pull request #3062 from nrwahl2/nrwahl2-fixes51544f4ed0efActions

Description

Details

Event Timeline

Merged Changes

Changes (44)

rP51544f4ed0ef

cts/cli/regression.daemons.exp

daemons/attrd/attrd_cib.c

daemons/attrd/pacemaker-attrd.c

daemons/based/based_callbacks.c

daemons/based/based_common.c

daemons/based/based_notify.c

daemons/based/based_remote.c

daemons/based/pacemaker-based.h

daemons/controld/controld_cib.c

daemons/controld/controld_cib.h

daemons/controld/controld_control.c

daemons/controld/controld_election.c

daemons/controld/controld_execd_state.c

daemons/controld/controld_fencing.c

daemons/controld/controld_fsa.h

daemons/controld/controld_globals.h

daemons/controld/controld_join_dc.c

daemons/controld/controld_lrm.h

daemons/controld/controld_membership.c

daemons/controld/controld_messages.c

daemons/controld/controld_te_actions.c

daemons/controld/controld_te_callbacks.c

daemons/controld/controld_te_events.c

daemons/controld/controld_transition.h

daemons/controld/controld_utils.c

daemons/pacemakerd/pcmkd_subdaemons.c

include/crm/cib/cib_types.h

include/crm/cib/internal.h

include/crm/msg_xml.h

lib/cib/cib_attrs.c

lib/cib/cib_client.c

lib/cib/cib_file.c

lib/cib/cib_native.c

lib/cib/cib_ops.c

lib/cib/cib_remote.c

lib/cib/cib_utils.c

lib/cluster/cluster.c

lib/pengine/common.c

tools/cibadmin.c

tools/crm_mon.c

tools/crm_resource.c

tools/crm_resource_ban.c

tools/crm_shadow.c

tools/crm_ticket.c

Merge pull request #3062 from nrwahl2/nrwahl2-fixes
51544f4ed0ef
Actions