Merge pull request #2809 from kgaillot/best-practices
d63aea900772
Actions

Description

Merge pull request #2809 from kgaillot/best-practices

Best practices for primitive expand() and create_probe() methods

Details

Provenance

kgaillot	Authored on Aug 22 2022, 4:01 PM
GitHub <noreply@github.com>	Committed on Aug 22 2022, 4:01 PM

Parents

rP0b28d46b2772: Merge pull request #2806 from nrwahl2/nrwahl2-T498
rP947b8c7b9575: Refactor: scheduler: use g_list_foreach() to add resource actions to graph

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPd63aea900772: Merge pull request #2809 from kgaillot/best-practices (authored by kgaillot).Aug 22 2022, 4:01 PM

Merged Changes

947b8c7b9575 Refactor: scheduler: use g_list_foreach() to add resource actions to graph
Author
kgaillot
Browse Repository
No Audits
266c100c1438 Refactor: scheduler: functionize adding expected result to an action
Author
kgaillot
Browse Repository
No Audits
6f8d5ba6353d Refactor: scheduler: best practices for native_create_probe()
Author
kgaillot
Browse Repository
No Audits
908f3169978c Refactor: scheduler: functionize creating a probe action
Author
kgaillot
Browse Repository
No Audits
bc75936f5e97 Refactor: scheduler: functionize checking whether guest will stop
Author
kgaillot
Browse Repository
No Audits
ba9215d1dba0 Refactor: scheduler: functionize ordering start after probe
Author
kgaillot
Browse Repository
No Audits
3c23591908d5 Refactor: scheduler: functionize creating probes for a list of resources
Author
kgaillot
Browse Repository
No Audits
f8c760dfa4c6 Refactor: scheduler: functionize adding expected probe result
Author
kgaillot
Browse Repository
No Audits
f07dd1330541 Refactor: scheduler: move native_create_probe()
Author
kgaillot
Browse Repository
No Audits
2ae76f0e8141 Refactor: scheduler: remove unused arguments to create_probe() method
Author
kgaillot
Browse Repository
No Audits
83d4504a3591 Refactor: scheduler: use bool instead of gboolean in create_probe() method
Author
kgaillot
Browse Repository
No Audits
118f8c2551e8 Refactor: scheduler: best practices for native_expand()
Author
kgaillot
Browse Repository
No Audits
4835333bc7be Refactor: scheduler: move native_expand()
Author
kgaillot
Browse Repository
No Audits
a36eae42b033 Refactor: scheduler: rename expand() method
Author
kgaillot
Browse Repository
No Audits
d614bcd16ba8 Refactor: scheduler: drop group_expand()
Author
kgaillot
Browse Repository
No Audits

Changes (11)

Path

Size

include/

crm/

pengine/

internal.h

pcmki/

pcmki_sched_allocate.h

lib/

pacemaker/

libpacemaker_private.h

pcmk_graph_producer.c

pcmk_sched_resource.c

pengine/

pe_actions.c

rPd63aea900772

View Options

include/crm/pengine/internal.h

View Options

include/pcmki/pcmki_sched_allocate.h

View Options

lib/pacemaker/libpacemaker_private.h

View Options

lib/pacemaker/pcmk_graph_producer.c

View Options

lib/pacemaker/pcmk_sched_bundle.c

View Options

lib/pacemaker/pcmk_sched_clone.c

View Options

lib/pacemaker/pcmk_sched_group.c

View Options

lib/pacemaker/pcmk_sched_native.c

View Options

lib/pacemaker/pcmk_sched_probes.c

View Options

lib/pacemaker/pcmk_sched_resource.c

View Options

Merge pull request #2809 from kgaillot/best-practicesd63aea900772Actions

Description

Details

Event Timeline

Merged Changes

Changes (11)

rPd63aea900772

include/crm/pengine/internal.h

include/pcmki/pcmki_sched_allocate.h

lib/pacemaker/libpacemaker_private.h

lib/pacemaker/pcmk_graph_producer.c

lib/pacemaker/pcmk_sched_bundle.c

lib/pacemaker/pcmk_sched_clone.c

lib/pacemaker/pcmk_sched_group.c

lib/pacemaker/pcmk_sched_native.c

lib/pacemaker/pcmk_sched_probes.c

lib/pacemaker/pcmk_sched_resource.c

lib/pengine/pe_actions.c

Merge pull request #2809 from kgaillot/best-practices
d63aea900772
Actions