Merge pull request #2137 from clumens/strings
052b776f1866
Actions

Description

Merge pull request #2137 from clumens/strings

Start refactoring string functions

Details

Provenance

kgaillot	Authored on Aug 13 2020, 4:28 PM
GitHub <noreply@github.com>	Committed on Aug 13 2020, 4:28 PM

Parents

rPd9b6a68f1e76: Fix: libcrmcommon: Add doxygen blocks to string functions.
rP6279b85e34a8: Merge pull request #2138 from clumens/message-matching

Branches

Unknown

Tags

Unknown

Event Timeline

Merged Changes

d9b6a68f1e76 Fix: libcrmcommon: Add doxygen blocks to string functions.
Author
clumens
Browse Repository
No Audits
36fe7008bbe5 Refactor: daemons, lib, tools: Use pcmk__str_any_of more.
Author
clumens
Browse Repository
No Audits
14b52a707013 Fix: daemons, lib, tools: Correct comparisons to string functions.
Author
clumens
Browse Repository
No Audits
18a7ee8d1a80 Refactor: daemons, lib, tools: Rename pcmk__str_any_of.
Author
clumens
Browse Repository
No Audits
1d3ce85f01a4 Refactor: libs: Deprecate crm_str_eq, safe_str_eq, and safe_str_neq.
Author
clumens
Browse Repository
No Audits
8c493d85e1e3 Refactor: daemons, lib, tools: Replace crm_str_eq.
Author
clumens
Browse Repository
No Audits
e468a17f1f73 Refactor: daemons, lib, tools: Replace safe_str_eq.
Author
clumens
Browse Repository
No Audits
ba38d4900266 Refactor: include: Use strcasecmp in crm_action_str.
Author
clumens
Browse Repository
No Audits
f13e39d4bd73 Refactor: daemons, lib, tools: Replace safe_str_neq.
Author
clumens
Browse Repository
No Audits
c264a161b505 Devel: coccinelle: Add a cocci file to catch uses of old string functions.
Author
clumens
Browse Repository
No Audits
b48681fa6a1a Refactor: daemons, libs, tools: Use pcmk__str_null_matches where possible.
Author
clumens
Browse Repository
No Audits
dcf02bbc2676 Feature: libcrmcommon: Add pcmk__strcmp.
Author
clumens
Browse Repository
No Audits
69173b57254c Refactor: daemons, lib: Remove pcmk__str_none_of.
Author
clumens
Browse Repository
No Audits
d916dd47455f Refactor: libcrmcommon: Move string functions to their own header file.
Author
clumens
Browse Repository
No Audits

Changes (140)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

Path

Size

.gitignore

daemons/

attrd/

based/

controld/

controld_execd_state.c

controld_fencing.c

controld_join_client.c

controld_join_dc.c

controld_membership.c

controld_messages.c

controld_metadata.c

controld_remote_ra.c

controld_te_actions.c

controld_te_callbacks.c

controld_te_events.c

controld_te_utils.c

controld_transition.c

execd/

fenced/

pacemakerd/

schedulerd/

pacemaker-schedulerd.c

devel/

Makefile.am

coccinelle/

string-any-of.cocci

string-null-matches.cocci

string-replacements.cocci

include/

crm/

common/

lib/

cib/

cluster/

common/

tests/

strings/

fencing/

lrmd/

pacemaker/

pcmk_sched_allocate.c

pcmk_sched_bundle.c

pcmk_sched_clone.c

pcmk_sched_constraints.c

pcmk_sched_promotable.c

pcmk_sched_transition.c

pcmk_sched_utilization.c

pengine/

services/

maint/

mocked/

tools/

crm_resource_runtime.c

rP052b776f1866

View Options

.gitignore

Load File

View Options

daemons/attrd/attrd_alerts.c

Load File

View Options

daemons/attrd/attrd_commands.c

Load File

View Options

daemons/attrd/attrd_elections.c

Load File

View Options

daemons/attrd/pacemaker-attrd.c

Load File

View Options

daemons/based/based_callbacks.c

Load File

View Options

daemons/based/based_common.c

Load File

View Options

daemons/based/based_messages.c

Load File

View Options

daemons/based/based_notify.c

Load File

View Options

daemons/based/based_remote.c

Load File

View Options

daemons/based/pacemaker-based.c

Load File

View Options

daemons/controld/controld_based.c

Load File

View Options

daemons/controld/controld_callbacks.c

Load File

View Options

daemons/controld/controld_control.c

Load File

View Options

daemons/controld/controld_election.c

Load File

View Options

daemons/controld/controld_execd.c

Load File

View Options

daemons/controld/controld_execd_state.c

Load File

View Options

daemons/controld/controld_fencing.c

Load File

View Options

daemons/controld/controld_join_client.c

Load File

View Options

daemons/controld/controld_join_dc.c

Load File

View Options

daemons/controld/controld_membership.c

Load File

View Options

daemons/controld/controld_messages.c

Load File

View Options

daemons/controld/controld_metadata.c

Load File

View Options

daemons/controld/controld_remote_ra.c

Load File

View Options

daemons/controld/controld_te_actions.c

Load File

View Options

daemons/controld/controld_te_callbacks.c

Load File

View Options

daemons/controld/controld_te_events.c

Load File

View Options

daemons/controld/controld_te_utils.c

Load File

View Options

daemons/controld/controld_transition.c

Load File

View Options

daemons/controld/controld_utils.c

Load File

View Options

daemons/controld/pacemaker-controld.c

Load File

View Options

daemons/execd/cts-exec-helper.c

Load File

View Options

daemons/execd/execd_commands.c

Load File

View Options

daemons/execd/pacemaker-execd.c

Load File

View Options

daemons/execd/remoted_proxy.c

Load File

View Options

daemons/fenced/fenced_commands.c

Load File

View Options

daemons/fenced/fenced_history.c

Load File

View Options

daemons/fenced/fenced_remote.c

Load File

View Options

daemons/fenced/pacemaker-fenced.c

Load File

View Options

daemons/pacemakerd/pacemakerd.c

Load File

View Options

daemons/schedulerd/pacemaker-schedulerd.c

Load File

View Options

devel/Makefile.am

Load File

View Options

devel/coccinelle/string-any-of.cocci

Load File

View Options

devel/coccinelle/string-null-matches.cocci

Load File

View Options

devel/coccinelle/string-replacements.cocci

Load File

View Options

include/crm/common/Makefile.am

Load File

View Options

include/crm/common/internal.h

Load File

View Options

include/crm/common/strings_internal.h

Load File

View Options

include/crm/common/util.h

Load File

View Options

include/crm/common/xml.h

Load File

View Options

include/crm/compatibility.h

Load File

View Options

include/crm/crm.h

Load File

View Options

include/crm/services.h

Load File

View Options

lib/cib/cib_attrs.c

Load File

View Options

lib/cib/cib_client.c

Load File

View Options

lib/cib/cib_file.c

Load File

View Options

lib/cib/cib_native.c

Load File

View Options

lib/cib/cib_ops.c

Load File

View Options

lib/cib/cib_remote.c

Load File

View Options

lib/cib/cib_utils.c

Load File

View Options

lib/cluster/cluster.c

Load File

View Options

lib/cluster/corosync.c

Load File

View Options

lib/cluster/cpg.c

Load File

View Options

lib/cluster/election.c

Load File

View Options

lib/cluster/membership.c

Load File

View Options

lib/common/attrd_client.c

Load File

View Options

lib/common/cib_secrets.c

Load File

View Options

lib/common/cmdline.c

Load File

View Options

lib/common/digest.c

Load File

View Options

lib/common/ipc_controld.c

Load File

View Options

lib/common/ipc_pacemakerd.c

Load File

View Options

lib/common/logging.c

Load File

View Options

lib/common/operations.c

Load File

View Options

lib/common/options.c

Load File

View Options

lib/common/output.c

Load File

View Options

lib/common/procfs.c

Load File

View Options

lib/common/schemas.c

Load File

View Options

lib/common/strings.c

Load File

View Options

lib/common/tests/strings/Makefile.am

Load File

View Options

lib/common/tests/strings/pcmk__str_any_of.c

Load File

View Options

lib/common/tests/strings/pcmk__str_none_of.c

Load File

View Options

lib/common/tests/strings/pcmk__strcmp.c

Load File

View Options

lib/common/utils.c

Load File

View Options

lib/common/watchdog.c

Load File

View Options

lib/common/xml.c

Load File

View Options

lib/fencing/st_client.c

Load File

View Options

lib/fencing/st_rhcs.c

Load File

View Options

lib/lrmd/lrmd_alerts.c

Load File

View Options

lib/lrmd/lrmd_client.c

Load File

View Options

lib/lrmd/proxy_common.c

Load File

View Options

lib/pacemaker/pcmk_fence.c

Load File

View Options

lib/pacemaker/pcmk_sched_allocate.c

Load File

View Options

lib/pacemaker/pcmk_sched_bundle.c

Load File

View Options

lib/pacemaker/pcmk_sched_clone.c

Load File

View Options

lib/pacemaker/pcmk_sched_constraints.c

Load File

View Options

lib/pacemaker/pcmk_sched_graph.c

Load File

View Options

lib/pacemaker/pcmk_sched_group.c

Load File

View Options

lib/pacemaker/pcmk_sched_native.c

Load File

View Options

lib/pacemaker/pcmk_sched_notif.c

Load File

View Options

lib/pacemaker/pcmk_sched_promotable.c

Load File

View Options

lib/pacemaker/pcmk_sched_transition.c

Load File

View Options

lib/pacemaker/pcmk_sched_utilization.c

Load File

View Options

lib/pacemaker/pcmk_sched_utils.c

Load File

View Options

lib/pacemaker/pcmk_trans_graph.c

Load File

View Options

lib/pacemaker/pcmk_trans_unpack.c

Load File

View Options

lib/pengine/bundle.c

Load File

View Options

lib/pengine/clone.c

Load File

View Options

lib/pengine/common.c

Load File

View Options

lib/pengine/complex.c

Load File

View Options

lib/pengine/failcounts.c

Load File

View Options

lib/pengine/group.c

Load File

View Options

lib/pengine/native.c

Load File

View Options

lib/pengine/pe_output.c

Load File

View Options

lib/pengine/remote.c

Load File

View Options

lib/pengine/rules.c

Load File

View Options

lib/pengine/status.c

Load File

View Options

lib/pengine/unpack.c

Load File

View Options

lib/pengine/utils.c

Load File

View Options

lib/services/dbus.c

Load File

View Options

lib/services/services.c

Load File

View Options

lib/services/services_linux.c

Load File

View Options

lib/services/systemd.c

Load File

View Options

lib/services/upstart.c

Load File

View Options

maint/mocked/based-notifyfenced.c

Load File

View Options

tools/attrd_updater.c

Load File

View Options

tools/cibadmin.c

Load File

View Options

tools/crm_attribute.c

Load File

View Options

tools/crm_error.c

Load File

View Options

tools/crm_mon.c

Load File

View Options

tools/crm_mon_print.c

Load File

View Options

tools/crm_node.c

Load File

View Options

tools/crm_resource.c

Load File

View Options

tools/crm_resource_print.c

Load File

View Options

tools/crm_resource_runtime.c

Load File

View Options

tools/crm_rule.c

Load File

View Options

tools/crm_shadow.c

Load File

View Options

tools/crm_simulate.c

Load File

View Options

tools/crm_ticket.c

Load File

View Options

tools/crm_verify.c

Load File

View Options

tools/iso8601.c

Load File

Merge pull request #2137 from clumens/strings052b776f1866Actions

Description

Details

Event Timeline

Merged Changes

Changes (140)Show All Changes

Very Large Commit

rP052b776f1866

.gitignore

daemons/attrd/attrd_alerts.c

daemons/attrd/attrd_commands.c

daemons/attrd/attrd_elections.c

daemons/attrd/pacemaker-attrd.c

daemons/based/based_callbacks.c

daemons/based/based_common.c

daemons/based/based_messages.c

daemons/based/based_notify.c

daemons/based/based_remote.c

daemons/based/pacemaker-based.c

daemons/controld/controld_based.c

daemons/controld/controld_callbacks.c

daemons/controld/controld_control.c

daemons/controld/controld_election.c

daemons/controld/controld_execd.c

daemons/controld/controld_execd_state.c

daemons/controld/controld_fencing.c

daemons/controld/controld_join_client.c

daemons/controld/controld_join_dc.c

daemons/controld/controld_membership.c

daemons/controld/controld_messages.c

daemons/controld/controld_metadata.c

daemons/controld/controld_remote_ra.c

daemons/controld/controld_te_actions.c

daemons/controld/controld_te_callbacks.c

daemons/controld/controld_te_events.c

daemons/controld/controld_te_utils.c

daemons/controld/controld_transition.c

daemons/controld/controld_utils.c

daemons/controld/pacemaker-controld.c

daemons/execd/cts-exec-helper.c

daemons/execd/execd_commands.c

daemons/execd/pacemaker-execd.c

daemons/execd/remoted_proxy.c

daemons/fenced/fenced_commands.c

daemons/fenced/fenced_history.c

daemons/fenced/fenced_remote.c

daemons/fenced/pacemaker-fenced.c

daemons/pacemakerd/pacemakerd.c

daemons/schedulerd/pacemaker-schedulerd.c

devel/Makefile.am

devel/coccinelle/string-any-of.cocci

devel/coccinelle/string-null-matches.cocci

devel/coccinelle/string-replacements.cocci

include/crm/common/Makefile.am

include/crm/common/internal.h

include/crm/common/strings_internal.h

include/crm/common/util.h

include/crm/common/xml.h

include/crm/compatibility.h

include/crm/crm.h

include/crm/services.h

lib/cib/cib_attrs.c

lib/cib/cib_client.c

lib/cib/cib_file.c

lib/cib/cib_native.c

lib/cib/cib_ops.c

lib/cib/cib_remote.c

lib/cib/cib_utils.c

lib/cluster/cluster.c

lib/cluster/corosync.c

lib/cluster/cpg.c

lib/cluster/election.c

lib/cluster/membership.c

lib/common/attrd_client.c

lib/common/cib_secrets.c

lib/common/cmdline.c

lib/common/digest.c

lib/common/ipc_controld.c

lib/common/ipc_pacemakerd.c

lib/common/logging.c

Merge pull request #2137 from clumens/strings
052b776f1866
Actions

Changes (140)
Show All Changes