Merge pull request #2793 from clumens/easy-tests
71d8af5c0bb0
Actions

Description

Merge pull request #2793 from clumens/easy-tests

Additional easy unit tests

Details

Provenance

kgaillot	Authored on Aug 16 2022, 5:43 PM
GitHub <noreply@github.com>	Committed on Aug 16 2022, 5:43 PM

Parents

rP4b7c249972ee: Merge pull request #2799 from kgaillot/best-practices
rP9ca6af8a1e87: doc: Pacemaker Development: Mention requiring -lcmocka.

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP71d8af5c0bb0: Merge pull request #2793 from clumens/easy-tests (authored by kgaillot).Aug 16 2022, 5:43 PM

Merged Changes

9ca6af8a1e87 doc: Pacemaker Development: Mention requiring -lcmocka.
Author
clumens
Browse Repository
No Audits
84a5f9c120b4 Test: libcrmcommon: Exclude mock.c from test coverage.
Author
clumens
Browse Repository
No Audits
ed05cc21190a Test: libcrmcommon: Add tests for the rest of agents.c.
Author
clumens
Browse Repository
No Audits
6c77fc2e0a9d Low: daemons: Correct an error message.
Author
clumens
Browse Repository
No Audits
69ddf891ae51 Low: libcrmcommon: crm_generate_ra_key should fail if std or key are missing.
Author
clumens
Browse Repository
No Audits
6e688db6f398 Test: libcrmcommon: Add a unit test for pcmk__s.
Author
clumens
Browse Repository
No Audits
192cee7ba082 Test: libcrmcommon: Add a unit test for pcmk__getpid_s.
Author
clumens
Browse Repository
No Audits
aec9eb450f4a Test: libcrmcommon: Add a mocked version of getpid.
Author
clumens
Browse Repository
No Audits
d4358b0f9a6b Test: libcrmcommon: Add unit tests for very basic list macros.
Author
clumens
Browse Repository
No Audits

Changes (18)

Path

Size

daemons/

controld/

controld_metadata.c

doc/

sphinx/

Pacemaker_Development/

helpers.rst

lib/

common/

agents.c

mock.c

mock_private.h

tests/

agents/

Makefile.am

crm_generate_ra_key_test.c

crm_parse_agent_spec_test.c

pcmk__effective_rc_test.c

pcmk_get_ra_caps_test.c

lists/

Makefile.am

pcmk__list_of_1_test.c

pcmk__list_of_multiple_test.c

strings/

Makefile.am

	strings/
	procfs/

	pcmk__s_test.c
	pcmk__procfs_has_pids_true_test.c

utils/

Makefile.am

	utils/
	procfs/

	pcmk__getpid_s_test.c
	pcmk__procfs_has_pids_true_test.c

mk/

tap.mk

rP71d8af5c0bb0

View Options

daemons/controld/controld_metadata.c

View Options

doc/sphinx/Pacemaker_Development/helpers.rst

View Options

lib/common/agents.c

View Options

lib/common/mock.c

View Options

lib/common/mock_private.h

View Options

lib/common/tests/agents/Makefile.am

View Options

lib/common/tests/agents/crm_generate_ra_key_test.c

View Options

lib/common/tests/agents/crm_parse_agent_spec_test.c

View Options

lib/common/tests/agents/pcmk__effective_rc_test.c

View Options

lib/common/tests/agents/pcmk_get_ra_caps_test.c

View Options

lib/common/tests/lists/Makefile.am

View Options

lib/common/tests/lists/pcmk__list_of_1_test.c

View Options

lib/common/tests/lists/pcmk__list_of_multiple_test.c

View Options

lib/common/tests/strings/Makefile.am

View Options

lib/common/tests/strings/pcmk__s_test.c

View Options

lib/common/tests/utils/Makefile.am

View Options

lib/common/tests/utils/pcmk__getpid_s_test.c

View Options

Merge pull request #2793 from clumens/easy-tests71d8af5c0bb0Actions

Description

Details

Event Timeline

Merged Changes

Changes (18)

rP71d8af5c0bb0

daemons/controld/controld_metadata.c

doc/sphinx/Pacemaker_Development/helpers.rst

lib/common/agents.c

lib/common/mock.c

lib/common/mock_private.h

lib/common/tests/agents/Makefile.am

lib/common/tests/agents/crm_generate_ra_key_test.c

lib/common/tests/agents/crm_parse_agent_spec_test.c

lib/common/tests/agents/pcmk__effective_rc_test.c

lib/common/tests/agents/pcmk_get_ra_caps_test.c

lib/common/tests/lists/Makefile.am

lib/common/tests/lists/pcmk__list_of_1_test.c

lib/common/tests/lists/pcmk__list_of_multiple_test.c

lib/common/tests/strings/Makefile.am

lib/common/tests/strings/pcmk__s_test.c

lib/common/tests/utils/Makefile.am

lib/common/tests/utils/pcmk__getpid_s_test.c

mk/tap.mk

Merge pull request #2793 from clumens/easy-tests
71d8af5c0bb0
Actions