Merge pull request #2729 from kgaillot/best-practices
71efc755f472
Actions

Description

Merge pull request #2729 from kgaillot/best-practices

Miscellaneous refactors

Details

Provenance

kgaillot	Authored on Jun 9 2022, 3:39 PM
GitHub <noreply@github.com>	Committed on Jun 9 2022, 3:39 PM

Parents

rPa44dc3fb489a: Merge pull request #2703 from chrissie-c/fenced-updates
rP480a5e8f1791: Refactor: libpacemaker,libcrmcommon: move pcmk__new_logger()

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rP71efc755f472: Merge pull request #2729 from kgaillot/best-practices (authored by kgaillot).Jun 9 2022, 3:39 PM

Merged Changes

480a5e8f1791 Refactor: libpacemaker,libcrmcommon: move pcmk__new_logger()
Author
kgaillot
Browse Repository
No Audits
3989c0445ef8 Low: libcrmcommon: finish XML for libpacemaker public API function errors
Author
kgaillot
Browse Repository
No Audits
9271853b75e3 Refactor: libcrmcommon: rename pcmk__out_prologue()
Author
kgaillot
Browse Repository
No Audits
a4bb5a7df3a3 Refactor: libpacemaker,libcrmcommon: move XML output prologue/epilogue functions
Author
kgaillot
Browse Repository
No Audits
54101a6a4bf6 API: libcrmcommon: deprecate XML_PARANOIA_CHECKS
Author
kgaillot
Browse Repository
No Audits
f6edaf42e93a API: libcrmcommon: deprecate crm_ipc_server_info
Author
kgaillot
Browse Repository
No Audits
cb6146254089 API: libcrmcommon: deprecate crm_ipc_server_error
Author
kgaillot
Browse Repository
No Audits
cc8afc17ef40 API: libcrmcommon: add CRM_EX_NONE
Author
kgaillot
Browse Repository
No Audits
bd50b890f498 API: libcrmcommon: add CRM_EX_FAILED_PROMOTED
Author
kgaillot
Browse Repository
No Audits
90290791c8fe API: libcrmcommon: add CRM_EX_PROMOTED
Author
kgaillot
Browse Repository
No Audits
5be9dc7ab8c5 Refactor: libcrmcommon,liblrmd: avoid gettimeofday()
Author
kgaillot
Browse Repository
No Audits
27a589583b80 Refactor: libcrmcommon: make crm_errno2exit() unusable internally
Author
kgaillot
Browse Repository
No Audits
5120de42006b Refactor: tools: avoid using crm_errno2exit() internally
Author
kgaillot
Browse Repository
No Audits
e7cb3e832d3e Refactor: libcrmcommon: functionize checking procfs pid capability
Author
kgaillot
Browse Repository
No Audits
372b24970f24 Refactor: libcrmcommon: functionize getting executable path for a PID
Author
kgaillot
Browse Repository
No Audits
03ed97c596d4 Refactor: libcrmcommon: make pcmk__pid_active() easier to follow
Author
kgaillot
Browse Repository
No Audits
a07c18703dcb Refactor: scheduler: make finding unfencing devices more efficient
Author
kgaillot
Browse Repository
No Audits
3c9d8e50239e Refactor: scheduler: functionize unpacking "requires" meta-attribute
Author
kgaillot
Browse Repository
No Audits
5a1c4361a7ac Refactor: all: use constants for possible "requires" values
Author
kgaillot
Browse Repository
No Audits

Changes (37)

Path

Size

daemons/

fenced/

fenced_commands.c

pacemaker-fenced.c

schedulerd/

pacemaker-schedulerd.c

include/

crm/

common/

	results_compat.h
	mainloop_compat.h

xml.h

xml_compat.h

pcmki/

pcmki_output.h

lib/

common/

lrmd/

pacemaker/

pcmk_cluster_queries.c

pcmk_fence.c

pcmk_output_utils.c

pcmk_resource.c

pcmk_sched_allocate.c

pengine/

tools/

rP71efc755f472

View Options

daemons/fenced/fenced_commands.c

View Options

daemons/fenced/pacemaker-fenced.c

View Options

daemons/schedulerd/pacemaker-schedulerd.c

View Options

include/crm/common/Makefile.am

View Options

include/crm/common/internal.h

View Options

include/crm/common/ipc.h

View Options

include/crm/common/iso8601_internal.h

View Options

include/crm/common/options_internal.h

View Options

include/crm/common/output_internal.h

View Options

include/crm/common/results.h

View Options

include/crm/common/results_compat.h

View Options

include/crm/common/xml.h

View Options

include/crm/common/xml_compat.h

View Options

include/pcmki/pcmki_output.h

View Options

lib/common/iso8601.c

View Options

lib/common/nvpair.c

View Options

lib/common/output.c

View Options

lib/common/pid.c

View Options

lib/common/procfs.c

View Options

lib/common/results.c

View Options

lib/lrmd/lrmd_alerts.c

View Options

lib/pacemaker/Makefile.am

View Options

lib/pacemaker/pcmk_cluster_queries.c

View Options

lib/pacemaker/pcmk_fence.c

View Options

lib/pacemaker/pcmk_output_utils.c

View Options

lib/pacemaker/pcmk_resource.c

View Options

lib/pacemaker/pcmk_sched_allocate.c

View Options

lib/pacemaker/pcmk_simulate.c

View Options

lib/pacemaker/pcmk_status.c

View Options

lib/pengine/complex.c

View Options

lib/pengine/unpack.c

View Options

lib/pengine/utils.c

View Options

tools/cibadmin.c

View Options

tools/crm_diff.c

View Options

tools/crm_mon.c

View Options

tools/crm_rule.c

View Options

Merge pull request #2729 from kgaillot/best-practices71efc755f472Actions

Description

Details

Event Timeline

Merged Changes

Changes (37)

rP71efc755f472

daemons/fenced/fenced_commands.c

daemons/fenced/pacemaker-fenced.c

daemons/schedulerd/pacemaker-schedulerd.c

include/crm/common/Makefile.am

include/crm/common/internal.h

include/crm/common/ipc.h

include/crm/common/iso8601_internal.h

include/crm/common/options_internal.h

include/crm/common/output_internal.h

include/crm/common/results.h

include/crm/common/results_compat.h

include/crm/common/xml.h

include/crm/common/xml_compat.h

include/pcmki/pcmki_output.h

lib/common/iso8601.c

lib/common/nvpair.c

lib/common/output.c

lib/common/pid.c

lib/common/procfs.c

lib/common/results.c

lib/lrmd/lrmd_alerts.c

lib/pacemaker/Makefile.am

lib/pacemaker/pcmk_cluster_queries.c

lib/pacemaker/pcmk_fence.c

lib/pacemaker/pcmk_output_utils.c

lib/pacemaker/pcmk_resource.c

lib/pacemaker/pcmk_sched_allocate.c

lib/pacemaker/pcmk_simulate.c

lib/pacemaker/pcmk_status.c

lib/pengine/complex.c

lib/pengine/unpack.c

lib/pengine/utils.c

tools/cibadmin.c

tools/crm_diff.c

tools/crm_mon.c

tools/crm_rule.c

tools/crm_shadow.c

Merge pull request #2729 from kgaillot/best-practices
71efc755f472
Actions