Merge pull request #2745 from kgaillot/best-practices
c791e26c40bf
Actions

Description

Merge pull request #2745 from kgaillot/best-practices

Move some functions from pcmk_sched_clone.c elsewhere

Details

Provenance

kgaillot	Authored on Jun 28 2022, 4:56 PM
GitHub <noreply@github.com>	Committed on Jun 28 2022, 4:56 PM

Parents

rP36c59409993d: Merge pull request #2744 from clumens/attr-atomic
rP448726048d95: Fix: scheduler: restore line dropped by 34209e2e63

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPc791e26c40bf: Merge pull request #2745 from kgaillot/best-practices (authored by kgaillot).Jun 28 2022, 4:56 PM

Merged Changes

448726048d95 Fix: scheduler: restore line dropped by 34209e2e63
Author
kgaillot
Browse Repository
No Audits
8accb627edd5 Refactor: scheduler: drop pcmk__is_unfence_device()
Author
kgaillot
Browse Repository
No Audits
e487d0b2412c Refactor: scheduler: drop redundant resource/node arguments
Author
kgaillot
Browse Repository
No Audits
6572d8e9a3e3 Test: cts-scheduler: update expected scores for instance sorting change
Author
kgaillot
Browse Repository
No Audits
a0feb2e25d84 Low: scheduler: don't prefer greater anti-colocation when ordering instances…
Author
kgaillot
Browse Repository
No Audits
1cfdc9cfdf94 Refactor: scheduler: remove dead code
Author
kgaillot
Browse Repository
No Audits
2e4fbf24c3a4 Test: cts-scheduler: update scores for instance number change
Author
kgaillot
Browse Repository
No Audits
4a59702123ea Low: scheduler: compare instance numbers not IDs for assignment order
Author
kgaillot
Browse Repository
No Audits
c7de34ec3513 Refactor: scheduler: expose instance number comparator in libpacemaker
Author
kgaillot
Browse Repository
No Audits
b30beaf9f86a Refactor: scheduler: best practices when sorting instances
Author
kgaillot
Browse Repository
No Audits
34209e2e63c1 Refactor: scheduler: functionize checking whether node is allowed
Author
kgaillot
Browse Repository
No Audits
fdc592c4f062 Refactor: scheduler: best practices when checking whether resource failed
Author
kgaillot
Browse Repository
No Audits
9e150fa323f7 Refactor: scheduler: drop unused argument from pcmk__cmp_instance()
Author
kgaillot
Browse Repository
No Audits
11b36b660d35 Refactor: scheduler: best practices when sorting instances by colocation scores
Author
kgaillot
Browse Repository
No Audits
4c388d665079 Refactor: scheduler: functionize applying parent's colocation scores
Author
kgaillot
Browse Repository
No Audits
5c1cab317f93 Refactor: scheduler: functionize creating a hash table with one node
Author
kgaillot
Browse Repository
No Audits
a2de15a8bf55 Refactor: scheduler: rename sort_clone_instance()
Author
kgaillot
Browse Repository
No Audits
e484f6d19ed4 Refactor: scheduler: best practices for parent_node_instance()
Author
kgaillot
Browse Repository
No Audits

Changes (24)

Path

Size

cts/

scheduler/

scores/

a-demote-then-b-migrate.scores

bug-lf-2574.scores

bundle-order-stop-clone.scores

coloc-clone-stays-active.scores

promoted-partially-demoted-group.scores

rec-node-13.scores

stonith-0.scores

stonith-2.scores

include/

pcmki/

pcmki_resource.h

lib/

pacemaker/

libpacemaker_private.h

pcmk_graph_producer.c

pcmk_resource.c

pcmk_sched_actions.c

pcmk_sched_allocate.c

pcmk_sched_promotable.c

pcmk_sched_remote.c

pcmk_sched_resource.c

pcmk_sched_utilization.c

tools/

crm_resource.c

rPc791e26c40bf

View Options

cts/scheduler/scores/a-demote-then-b-migrate.scores

View Options

cts/scheduler/scores/bug-lf-2574.scores

View Options

cts/scheduler/scores/bundle-order-stop-clone.scores

View Options

cts/scheduler/scores/coloc-clone-stays-active.scores

View Options

cts/scheduler/scores/promoted-partially-demoted-group.scores

View Options

cts/scheduler/scores/rec-node-13.scores

View Options

cts/scheduler/scores/stonith-0.scores

View Options

cts/scheduler/scores/stonith-2.scores

View Options

include/pcmki/pcmki_resource.h

View Options

lib/pacemaker/libpacemaker_private.h

View Options

lib/pacemaker/pcmk_graph_producer.c

View Options

lib/pacemaker/pcmk_resource.c

View Options

lib/pacemaker/pcmk_sched_actions.c

View Options

lib/pacemaker/pcmk_sched_allocate.c

View Options

lib/pacemaker/pcmk_sched_bundle.c

View Options

lib/pacemaker/pcmk_sched_clone.c

View Options

lib/pacemaker/pcmk_sched_fencing.c

View Options

lib/pacemaker/pcmk_sched_native.c

View Options

lib/pacemaker/pcmk_sched_nodes.c

View Options

lib/pacemaker/pcmk_sched_promotable.c

View Options

lib/pacemaker/pcmk_sched_remote.c

View Options

lib/pacemaker/pcmk_sched_resource.c

View Options

lib/pacemaker/pcmk_sched_utilization.c

View Options

Merge pull request #2745 from kgaillot/best-practicesc791e26c40bfActions

Description

Details

Event Timeline

Merged Changes

Changes (24)

rPc791e26c40bf

cts/scheduler/scores/a-demote-then-b-migrate.scores

cts/scheduler/scores/bug-lf-2574.scores

cts/scheduler/scores/bundle-order-stop-clone.scores

cts/scheduler/scores/coloc-clone-stays-active.scores

cts/scheduler/scores/promoted-partially-demoted-group.scores

cts/scheduler/scores/rec-node-13.scores

cts/scheduler/scores/stonith-0.scores

cts/scheduler/scores/stonith-2.scores

include/pcmki/pcmki_resource.h

lib/pacemaker/libpacemaker_private.h

lib/pacemaker/pcmk_graph_producer.c

lib/pacemaker/pcmk_resource.c

lib/pacemaker/pcmk_sched_actions.c

lib/pacemaker/pcmk_sched_allocate.c

lib/pacemaker/pcmk_sched_bundle.c

lib/pacemaker/pcmk_sched_clone.c

lib/pacemaker/pcmk_sched_fencing.c

lib/pacemaker/pcmk_sched_native.c

lib/pacemaker/pcmk_sched_nodes.c

lib/pacemaker/pcmk_sched_promotable.c

lib/pacemaker/pcmk_sched_remote.c

lib/pacemaker/pcmk_sched_resource.c

lib/pacemaker/pcmk_sched_utilization.c

tools/crm_resource.c

Merge pull request #2745 from kgaillot/best-practices
c791e26c40bf
Actions