Merge pull request #2800 from clumens/output-testing
f8931800938e
Actions

Description

Merge pull request #2800 from clumens/output-testing

Unit testing for much of lib/common/output.c

Details

Provenance

kgaillot	Authored on Aug 18 2022, 11:31 AM
GitHub <noreply@github.com>	Committed on Aug 18 2022, 11:31 AM

Parents

rPc14102d7bb12: Merge pull request #2768 from waltdisgrace/t147
rP4fea1600db4a: Test: libcrmcommon: Add unit tests for pcmk__output_and_clear_error.

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rPf8931800938e: Merge pull request #2800 from clumens/output-testing (authored by kgaillot).Aug 18 2022, 11:31 AM

Merged Changes

4fea1600db4a Test: libcrmcommon: Add unit tests for pcmk__output_and_clear_error.
Author
clumens
Browse Repository
No Audits
cf66488bec53 Test: libcrmcommon: Add unit tests for pcmk__output_free.
Author
clumens
Browse Repository
No Audits
6248b604df96 Low: libcrmcommon: Don't allow out to be NULL in pcmk__output_free.
Author
clumens
Browse Repository
No Audits
a87395c96f5b Test: libcrmcommon: Add unit tests for pcmk__call_message.
Author
clumens
Browse Repository
No Audits
b34827a8db4c Low: libcrmcommon: Don't allow NULL params in pcmk__call_message.
Author
clumens
Browse Repository
No Audits
37530be4947e Test: libcrmcommon: Add unit tests for pcmk__register_messages.
Author
clumens
Browse Repository
No Audits
a337b1a9109a Test: libcrmcommon: Add unit tests for pcmk__register_message.
Author
clumens
Browse Repository
No Audits
ee3a003a8c4b Low: libcrmcommon: Don't allow NULL params on pcmk__register_message.
Author
clumens
Browse Repository
No Audits
2eba66842e0b Test: libcrmcommon: Add unit tests for pcmk__output_new.
Author
clumens
Browse Repository
No Audits
8ff238cfad10 Test: libcrmcommon: Add a mock wrapper for fopen.
Author
clumens
Browse Repository
No Audits
7635b706a23b Low: libcrmcommon: Free the output object if fopen fails.
Author
clumens
Browse Repository
No Audits
2e53b97bc2c0 Low: libcrmcommon: Don't allow a NULL out param in pcmk__output_new.
Author
clumens
Browse Repository
No Audits
cf059d09f37c Test: libcrmcommon: Add unit tests for pcmk__unregister_formats.
Author
clumens
Browse Repository
No Audits
90505aac06ef Test: libcrmcommon: Add unit tests for pcmk__register_formats.
Author
clumens
Browse Repository
No Audits
51979917e124 Low: libcrmcommon: Set formatters to NULL after freeing it.
Author
clumens
Browse Repository
No Audits
0bc6f25a68a2 Test: libcrmcommon: Add unit tests for pcmk__register_format.
Author
clumens
Browse Repository
No Audits
87429715f612 Low: libcrmcommon: Don't allow registering a format with an empty name.
Author
clumens
Browse Repository
No Audits
4b60a9e79eec Test: libcrmcommon: Add a special pcmk__output_formatters function.
Author
clumens
Browse Repository
No Audits
bd3ba9268983 Refactor: libcrmcommon: Change a return value in pcmk__register_format.
Author
clumens
Browse Repository
No Audits
408aad590a21 Fix: libcrmcommon: Remove an extraneous colon.
Author
clumens
Browse Repository
No Audits
dbcbd117c90c Low: libcrmcommon: Assert in more output-related functions.
Author
clumens
Browse Repository
No Audits

Changes (23)

Path

Size

configure.ac

include/

crm/

common/

output_internal.h

lib/

common/

tests/

pcmk__call_message_test.c

pcmk__output_and_clear_error_test.c

pcmk__output_free_test.c

pcmk__output_new_test.c

pcmk__register_format_test.c

pcmk__register_formats_test.c

pcmk__register_message_test.c

pcmk__register_messages_test.c

pcmk__unregister_formats_test.c

	output/
	acl/

Makefile.am

mk/

tap.mk

tools/

crm_mon_curses.c

rPf8931800938e

View Options

configure.ac

View Options

include/crm/common/output_internal.h

View Options

lib/common/mock.c

View Options

lib/common/mock_private.h

View Options

lib/common/output.c

View Options

lib/common/output_html.c

View Options

lib/common/output_log.c

View Options

lib/common/output_text.c

View Options

lib/common/output_xml.c

View Options

lib/common/tests/Makefile.am

View Options

lib/common/tests/output/Makefile.am

View Options

lib/common/tests/output/pcmk__call_message_test.c

View Options

lib/common/tests/output/pcmk__output_and_clear_error_test.c

View Options

lib/common/tests/output/pcmk__output_free_test.c

View Options

lib/common/tests/output/pcmk__output_new_test.c

View Options

lib/common/tests/output/pcmk__register_format_test.c

View Options

lib/common/tests/output/pcmk__register_formats_test.c

View Options

lib/common/tests/output/pcmk__register_message_test.c

View Options

lib/common/tests/output/pcmk__register_messages_test.c

View Options

lib/common/tests/output/pcmk__unregister_formats_test.c

View Options

mk/tap.mk

View Options

Merge pull request #2800 from clumens/output-testingf8931800938eActions

Description

Details

Event Timeline

Merged Changes

Changes (23)

rPf8931800938e

configure.ac

include/crm/common/output_internal.h

lib/common/mock.c

lib/common/mock_private.h

lib/common/output.c

lib/common/output_html.c

lib/common/output_log.c

lib/common/output_text.c

lib/common/output_xml.c

lib/common/tests/Makefile.am

lib/common/tests/output/Makefile.am

lib/common/tests/output/pcmk__call_message_test.c

lib/common/tests/output/pcmk__output_and_clear_error_test.c

lib/common/tests/output/pcmk__output_free_test.c

lib/common/tests/output/pcmk__output_new_test.c

lib/common/tests/output/pcmk__register_format_test.c

lib/common/tests/output/pcmk__register_formats_test.c

lib/common/tests/output/pcmk__register_message_test.c

lib/common/tests/output/pcmk__register_messages_test.c

lib/common/tests/output/pcmk__unregister_formats_test.c

mk/tap.mk

tools/crm_mon_curses.c

Merge pull request #2800 from clumens/output-testing
f8931800938e
Actions