Page MenuHomeClusterLabs Projects
Feed All Stories

Yesterday

clumens added a comment to T1004: Investigate timeouts in executor regression tests.

These same failures occur on RHEL-8 (to be fair, with my I_PE_CALC reduction patch but still...) so maybe this is not a problem.

Fri, Oct 31, 3:09 PM · Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rP5e468a97f245: Merge pull request #3976 from clumens/gio-eagain (authored by clumens).
Merge pull request #3976 from clumens/gio-eagain
Fri, Oct 31, 3:02 PM
clumens committed rP020be3d46f0c: Low: libcrmcommon: Loop on EAGAIN in mainloop_gio_callback. (authored by clumens).
Low: libcrmcommon: Loop on EAGAIN in mainloop_gio_callback.
Fri, Oct 31, 3:02 PM
clumens triaged T1004: Investigate timeouts in executor regression tests as High priority.
Fri, Oct 31, 11:02 AM · Restricted Project, Restricted Project
clumens triaged T1003: corosync isn't killed as part of cts regression tests as Normal priority.
Fri, Oct 31, 10:59 AM · Restricted Project
chrissie-c committed rQ8a603662496b: Fix a lot of annoying warning compiling with clang. (authored by chrissie-c).
Fix a lot of annoying warning compiling with clang.
Fri, Oct 31, 10:02 AM
jfriesse committed rC2fa679cd5ed7: configure: Remove unsupported -Wunsigned-char (authored by jfriesse).
configure: Remove unsupported -Wunsigned-char
Fri, Oct 31, 7:23 AM
jfriesse committed rC98f580b99b48: clang: Add missing void to function declarations (authored by jfriesse).
clang: Add missing void to function declarations
Fri, Oct 31, 7:23 AM
Pablo Fontanilla <pfontani@redhat.com> committed rR0114ddf83c95: Update truly active resources count with safer empty calculation (authored by Pablo Fontanilla <pfontani@redhat.com>).
Update truly active resources count with safer empty calculation
Fri, Oct 31, 4:42 AM
Pablo Fontanilla <pfontani@redhat.com> committed rRd5b4428e6cd6: Redo counting of active_resources (authored by Pablo Fontanilla <pfontani@redhat.com>).
Redo counting of active_resources
Fri, Oct 31, 4:42 AM
GitHub <noreply@github.com> committed rRb2947e763c8d: Merge pull request #2082 from fonta-rh/OCPBUGS-59238-fix-active-resource-count (authored by clobrano).
Merge pull request #2082 from fonta-rh/OCPBUGS-59238-fix-active-resource-count
Fri, Oct 31, 4:42 AM
clobrano committed rRe8fb2ad9cc14: podman-etcd: add container crash detection with coordinated recovery (authored by clobrano).
podman-etcd: add container crash detection with coordinated recovery
Fri, Oct 31, 4:41 AM
GitHub <noreply@github.com> committed rR45491e842d2c: Merge pull request #2089 from clobrano/enhance-container-health-check (authored by clobrano).
Merge pull request #2089 from clobrano/enhance-container-health-check
Fri, Oct 31, 4:41 AM

Tue, Oct 28

clumens committed rPb494df2c4290: Refactor: libcrmcommon: Convert the pcmk__scheduler_flags enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__scheduler_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rPa30de490fe7e: Refactor: libcrmcommon: Convert the pcmk__rsc_flags enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__rsc_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP60cf07ecf24c: Refactor: daemons: Convert the R_* controld macros... (authored by clumens).
Refactor: daemons: Convert the R_* controld macros...
Tue, Oct 28, 1:14 PM
clumens committed rP744c6b395849: Refactor: daemons: Convert the A_* controld macros... (authored by clumens).
Refactor: daemons: Convert the A_* controld macros...
Tue, Oct 28, 1:14 PM
clumens committed rP00ce89547ede: API: libcrmcommon: Convert the pcmk_section_e enum... (authored by clumens).
API: libcrmcommon: Convert the pcmk_section_e enum...
Tue, Oct 28, 1:14 PM
clumens committed rPf87be468642d: API: libcib: Convert the cib_call_options enum... (authored by clumens).
API: libcib: Convert the cib_call_options enum...
Tue, Oct 28, 1:14 PM
clumens committed rPa6c67cd2a0a3: API: libcrmcommon: Convert the pcmk_show_opt_e enum... (authored by clumens).
API: libcrmcommon: Convert the pcmk_show_opt_e enum...
Tue, Oct 28, 1:14 PM
clumens committed rPa5525eb7169f: API: libstonithd: Convert the stonith_call_options enum... (authored by clumens).
API: libstonithd: Convert the stonith_call_options enum...
Tue, Oct 28, 1:14 PM
clumens committed rP462b4f5e2351: API: libpacemaker: Convert the pcmk_sim_flags enum... (authored by clumens).
API: libpacemaker: Convert the pcmk_sim_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rPdcbfc5c51937: Refactor: libcib: Convert the cib__op_attr enum... (authored by clumens).
Refactor: libcib: Convert the cib__op_attr enum...
Tue, Oct 28, 1:14 PM
clumens committed rPf2a80b655d53: API: libpacemaker: Convert the pcmk_rc_disp_flags enum... (authored by clumens).
API: libpacemaker: Convert the pcmk_rc_disp_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP8204dbba6233: Refactor: libcrmcommon: Convert the pcmk__warnings enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__warnings enum...
Tue, Oct 28, 1:14 PM
clumens committed rP0f6b2717eb3f: Refactor: libcrmcommon: Convert the pcmk__node_attr_opts enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__node_attr_opts enum...
Tue, Oct 28, 1:14 PM
clumens committed rP883c145cb83f: Refactor: libcrmcommon: Convert the pcmk__opt_flags enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__opt_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP8689f5b44235: Refactor: libcrmcommon: Convert the pcmk__action_relation_flags enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__action_relation_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP20e9ba326092: API: libcrmcommon: Convert the pcmk_ra_caps enum... (authored by clumens).
API: libcrmcommon: Convert the pcmk_ra_caps enum...
Tue, Oct 28, 1:14 PM
clumens committed rP57ab52fa52f8: Refactor: daemons: Convert the controld_flags enum... (authored by clumens).
Refactor: daemons: Convert the controld_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP301b58279c80: Refactor: libcrmcommon: Convert the pcmk__xml_fmt_options enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__xml_fmt_options enum...
Tue, Oct 28, 1:14 PM
clumens committed rP1c8a4c8981f1: API: libcrmcommon: Convert the pe_find enum... (authored by clumens).
API: libcrmcommon: Convert the pe_find enum...
Tue, Oct 28, 1:14 PM
clumens committed rPfb932bafc344: Refactor: daemons: Convert the child_daemon_flags enum... (authored by clumens).
Refactor: daemons: Convert the child_daemon_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP910bdd14d371: Refactor: tools: Convert the resource_check_flags enum... (authored by clumens).
Refactor: tools: Convert the resource_check_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP3d6302b4d1f6: Refactor: libcrmcommon: Convert the pcmk__str_flags enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__str_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rPf9b663943625: Refactor: daemons: Convert the attrd_attr_flags enum... (authored by clumens).
Refactor: daemons: Convert the attrd_attr_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP19c63a17d06c: Refactor: scheduler: Convert the instance_state enum... (authored by clumens).
Refactor: scheduler: Convert the instance_state enum...
Tue, Oct 28, 1:14 PM
clumens committed rPac81bdcec32f: Refactor: libpacemaker: Convert the pcmk__synapse_flags enum... (authored by clumens).
Refactor: libpacemaker: Convert the pcmk__synapse_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rPea5d69eb870e: Refactor: libpacemaker: Convert the pcmk__coloc_select enum... (authored by clumens).
Refactor: libpacemaker: Convert the pcmk__coloc_select enum...
Tue, Oct 28, 1:14 PM
clumens committed rP0f5e1c5a8703: Refactor: libcib: Convert the cib_file_flags enum... (authored by clumens).
Refactor: libcib: Convert the cib_file_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP235d6217a0ec: Refactor: libpacemaker: Convert the pcmk__coloc_flags enum... (authored by clumens).
Refactor: libpacemaker: Convert the pcmk__coloc_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP27a92585a166: Refactor: libpacemaker: Convert the pcmk__updated enum... (authored by clumens).
Refactor: libpacemaker: Convert the pcmk__updated enum...
Tue, Oct 28, 1:14 PM
clumens committed rPb02d988b9c40: Refactor: daemons: Convert the remote_status enum... (authored by clumens).
Refactor: daemons: Convert the remote_status enum...
Tue, Oct 28, 1:14 PM
clumens committed rP534e89cc3648: Refactor: libpacemaker: Convert the pcmk__graph_action_flags enum... (authored by clumens).
Refactor: libpacemaker: Convert the pcmk__graph_action_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rPc10606df70e6: Refactor: libcrmcommon: Convert the pcmk__alert_flags enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__alert_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rPd005256beef7: Refactor: tools: Convert the shadow_disp_flags enum... (authored by clumens).
Refactor: tools: Convert the shadow_disp_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP978b77bfa519: Refactor: libcrmcommon: Convert the pcmk__clone_flags enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__clone_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP3157f1802bd5: Refactor: daemons: Convert the active_op_e enum... (authored by clumens).
Refactor: daemons: Convert the active_op_e enum...
Tue, Oct 28, 1:14 PM
clumens committed rP2fb7964e62ce: Refactor: daemons: Convert the attrd_write_options enum... (authored by clumens).
Refactor: daemons: Convert the attrd_write_options enum...
Tue, Oct 28, 1:14 PM
clumens committed rP5ef7b408ac66: Refactor: daemons: Convert the remote_cmd_status enum... (authored by clumens).
Refactor: daemons: Convert the remote_cmd_status enum...
Tue, Oct 28, 1:14 PM
clumens committed rPaca369278c69: Refactor: libcrmcluster: Convert the pcmk__node_search_flags enum... (authored by clumens).
Refactor: libcrmcluster: Convert the pcmk__node_search_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP677fe6982235: API: liblrmd: Convert the lrmd_call_options enum... (authored by clumens).
API: liblrmd: Convert the lrmd_call_options enum...
Tue, Oct 28, 1:14 PM
clumens committed rPfeffb5d4e085: Refactor: libcrmcommon: Convert the pcmk__group_flags enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__group_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP2e9d92669472: Refactor: libcrmcommon: Convert the pcmk__xa_flags enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__xa_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rPdde9086ff4ca: Refactor: daemons: Convert the attrd_value_flags enum... (authored by clumens).
Refactor: daemons: Convert the attrd_value_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP6ef8816327a4: Refactor: libcrmcommon: Convert the pcmk__fc_flags enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__fc_flags enum...
Tue, Oct 28, 1:14 PM
clumens committed rP07ed636a880e: Refactor: libcrmcommon: Convert the pcmk__rsc_node enum... (authored by clumens).
Refactor: libcrmcommon: Convert the pcmk__rsc_node enum...
Tue, Oct 28, 1:14 PM
clumens committed rP68822dd3f0bd: Refactor: daemons: Convert the ra_flags_e enum... (authored by clumens).
Refactor: daemons: Convert the ra_flags_e enum...
Tue, Oct 28, 1:14 PM
clumens committed rPdc4ce88c5167: Refactor: daemons: Convert the ra_param_flags_e enum... (authored by clumens).
Refactor: daemons: Convert the ra_param_flags_e enum...
Tue, Oct 28, 1:14 PM
clumens committed rPbcf1bb9ba00c: Refactor: daemons: Convert the controld_metadata_source_e enum... (authored by clumens).
Refactor: daemons: Convert the controld_metadata_source_e enum...
Tue, Oct 28, 1:14 PM
clumens committed rPcc910952cd3f: API: libcrmcommon: Convert deprecated macros... (authored by clumens).
API: libcrmcommon: Convert deprecated macros...
Tue, Oct 28, 1:14 PM
clumens committed rPd358792c6240: Refactor: daemons: Remove unused constants. (authored by clumens).
Refactor: daemons: Remove unused constants.
Tue, Oct 28, 1:14 PM
GitHub <noreply@github.com> committed rP40a23702fab0: Merge pull request #3972 from clumens/enum-refactor (authored by nrwahl2).
Merge pull request #3972 from clumens/enum-refactor
Tue, Oct 28, 1:14 PM
oalbrigt committed rRa4fd26a37b20: nfsserver: add ability to set e.g. "pipefs-directory=/run/nfs/rpc_pipefs" in… (authored by oalbrigt).
nfsserver: add ability to set e.g. "pipefs-directory=/run/nfs/rpc_pipefs" in…
Tue, Oct 28, 9:41 AM
GitHub <noreply@github.com> committed rR5c29d21f8843: Merge pull request #2065 from oalbrigt/nfsserver-rpc-gssd (authored by oalbrigt).
Merge pull request #2065 from oalbrigt/nfsserver-rpc-gssd
Tue, Oct 28, 9:41 AM
GitHub <noreply@github.com> committed rR032fcd13a9af: Filesystem: speed up get pids (#2084) (authored by Lars Ellenberg <lars.ellenberg@linbit.com>).
Filesystem: speed up get pids (#2084)
Tue, Oct 28, 9:38 AM
oalbrigt committed rR344beb18e414: portblock: add Promoted monitor op, validate-all checks, and add "method" and… (authored by oalbrigt).
portblock: add Promoted monitor op, validate-all checks, and add "method" and…
Tue, Oct 28, 9:37 AM
GitHub <noreply@github.com> committed rR1ae08db532f2: Merge pull request #2086 from oalbrigt/portblock-promotable-fixes (authored by oalbrigt).
Merge pull request #2086 from oalbrigt/portblock-promotable-fixes
Tue, Oct 28, 9:37 AM
oalbrigt committed rRdbc0d2647d73: db2: use reintegration flag to avoid race condition on cluster reintegration… (authored by oalbrigt).
db2: use reintegration flag to avoid race condition on cluster reintegration…
Tue, Oct 28, 9:36 AM
GitHub <noreply@github.com> committed rRd026358d5059: Merge pull request #2083 from oalbrigt/db2-fix-race-condition-reintegration (authored by oalbrigt).
Merge pull request #2083 from oalbrigt/db2-fix-race-condition-reintegration
Tue, Oct 28, 9:36 AM
GitHub <noreply@github.com> committed rR6a5608f02a65: podman-etcd: compute dynamic revision bump from maxRaftIndex (#2087) (authored by clobrano).
podman-etcd: compute dynamic revision bump from maxRaftIndex (#2087)
Tue, Oct 28, 8:11 AM

Thu, Oct 23

GitHub <noreply@github.com> committed rRfc3c646f9572: OCPEDGE-1502: feat: podman-etcd: add support for cert rotation (#2085) (authored by E Hila <ehila@redhat.com>).
OCPEDGE-1502: feat: podman-etcd: add support for cert rotation (#2085)
Thu, Oct 23, 3:07 AM

Tue, Oct 21

GitHub <noreply@github.com> committed rF1fcdf39b9365: Merge pull request #639 from tiredpixel/fence-hetzner-cloud (authored by oalbrigt).
Merge pull request #639 from tiredpixel/fence-hetzner-cloud
Tue, Oct 21, 10:24 AM
Nicolas Williams <tp@tiredpixel.com> committed rFb7e3ed18ed04: fence_hetzner_cloud: add new fence agent for Hetzner Cloud (authored by Nicolas Williams <tp@tiredpixel.com>).
fence_hetzner_cloud: add new fence agent for Hetzner Cloud
Tue, Oct 21, 10:24 AM

Tue, Oct 14

clumens committed rP2b214f7c2964: Low: cts: Fix the BadNews message that the ResyncCIB test ignores. (authored by clumens).
Low: cts: Fix the BadNews message that the ResyncCIB test ignores.
Tue, Oct 14, 1:27 PM
clumens committed rPf1120ce58be3: Low: cts: Remove the dummy resource at the end of the Cibsecret test. (authored by clumens).
Low: cts: Remove the dummy resource at the end of the Cibsecret test.
Tue, Oct 14, 1:27 PM
clumens committed rPd3237a14b4f4: Low: cts: Fix the BadNews messages that the SplitBrain test ignores. (authored by clumens).
Low: cts: Fix the BadNews messages that the SplitBrain test ignores.
Tue, Oct 14, 1:27 PM
clumens committed rPa4af998873a6: Refactor: cts: Unindent a block in the Scenario class. (authored by clumens).
Refactor: cts: Unindent a block in the Scenario class.
Tue, Oct 14, 1:27 PM
GitHub <noreply@github.com> committed rPcaadc9bc8cc6: Merge pull request #3973 from clumens/ctslab-fixes (authored by nrwahl2).
Merge pull request #3973 from clumens/ctslab-fixes
Tue, Oct 14, 1:27 PM

Mon, Oct 13

GitHub <noreply@github.com> committed rP13e30fab601a: Merge pull request #3974 from clumens/execd-msgs (authored by nrwahl2).
Merge pull request #3974 from clumens/execd-msgs
Mon, Oct 13, 7:38 PM
nrwahl2 committed rP694e51b1be64: Feature: libcrmcommon: Bump feature set to 3.20.5 (authored by nrwahl2).
Feature: libcrmcommon: Bump feature set to 3.20.5
Mon, Oct 13, 7:38 PM
clumens committed rP558fb8b98542: Low: daemons: Get rid of some logged warnings in execd. (authored by clumens).
Low: daemons: Get rid of some logged warnings in execd.
Mon, Oct 13, 7:38 PM
GitHub <noreply@github.com> committed rPe39a87559ea1: Merge pull request #3968 from nrwahl2/nrwahl2-T1000 (authored by clumens).
Merge pull request #3968 from nrwahl2/nrwahl2-T1000
Mon, Oct 13, 7:38 PM
nrwahl2 committed rPccd2a1047188: Refactor: based: Drop cib_is_daemon value from enum cib_client_flags (authored by nrwahl2).
Refactor: based: Drop cib_is_daemon value from enum cib_client_flags
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP1d9fb0f3d851: Refactor: based: Drop code that uses PCMK_OPT_CLUSTER_IPC_LIMIT (authored by nrwahl2).
Refactor: based: Drop code that uses PCMK_OPT_CLUSTER_IPC_LIMIT
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP797b7645af47: API: libcrmcommon: Deprecate cluster-ipc-limit cluster option (authored by nrwahl2).
API: libcrmcommon: Deprecate cluster-ipc-limit cluster option
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP7d7cd35f1a02: Test: cts-cli: Update outputs for cluster-ipc-limit deprecation (authored by nrwahl2).
Test: cts-cli: Update outputs for cluster-ipc-limit deprecation
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP8f28e71dcf44: API: libcrmcommon: Deprecate PCMK_OPT_CLUSTER_IPC_LIMIT string constant (authored by nrwahl2).
API: libcrmcommon: Deprecate PCMK_OPT_CLUSTER_IPC_LIMIT string constant
Mon, Oct 13, 2:37 PM
nrwahl2 committed rPf5bfa49732b5: API: libcrmcommon: New PCMK_OPT_CANCEL_REMOVED_ACTIONS string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_OPT_CANCEL_REMOVED_ACTIONS string constant
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP4948af664c12: Doc: Pacemaker Explained: Drop mention of cluster-ipc-limit (authored by nrwahl2).
Doc: Pacemaker Explained: Drop mention of cluster-ipc-limit
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP1454cfbdeb1d: Test: cts-cli: Update outputs for cancel-removed-actions (authored by nrwahl2).
Test: cts-cli: Update outputs for cancel-removed-actions
Mon, Oct 13, 2:37 PM
nrwahl2 committed rPdd93676440bc: Doc: Pacemaker Explained: Update docs for cancel-removed-actions (authored by nrwahl2).
Doc: Pacemaker Explained: Update docs for cancel-removed-actions
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP4cbbe5158cd1: API: libcrmcommon: Drop PCMK_OPT_STOP_REMOVED_ACTIONS (authored by nrwahl2).
API: libcrmcommon: Drop PCMK_OPT_STOP_REMOVED_ACTIONS
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP4dd03bf1fba6: API: libcrmcommon: Rename stop-removed-actions to cancel-removed-actions (authored by nrwahl2).
API: libcrmcommon: Rename stop-removed-actions to cancel-removed-actions
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP3e53a7a62f83: Feature: libcrmcommon: Deprecate enable-startup-probes cluster property (authored by nrwahl2).
Feature: libcrmcommon: Deprecate enable-startup-probes cluster property
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP7115c9c1d9d1: Test: cts-cli: Update outputs for enable-startup-probes deprecation (authored by nrwahl2).
Test: cts-cli: Update outputs for enable-startup-probes deprecation
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP30675b320a97: Doc: libpacemaker: Fix type: robes -> probes (authored by nrwahl2).
Doc: libpacemaker: Fix type: robes -> probes
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP9b314bf52ba2: Refactor: various: Drop PCMK_OPT_ENABLE_STARTUP_PROBES internally (authored by nrwahl2).
Refactor: various: Drop PCMK_OPT_ENABLE_STARTUP_PROBES internally
Mon, Oct 13, 2:37 PM
nrwahl2 committed rPd86fff0481b0: Refactor: cts-scheduler: Drop enable-startup-probes from inputs (authored by nrwahl2).
Refactor: cts-scheduler: Drop enable-startup-probes from inputs
Mon, Oct 13, 2:37 PM
nrwahl2 committed rP31cd8ec606af: Refactor: libcrmcommon: Move deprecated option aliases to compat header (authored by nrwahl2).
Refactor: libcrmcommon: Move deprecated option aliases to compat header
Mon, Oct 13, 2:37 PM