In T620#11130, @nrwahl2 wrote:In T620#11098, @kgaillot wrote:I think it would make sense if we were designing from scratch, but crm_attribute actually is the intended place for this. It has always been used to manage cluster options as well as node attributes.
Okay, that makes sense for cluster options. I'm still not sure it makes sense to put local options there, or to put meta-attributes for alerts, resources, and ops there.
I'm not at that point yet, still finishing up cluster options, but the rest should move faster with the infrastructure in place and the approach settled on.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jan 30 2024
Jan 30 2024
nrwahl2 updated the task description for T768: Investigate using xmlEncodeEntitiesReentrant() and deprecating crm_xml_escape().
nrwahl2 triaged T768: Investigate using xmlEncodeEntitiesReentrant() and deprecating crm_xml_escape() as Wishlist priority.
Jan 29 2024
Jan 29 2024
Jan 29 2024, 7:07 PM · Pacemaker (3.0.0), Restricted Project, Pacemaker: Documentation, Restricted Project
kgaillot added a comment to T620: Create command-line method of listing all possible meta-attributes, cluster options, and environment variables.
nrwahl2 added a comment to T620: Create command-line method of listing all possible meta-attributes, cluster options, and environment variables.
In T620#11098, @kgaillot wrote:I think it would make sense if we were designing from scratch, but crm_attribute actually is the intended place for this. It has always been used to manage cluster options as well as node attributes.
Jan 29 2024, 2:24 PM · Restricted Project, Restricted Project, Pacemaker (2.1.8), Restricted Project, Restricted Project, Restricted Project
Jan 29 2024, 2:14 PM · Restricted Project, Restricted Project, Pacemaker (2.1.8), Restricted Project, Restricted Project, Restricted Project
shrug
Jan 29 2024, 1:56 PM · Pacemaker (3.0.0), Restricted Project, Pacemaker: Documentation, Restricted Project
kgaillot committed rP790d9d7fd6d9: Log: libcrmservice: drop LSB metadata trace log (authored by kgaillot).
Log: libcrmservice: drop LSB metadata trace log
kgaillot committed rP2bd04d0ca3d1: Log: daemons: return ECONNREFUSED to new clients at shutdown (authored by kgaillot).
Log: daemons: return ECONNREFUSED to new clients at shutdown
kgaillot committed rP6ee2ad91e027: Log: daemons: use ENOMEM for pcmk__new_client() failure (authored by kgaillot).
Log: daemons: use ENOMEM for pcmk__new_client() failure
kgaillot committed rPf79be31b696d: Feature: CIB: deprecate support for rkt in bundles (authored by kgaillot).
Feature: CIB: deprecate support for rkt in bundles
kgaillot committed rP44aaa33faa46: Refactor: libcrmcommon: make PCMK_XE_RKT internal-only (authored by kgaillot).
Refactor: libcrmcommon: make PCMK_XE_RKT internal-only
kgaillot committed rP97e88e01d590: Feature: scheduler: drop support for rules based on #role attribute (authored by kgaillot).
Feature: scheduler: drop support for rules based on #role attribute
kgaillot committed rP4bc04646400e: Doc: Pacemaker Explained: convert rsc_location properties table to list-table (authored by kgaillot).
Doc: Pacemaker Explained: convert rsc_location properties table to list-table
kgaillot committed rP27d90f1248e9: API: libpe_rules,libpe_status: deprecate role member of pe_op_eval_data (authored by kgaillot).
API: libpe_rules,libpe_status: deprecate role member of pe_op_eval_data
kgaillot committed rPc5b0f5bfec28: Doc: Pacemaker Explained: add types to location constraint properties (authored by kgaillot).
Doc: Pacemaker Explained: add types to location constraint properties
kgaillot committed rP8b19f500dda3: Doc: Pacemaker Explained: document role in location constraints (authored by kgaillot).
Doc: Pacemaker Explained: document role in location constraints
kgaillot committed rP6b61e34ab265: Doc: libstonithd,libcrmservice: mark generated agent metadata as OCF 1.1 (authored by kgaillot).
Doc: libstonithd,libcrmservice: mark generated agent metadata as OCF 1.1
GitHub <noreply@github.com> committed rP99c3d285a3de: Merge pull request #3337 from kgaillot/fixes (authored by kgaillot).
Merge pull request #3337 from kgaillot/fixes
nrwahl2 renamed T765: crm_attribute logs assertion if value but no attribute name is given from crm_attribute logs assertion if value but no node name is given to crm_attribute logs assertion if value but no attribute name is given.
nrwahl2 triaged T765: crm_attribute logs assertion if value but no attribute name is given as High priority.
kgaillot added a comment to T620: Create command-line method of listing all possible meta-attributes, cluster options, and environment variables.
In T620#11067, @nrwahl2 wrote:In T620#10980, @kgaillot wrote:If it doesn't require anything outside libcrmcommon, I would put the bulk of it there. When we get to the UI (command-line options), the highest-level equivalents of that should be in libpacemaker.
...
The libcrmcommon functions would do all the processing, and the libpacemaker functions would focus on outputThat's basically the conundrum. Output is the only thing we're dealing with (there's no meaningful processing otherwise), but the output functions need access to an array that lives in libcrmcommon. There are many ways to approach this that would work. The question is which one's the cleanest and most in line with our existing code.
It looks like doxygen implements its own C source scanner. I wonder if it has issues with variadic macros.
Jan 29 2024, 9:25 AM · Pacemaker (3.0.0), Restricted Project, Pacemaker: Documentation, Restricted Project
I assume you are building without -DPCMK__WITH_ATTRIBUTE_OUTPUT_ARGS, right? In that case, PCMK__OUTPUT_ARGS is defined to nothing. So, that's weird.
Jan 29 2024, 9:10 AM · Pacemaker (3.0.0), Restricted Project, Pacemaker: Documentation, Restricted Project
nrwahl2 added a comment to T620: Create command-line method of listing all possible meta-attributes, cluster options, and environment variables.
How do you feel about a new lightweight CLI tool called something like pcmk_option? I think I can get this into crm_attribute relatively easily. It's just that none of these are attributes.
Don't build with -ansi by default
GitHub <noreply@github.com> committed rRfa8a56f68453: Merge pull request #1912 from chrissie-c/no-default-ansi (authored by oalbrigt).
Merge pull request #1912 from chrissie-c/no-default-ansi
Jan 28 2024
Jan 28 2024
Jan 28 2024, 7:11 PM · Pacemaker (3.0.0), Restricted Project, Pacemaker: Documentation, Restricted Project
Jan 28 2024, 6:54 PM · Pacemaker (3.0.0), Restricted Project, Pacemaker: Documentation, Restricted Project
Jan 28 2024, 6:53 PM · Pacemaker (3.0.0), Restricted Project, Pacemaker: Documentation, Restricted Project
Jan 26 2024
Jan 26 2024
nrwahl2 renamed T761: Document "automatic" (on) and "on_target" attributes of stonith device actions from Document "automatic" attribute of stonith device "on" actions to Document "automatic" (on) and "on_target" attributes of stonith device actions.
nrwahl2 triaged T761: Document "automatic" (on) and "on_target" attributes of stonith device actions as Normal priority.
nrwahl2 added a comment to T620: Create command-line method of listing all possible meta-attributes, cluster options, and environment variables.
In T620#10980, @kgaillot wrote:If it doesn't require anything outside libcrmcommon, I would put the bulk of it there. When we get to the UI (command-line options), the highest-level equivalents of that should be in libpacemaker.
...
The libcrmcommon functions would do all the processing, and the libpacemaker functions would focus on output
GitHub <noreply@github.com> committed rRfb7615e1b34d: Merge pull request #1911 from oalbrigt/Filesystem-improve-comment-wait-manpage (authored by oalbrigt).
Merge pull request #1911 from oalbrigt/Filesystem-improve-comment-wait-manpage
oalbrigt committed rR4dd3e0d03a60: Filesystem: add reference to wait manpage to comment (authored by oalbrigt).
Filesystem: add reference to wait manpage to comment
Inform Fabio when it's fixed
Jan 26 2024, 2:14 AM · Pacemaker (2.1.8), Restricted Project, Restricted Project, Restricted Project
Jan 26 2024, 2:13 AM · Pacemaker (2.1.8), Restricted Project, Restricted Project, Restricted Project
Jan 25 2024
Jan 25 2024
clumens committed rP0bb493ec2f69: Refactor: scheduler: Use "xmlNode *" instead of "xmlNodePtr"... (authored by clumens).
Refactor: scheduler: Use "xmlNode *" instead of "xmlNodePtr"...
clumens committed rPb9c67cc58ff0: Refactor: tools: Rename node-list to simple-node-list in crm_node. (authored by clumens).
Refactor: tools: Rename node-list to simple-node-list in crm_node.
clumens committed rPd7a3999f11d0: Low: libpacemaker: Fix a parameter to the cluster-status message. (authored by clumens).
Low: libpacemaker: Fix a parameter to the cluster-status message.
clumens committed rP43a99f21acb3: Refactor: libpacemaker,tools: Cast values being passed to output fns. (authored by clumens).
Refactor: libpacemaker,tools: Cast values being passed to output fns.
GitHub <noreply@github.com> committed rP58c06161dee0: Merge pull request #3336 from clumens/fo-fixes (authored by kgaillot).
Merge pull request #3336 from clumens/fo-fixes
kgaillot updated the task description for T758: Default to sending clone notifications when agent supports it.
Jan 24 2024
Jan 24 2024
kgaillot changed the visibility for T317: Support live migration of clones and the promoted role of promotable clones.
Jan 24 2024, 5:51 PM · Restricted Project, Restricted Project, Restricted Project, Pacemaker: Scheduler
kgaillot moved T759: Support failure handling of notify actions from Miscellaneous to Behavioral changes on the Pacemaker: Future Release Series board.
kgaillot renamed T758: Default to sending clone notifications when agent supports it from Default notify clone meta-attribute to true when agent supports it to Default to sending clone notifications when agent supports it.
kgaillot triaged T758: Default to sending clone notifications when agent supports it as Wishlist priority.
kgaillot triaged T757: Guarantee clone notification variables for actions other than notify as Wishlist priority.
kgaillot triaged T756: Change allowed range of scores and value of +/-INFINITY as Wishlist priority.
kgaillot renamed T317: Support live migration of clones and the promoted role of promotable clones from Support live migration of globally unique clones and the promoted role of promotable clones to Support live migration of clones and the promoted role of promotable clones.
Jan 24 2024, 3:52 PM · Restricted Project, Restricted Project, Restricted Project, Pacemaker: Scheduler
kgaillot added a comment to T620: Create command-line method of listing all possible meta-attributes, cluster options, and environment variables.
In T620#10979, @nrwahl2 wrote:Do we want the "list cluster options" command to go in libpacemaker, or libcrmcommon?
nrwahl2 committed rPa5b571358a52: API: libcrmcommon: New PCMK_XA_NODE_NAME string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XA_NODE_NAME string constant
nrwahl2 committed rP7ff8f67c5802: API: libcrmcommon: New PCMK_XA_NODE_PATH string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XA_NODE_PATH string constant
nrwahl2 committed rPbfdddac2728f: API: libcrmcommon: New PCMK_XA_REMOTE_NODE string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XA_REMOTE_NODE string constant
nrwahl2 committed rPd5b3923bc631: Refactor: libpacemaker, tools: Use PCMK_XE_NODES/STATUS consistently (authored by nrwahl2).
Refactor: libpacemaker, tools: Use PCMK_XE_NODES/STATUS consistently
nrwahl2 committed rPe3ff885018fe: API: libcrmcommon: New PCMK_XE_RESOURCES_CONFIGURED string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XE_RESOURCES_CONFIGURED string constant
nrwahl2 committed rPefae6e5449ef: API: libcrmcommon: New PCMK_XE_NODES_CONFIGURED string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XE_NODES_CONFIGURED string constant
nrwahl2 committed rPf984358a3e73: Refactor: various: Use PCMK_VALUE_ONLINE in more places (authored by nrwahl2).
Refactor: various: Use PCMK_VALUE_ONLINE in more places
nrwahl2 committed rP1c039ffa0cc0: API: libcrmcommon: New PCMK_XE_NODE_WEIGHT string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XE_NODE_WEIGHT string constant
API: libcrmcommon: Deprecate ONLINESTATUS
nrwahl2 committed rPf26e53c5148f: API: libcrmcommon: New PCMK_VALUE_OFFLINE string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_VALUE_OFFLINE string constant
API: libcrmcommon: Deprecate OFFLINESTATUS
nrwahl2 committed rP12964f7a4d18: API: libcrmcommon: New PCMK_XE_OPERATION_HISTORY string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XE_OPERATION_HISTORY string constant
nrwahl2 committed rP21d04276d08e: API: libcrmcommon: New PCMK_XA_OP_KEY string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XA_OP_KEY string constant
nrwahl2 committed rP00ff71087563: Refactor: libpacemaker: Use PCMK_XE_PACEMAKERD (authored by nrwahl2).
Refactor: libpacemaker: Use PCMK_XE_PACEMAKERD
nrwahl2 committed rP3ab77819b02e: API: libcrmcommon: New PCMK_XA_ORPHAN string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XA_ORPHAN string constant
nrwahl2 committed rPd6894b749057: Refactor: libcrmcommon: New PCMK__VALUE_OUTPUT string constant (authored by nrwahl2).
Refactor: libcrmcommon: New PCMK__VALUE_OUTPUT string constant
nrwahl2 committed rP567a9ed6893e: API: libcrmcommon: New PCMK_XE_PODMAN string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XE_PODMAN string constant
nrwahl2 committed rP0d4163783869: API: libcrmcommon: New PCMK_XA_PACEMAKERD_STATE string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XA_PACEMAKERD_STATE string constant
nrwahl2 committed rP19720ef977c1: API: libcrmcommon: New PCMK_XA_PROMOTABLE string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XA_PROMOTABLE string constant
nrwahl2 committed rP7c0b37a28273: API: libcrmcommon: New PCMK_XE_PROMOTION_SCORE string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XE_PROMOTION_SCORE string constant
nrwahl2 committed rP1246158456d6: API: libcrmcommon: New PCMK_XE_PROVIDERS string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XE_PROVIDERS string constant
nrwahl2 committed rP7bedc4794864: API: libcrmcommon: New PCMK_XE_PROVIDER string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XE_PROVIDER string constant
nrwahl2 committed rPa1f35b56ee56: API: libcrmcommon: New PCMK_XE_PSEUDO_ACTION string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XE_PSEUDO_ACTION string constant
nrwahl2 committed rP501525c51d49: API: libcrmcommon: New PCMK_VALUE_NOTHING string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_VALUE_NOTHING string constant
nrwahl2 committed rPb1a39529efed: API: libcrmcommon: New PCMK_XA_QUEUED string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XA_QUEUED string constant
nrwahl2 committed rP3179944a3e49: API: libcrmcommon: New PCMK_XA_QUORUM string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XA_QUORUM string constant
nrwahl2 committed rPbb977644b386: API: libcrmcommon: New PCMK_VALUE_FENCING string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_VALUE_FENCING string constant
nrwahl2 committed rPf040ac93358b: API: libcrmcommon: New PCMK_VALUE_QUORUM string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_VALUE_QUORUM string constant
nrwahl2 committed rP5f6744d59e96: API: libcrmcommon: New PCMK_VALUE_UNFENCING string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_VALUE_UNFENCING string constant
nrwahl2 committed rPe19b5034c37c: Doc: various: Use PCMK_META_REQUIRES and associated constants (authored by nrwahl2).
Doc: various: Use PCMK_META_REQUIRES and associated constants
nrwahl2 committed rPb0ca877fab43: API: libcrmcommon: New PCMK_XA_RC string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XA_RC string constant
nrwahl2 committed rP65120e4b4087: Refactor: libcrmcommon: New PCMK__XA_LINE string constant (authored by nrwahl2).
Refactor: libcrmcommon: New PCMK__XA_LINE string constant
nrwahl2 committed rP4b8f4963c877: Refactor: libcrmcommon: New PCMK__XE_ACK string constant (authored by nrwahl2).
Refactor: libcrmcommon: New PCMK__XE_ACK string constant
nrwahl2 committed rP3bfff612e871: Refactor: libcrmcommon: New PCMK__XE_NACK string constant (authored by nrwahl2).
Refactor: libcrmcommon: New PCMK__XE_NACK string constant
nrwahl2 committed rP75d9b54f1470: Refactor: libcrmcommon: New PCMK__ACTION_POWEROFF string constant (authored by nrwahl2).
Refactor: libcrmcommon: New PCMK__ACTION_POWEROFF string constant
nrwahl2 committed rP9c90816ab3a8: API: libcrmcommon: New PCMK_XA_RC_TEXT string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XA_RC_TEXT string constant
nrwahl2 committed rPbf39377aafe1: API: libcrmcommon: New PCMK_XE_REASON string constant (authored by nrwahl2).
API: libcrmcommon: New PCMK_XE_REASON string constant