Page MenuHomeClusterLabs Projects

clumens (Chris Lumens)
User

Projects

User Details

User Since
Jan 12 2022, 10:04 AM (172 w, 3 d)

Recent Activity

Wed, Apr 30

clumens updated the task description for T985: Pacemaker RHEL 9.7 / 10.1.
Wed, Apr 30, 10:01 AM · Restricted Project
clumens assigned T841: Reject too-large --timeout values in crm_resource to nrwahl2.
Wed, Apr 30, 9:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Apr 29

clumens committed rP24403971be86: Refactor: scheduler: Lower fencing log message to debug level. (authored by clumens).
Refactor: scheduler: Lower fencing log message to debug level.
Tue, Apr 29, 4:36 PM

Thu, Apr 24

clumens removed a project from T785: Fix handling of fence device monitor timeouts: Restricted Project.
Thu, Apr 24, 10:11 AM · Restricted Project, Restricted Project, Pacemaker: Scheduler, Restricted Project, Restricted Project, Restricted Project, Pacemaker: Fencing
clumens removed a project from T983: crm_resource gets stuck deleting failed resource with a constraint: Restricted Project.
Thu, Apr 24, 10:10 AM · Restricted Project, Restricted Project, Restricted Project
clumens removed a project from T984: Potential use-after-free in pacemaker-controld: Restricted Project.
Thu, Apr 24, 10:10 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Apr 21

clumens committed rP965ac014930b: API: libcrmcommon: Ignore the max_size parameter in crm_ipc_new. (authored by clumens).
API: libcrmcommon: Ignore the max_size parameter in crm_ipc_new.
Mon, Apr 21, 9:48 AM
clumens committed rPc2fb2531aae3: Refactor: libcib: Pass 0 to callers of mainloop_add_ipc_client. (authored by clumens).
Refactor: libcib: Pass 0 to callers of mainloop_add_ipc_client.
Mon, Apr 21, 9:48 AM
clumens committed rP1303c7933500: Refactor: libcrmcommon: Pass 0 as the max_size to crm_ipc_new. (authored by clumens).
Refactor: libcrmcommon: Pass 0 as the max_size to crm_ipc_new.
Mon, Apr 21, 9:48 AM
clumens committed rP4906165ffcc8: Refactor: libcrmcommon: Remove ipc_size_max value. (authored by clumens).
Refactor: libcrmcommon: Remove ipc_size_max value.
Mon, Apr 21, 9:48 AM
clumens committed rP9a9470322c6a: Refactor: libcrmcommon: Remove pcmk__ipc_buffer_size. (authored by clumens).
Refactor: libcrmcommon: Remove pcmk__ipc_buffer_size.
Mon, Apr 21, 9:48 AM
clumens committed rP2685bb698922: Refactor: libcrmcommon: Don't compress messages in pcmk__ipc_prepare_iov. (authored by clumens).
Refactor: libcrmcommon: Don't compress messages in pcmk__ipc_prepare_iov.
Mon, Apr 21, 9:48 AM
clumens committed rPc9bd5e18b90c: Refactor: libcrmcommon: No longer check for compression in crm_ipc_send. (authored by clumens).
Refactor: libcrmcommon: No longer check for compression in crm_ipc_send.
Mon, Apr 21, 9:48 AM
clumens committed rP5589b8e06c98: Refactor: libcrmcommon: pcmk__ipc_prepare_iov no longer takes a size. (authored by clumens).
Refactor: libcrmcommon: pcmk__ipc_prepare_iov no longer takes a size.
Mon, Apr 21, 9:48 AM
clumens committed rP8b51a03e8a62: API: libcrmcommon: Deprecate max_size parameter to mainloop_add_ipc_client. (authored by clumens).
API: libcrmcommon: Deprecate max_size parameter to mainloop_add_ipc_client.
Mon, Apr 21, 9:48 AM
clumens committed rP6063d6b70f87: API: libcrmcommon: Deprecate crm_ipc_compressed. (authored by clumens).
API: libcrmcommon: Deprecate crm_ipc_compressed.
Mon, Apr 21, 9:48 AM
clumens committed rP0c436cfc0b9e: Refactor: libcrmcommon: Remove crm_ipc_decompress. (authored by clumens).
Refactor: libcrmcommon: Remove crm_ipc_decompress.
Mon, Apr 21, 9:48 AM
clumens committed rPca32585acecf: Refactor: libcrmcommon: Remove max_buf_size from crm_ipc_s. (authored by clumens).
Refactor: libcrmcommon: Remove max_buf_size from crm_ipc_s.
Mon, Apr 21, 9:48 AM
clumens committed rPbe5a69ecc994: Refactor: Remove references to PCMK_ipc_buffer. (authored by clumens).
Refactor: Remove references to PCMK_ipc_buffer.
Mon, Apr 21, 9:48 AM
clumens committed rP9ae34d26333b: Low: libcrmcommon: Consistently free iov on error. (authored by clumens).
Low: libcrmcommon: Consistently free iov on error.
Mon, Apr 21, 9:48 AM
clumens committed rP23417993eb5f: Refactor: libcrmcommon: Remove size_compressed and size_uncompressed. (authored by clumens).
Refactor: libcrmcommon: Remove size_compressed and size_uncompressed.
Mon, Apr 21, 9:48 AM

Mon, Apr 14

clumens assigned T785: Fix handling of fence device monitor timeouts to nrwahl2.
Mon, Apr 14, 1:10 PM · Restricted Project, Restricted Project, Pacemaker: Scheduler, Restricted Project, Restricted Project, Restricted Project, Pacemaker: Fencing

Wed, Apr 9

clumens updated the task description for T841: Reject too-large --timeout values in crm_resource.
Wed, Apr 9, 1:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Apr 4

clumens updated the task description for T841: Reject too-large --timeout values in crm_resource.
Fri, Apr 4, 3:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens updated the task description for T903: Split large IPC messages.
Fri, Apr 4, 2:33 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens moved T985: Pacemaker RHEL 9.7 / 10.1 from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Fri, Apr 4, 9:32 AM · Restricted Project
clumens updated the task description for T985: Pacemaker RHEL 9.7 / 10.1.
Fri, Apr 4, 9:24 AM · Restricted Project

Apr 3 2025

clumens committed rPa4942b0c3983: Refactor: cts: Remove {fmt} from command strings in cts-cli.in. (authored by clumens).
Refactor: cts: Remove {fmt} from command strings in cts-cli.in.
Apr 3 2025, 5:42 PM
clumens committed rP936169e90300: Refactor: cts: Use {cts_cli_data} as an f-string everywhere. (authored by clumens).
Refactor: cts: Use {cts_cli_data} as an f-string everywhere.
Apr 3 2025, 5:42 PM
clumens committed rPae9f75dcc972: Refactor: cts: Remove the class argument from make_test_group. (authored by clumens).
Refactor: cts: Remove the class argument from make_test_group.
Apr 3 2025, 5:42 PM
clumens committed rP759bafaafce2: Refactor: cts: Replace {shadow} strings in cts-cli everywhere. (authored by clumens).
Refactor: cts: Replace {shadow} strings in cts-cli everywhere.
Apr 3 2025, 5:42 PM
clumens committed rPd71e7ff92fb1: Refactor: cts: Remove apply_substitutions. (authored by clumens).
Refactor: cts: Remove apply_substitutions.
Apr 3 2025, 5:42 PM
clumens committed rP86060a4a8195: Refactor: cts: Be more explicit about converting ExitStatus. (authored by clumens).
Refactor: cts: Be more explicit about converting ExitStatus.
Apr 3 2025, 5:42 PM
clumens committed rPcb74e84191b3: Refactor: cts: Use f-strings throughout cts-cli.in. (authored by clumens).
Refactor: cts: Use f-strings throughout cts-cli.in.
Apr 3 2025, 5:42 PM

Apr 2 2025

clumens triaged T985: Pacemaker RHEL 9.7 / 10.1 as High priority.
Apr 2 2025, 1:17 PM · Restricted Project
clumens moved T841: Reject too-large --timeout values in crm_resource from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 2 2025, 1:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens moved T903: Split large IPC messages from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 2 2025, 1:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens moved T983: crm_resource gets stuck deleting failed resource with a constraint from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 2 2025, 1:15 PM · Restricted Project, Restricted Project, Restricted Project
clumens moved T984: Potential use-after-free in pacemaker-controld from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 2 2025, 1:15 PM · Restricted Project, Restricted Project, Restricted Project
clumens triaged T984: Potential use-after-free in pacemaker-controld as High priority.
Apr 2 2025, 1:14 PM · Restricted Project, Restricted Project, Restricted Project
clumens triaged T983: crm_resource gets stuck deleting failed resource with a constraint as High priority.
Apr 2 2025, 1:10 PM · Restricted Project, Restricted Project, Restricted Project
clumens added a project to T841: Reject too-large --timeout values in crm_resource: Restricted Project.
Apr 2 2025, 12:43 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens added a project to T903: Split large IPC messages: Restricted Project.
Apr 2 2025, 12:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clumens committed rP4e7caee1546d: Refactor: scheduler: Fix formatting in pe_can_fence. (authored by clumens).
Refactor: scheduler: Fix formatting in pe_can_fence.
Apr 2 2025, 11:43 AM
clumens committed rPf342b775615b: Med: scheduler: Require a cluster option for new remote fencing behavior. (authored by clumens).
Med: scheduler: Require a cluster option for new remote fencing behavior.
Apr 2 2025, 11:43 AM
clumens committed rPffe528e69a3c: Med: scheduler: Don't always fence online remote nodes. (authored by clumens).
Med: scheduler: Don't always fence online remote nodes.
Apr 2 2025, 11:43 AM

Apr 1 2025

clumens closed T971: Store inflight and blocked ops in a hash table as Wontfix.

This is no longer necessary for T25, so I'm going to close this. I'm not sure we care enough to implement this.

Apr 1 2025, 4:37 PM · Restricted Project
clumens committed rP90d93ff1d27d: Refactor: libcrmcommon: Improve crm_ipc_flags enum. (authored by clumens).
Refactor: libcrmcommon: Improve crm_ipc_flags enum.
Apr 1 2025, 4:36 PM
clumens committed rP040f91c92b78: Refactor: libcrmcommon: Remove a TODO and unnecessary block of code. (authored by clumens).
Refactor: libcrmcommon: Remove a TODO and unnecessary block of code.
Apr 1 2025, 4:36 PM
clumens committed rP7a1610c2a4e4: Refactor: libcrmcommon: Don't use qb_ipcc_sendv_recv in crm_ipc_send. (authored by clumens).
Refactor: libcrmcommon: Don't use qb_ipcc_sendv_recv in crm_ipc_send.
Apr 1 2025, 4:36 PM
clumens committed rPded0477afe97: Refactor: libcrmcommon: Rearrange internal_ipc_get_reply. (authored by clumens).
Refactor: libcrmcommon: Rearrange internal_ipc_get_reply.
Apr 1 2025, 4:36 PM
clumens committed rP47e84c0d0fb7: Refactor: libcrmcommon: Rearrange send/receive code in crm_ipc_send. (authored by clumens).
Refactor: libcrmcommon: Rearrange send/receive code in crm_ipc_send.
Apr 1 2025, 4:36 PM
clumens committed rPfe3f6d3ad4c9: Refactor: libcrmcommon: Reduce code duplication in crm_ipc_send. (authored by clumens).
Refactor: libcrmcommon: Reduce code duplication in crm_ipc_send.
Apr 1 2025, 4:36 PM
clumens committed rPbd32789ab7e9: Refactor: libcrmcommon: Reduce IPC client receive code duplication. (authored by clumens).
Refactor: libcrmcommon: Reduce IPC client receive code duplication.
Apr 1 2025, 4:36 PM

Mar 31 2025

clumens committed rPf95260d38587: Low: python: Fix setting schema directory in source checkout. (authored by clumens).
Low: python: Fix setting schema directory in source checkout.
Mar 31 2025, 2:44 PM
clumens closed T982: cts-fencing is broken due to bug in validate.py:rng_directory() as Merged by committing rPf95260d38587: Low: python: Fix setting schema directory in source checkout..
Mar 31 2025, 2:44 PM · Restricted Project, Pacemaker, Restricted Project, Restricted Project
clumens committed rPd12f5579859f: Low: cts: Add missing crm_diff regression test back to cts-cli. (authored by clumens).
Low: cts: Add missing crm_diff regression test back to cts-cli.
Mar 31 2025, 2:11 PM
clumens closed T981: crm_diff regression test was removed during conversion to Python as Merged by committing rPd12f5579859f: Low: cts: Add missing crm_diff regression test back to cts-cli..
Mar 31 2025, 2:11 PM · Pacemaker: Tools, Restricted Project, Restricted Project
clumens added a comment to T982: cts-fencing is broken due to bug in validate.py:rng_directory().

That should work - the whole point of that block is basically to check if we're running from a source checkout and if so, set the right schema directory. I bet running this from a source directory where you don't also have PCMK_schema_directory set is something that doesn't happen all that often.

Mar 31 2025, 1:06 PM · Restricted Project, Pacemaker, Restricted Project, Restricted Project
clumens changed the status of T982: cts-fencing is broken due to bug in validate.py:rng_directory() from Open to WIP.
Mar 31 2025, 12:26 PM · Restricted Project, Pacemaker, Restricted Project, Restricted Project
clumens changed the status of T981: crm_diff regression test was removed during conversion to Python from Open to WIP.
Mar 31 2025, 12:15 PM · Pacemaker: Tools, Restricted Project, Restricted Project

Mar 25 2025

clumens committed rPe892b0648932: Refactor: libcrmcommon: Improve crm_ipc_flags enum. (authored by clumens).
Refactor: libcrmcommon: Improve crm_ipc_flags enum.
Mar 25 2025, 6:59 AM
clumens committed rPa5deef0b11eb: Refactor: libcrmcommon: Don't use qb_ipcc_sendv_recv in crm_ipc_send. (authored by clumens).
Refactor: libcrmcommon: Don't use qb_ipcc_sendv_recv in crm_ipc_send.
Mar 25 2025, 6:59 AM
clumens committed rP5a163f3d3cd9: Refactor: libcrmcommon: Remove a TODO and unnecessary block of code. (authored by clumens).
Refactor: libcrmcommon: Remove a TODO and unnecessary block of code.
Mar 25 2025, 6:59 AM
clumens committed rP3b0e24827213: Refactor: libcrmcommon: Rearrange send/receive code in crm_ipc_send. (authored by clumens).
Refactor: libcrmcommon: Rearrange send/receive code in crm_ipc_send.
Mar 25 2025, 6:59 AM
clumens committed rP1422d8f46609: Refactor: libcrmcommon: Reduce code duplication in crm_ipc_send. (authored by clumens).
Refactor: libcrmcommon: Reduce code duplication in crm_ipc_send.
Mar 25 2025, 6:59 AM
clumens committed rPa6e157e60b67: Refactor: libcrmcommon: Rearrange internal_ipc_get_reply. (authored by clumens).
Refactor: libcrmcommon: Rearrange internal_ipc_get_reply.
Mar 25 2025, 6:59 AM
clumens committed rP527ce24cfea2: Refactor: libcrmcommon: Reduce IPC client receive code duplication. (authored by clumens).
Refactor: libcrmcommon: Reduce IPC client receive code duplication.
Mar 25 2025, 6:59 AM

Mar 19 2025

clumens added a project to T979: crmadmin error output is redundant: Restricted Project.
Mar 19 2025, 9:39 AM · Restricted Project, Restricted Project
clumens triaged T979: crmadmin error output is redundant as Low priority.
Mar 19 2025, 9:37 AM · Restricted Project, Restricted Project

Mar 18 2025

clumens added a comment to T966: Avoid blocking wait in controller for CIB re-request.

@waltdisgrace Adding a mainloop timer here is definitely the way to go. If you haven't looked at the mainloop stuff before (especially glib's implementation and what we've built on top of it), this could be a little bit confusing. The basic idea is that we fake being multithreaded by looping over a queue of events that can come from various sources like file or network IO, UNIX signals, periodic or one-off timers, and so forth. Using the main loop allows us to avoid blocking other work from happening.

Mar 18 2025, 3:33 PM · Restricted Project, Restricted Project, Restricted Project
clumens assigned T966: Avoid blocking wait in controller for CIB re-request to waltdisgrace.
Mar 18 2025, 3:28 PM · Restricted Project, Restricted Project, Restricted Project
clumens added a comment to T845: Don't allow id-ref to parent rule within nested rule.

@waltdisgrace Start by adding a unit test to verify that the pacemaker library still just segfaults on that input. I think lib/common/tests/xml_idref/pcmk__xe_dereference_children_test.c would be as good a place as any for this, but @nrwahl2 might have a better suggestion. I can then help you make sense of the segfault and we can figure out where to throw an error.

Mar 18 2025, 3:09 PM · Restricted Project, Pacemaker: Scheduler, Restricted Project
clumens assigned T845: Don't allow id-ref to parent rule within nested rule to waltdisgrace.
Mar 18 2025, 3:07 PM · Restricted Project, Pacemaker: Scheduler, Restricted Project
clumens assigned T907: Map Corosync error codes to Pacemaker error codes to waltdisgrace.
Mar 18 2025, 2:58 PM · Restricted Project, Restricted Project, Restricted Project
clumens added a comment to T890: Log errors in pcmk_parse_interval_spec() callers.

Additionally, it would be nice to have a unit test or two for this function. Most of what it does is call another function, several of which are already unit tested, but checking that the inputs/outputs are as expected would be good.

Mar 18 2025, 2:57 PM · Restricted Project, Restricted Project
clumens assigned T890: Log errors in pcmk_parse_interval_spec() callers to waltdisgrace.
Mar 18 2025, 2:55 PM · Restricted Project, Restricted Project

Mar 13 2025

clumens committed rPdac88ca0fa3d: Refactor: libcrmservice: New services__copy_result() function (authored by nrwahl2).
Refactor: libcrmservice: New services__copy_result() function
Mar 13 2025, 1:05 PM
clumens committed rP283225383916: Refactor: libcrmservice: Store systemd job path in svc_action_private_t (authored by nrwahl2).
Refactor: libcrmservice: Store systemd job path in svc_action_private_t
Mar 13 2025, 1:05 PM
clumens committed rP373a7a317023: Fix: various: Correctly detect completion of systemd start/stop actions (authored by clumens).
Fix: various: Correctly detect completion of systemd start/stop actions
Mar 13 2025, 1:05 PM
clumens committed rP67c1821648f3: Refactor: libcrmservice: Subscribe to systemd D-Bus signals (authored by clumens).
Refactor: libcrmservice: Subscribe to systemd D-Bus signals
Mar 13 2025, 1:05 PM
clumens committed rP656ec99b060e: Refactor: daemons: Unindent the goagain block in action_complete. (authored by clumens).
Refactor: daemons: Unindent the goagain block in action_complete.
Mar 13 2025, 10:10 AM
clumens committed rP031e8a5bac5d: Refactor: libcrmservice: systemd_init should return a bool. (authored by clumens).
Refactor: libcrmservice: systemd_init should return a bool.
Mar 13 2025, 10:10 AM
clumens committed rPe182eb7d61fb: Low: libcrmservices: Don't leak msg if systemd_proxy is NULL. (authored by clumens).
Low: libcrmservices: Don't leak msg if systemd_proxy is NULL.
Mar 13 2025, 10:10 AM
clumens committed rPfc0ef6cd7a35: Refactor: libcrmservices: Unref the dbus connection... (authored by clumens).
Refactor: libcrmservices: Unref the dbus connection...
Mar 13 2025, 10:10 AM

Mar 11 2025

clumens committed rP28f614c5e4e9: Refactor: libcrmservice: Improve error checks in systemd_service_name() (authored by nrwahl2).
Refactor: libcrmservice: Improve error checks in systemd_service_name()
Mar 11 2025, 8:40 PM
clumens committed rP7cf68fd3a838: Refactor: libcrmservice: Fail systemd rsc start if create override fails (authored by nrwahl2).
Refactor: libcrmservice: Fail systemd rsc start if create override fails
Mar 11 2025, 8:40 PM
clumens committed rP501bf0591493: Refactor: libcrmservice: Check for empty arg in invoke_unit_by_name() (authored by nrwahl2).
Refactor: libcrmservice: Check for empty arg in invoke_unit_by_name()
Mar 11 2025, 8:40 PM
clumens committed rP23f38b324654: Refactor: libcrmservice: Avoid gboolean/gchar in systemd_unit_exists() (authored by nrwahl2).
Refactor: libcrmservice: Avoid gboolean/gchar in systemd_unit_exists()
Mar 11 2025, 8:40 PM
clumens committed rPdbd823befed4: Refactor: libcrmservice: Defunctionize create_world_readable() (authored by nrwahl2).
Refactor: libcrmservice: Defunctionize create_world_readable()
Mar 11 2025, 8:40 PM
clumens committed rP458df80960c6: Refactor: libcrmservice: Simplify systemd override path getters (authored by nrwahl2).
Refactor: libcrmservice: Simplify systemd override path getters
Mar 11 2025, 8:40 PM
clumens committed rP13074ae9e325: Refactor: libcrmcommon: Drop check for unused flag from str_any_of() (authored by nrwahl2).
Refactor: libcrmcommon: Drop check for unused flag from str_any_of()
Mar 11 2025, 8:40 PM
clumens committed rP89e737154902: Low: libcrmservice: Fix overrides for systemd resources (authored by nrwahl2).
Low: libcrmservice: Fix overrides for systemd resources
Mar 11 2025, 8:40 PM
clumens committed rP03410d37ee8d: Refactor: tools: NULL-check args in cli_resource_print() (authored by nrwahl2).
Refactor: tools: NULL-check args in cli_resource_print()
Mar 11 2025, 8:40 PM
clumens committed rP3b2e759224a3: Refactor: tools: NULL-check scheduler arg of cli_resource_move() (authored by nrwahl2).
Refactor: tools: NULL-check scheduler arg of cli_resource_move()
Mar 11 2025, 8:40 PM
clumens committed rP43d0674f2391: Refactor: tools: NULL-check scheduler arg of cli_cleanup_all() (authored by nrwahl2).
Refactor: tools: NULL-check scheduler arg of cli_cleanup_all()
Mar 11 2025, 8:40 PM
clumens committed rPdb372f971e58: Refactor: tools: NULL-check scheduler arg in cli_resource_fail() (authored by nrwahl2).
Refactor: tools: NULL-check scheduler arg in cli_resource_fail()
Mar 11 2025, 8:40 PM
clumens committed rPa80c1b2df67c: Doc: libcrmservice: Suppress Coverity false positives (authored by nrwahl2).
Doc: libcrmservice: Suppress Coverity false positives
Mar 11 2025, 8:40 PM
clumens committed rPbc4c4ae72e1f: Doc: tools: Suppress Coverity false positives in crm_resource.c (authored by nrwahl2).
Doc: tools: Suppress Coverity false positives in crm_resource.c
Mar 11 2025, 8:40 PM

Mar 5 2025

clumens committed rBfd679976bb8f: Refactor: Unindent various code blocks in transport.c. (authored by clumens).
Refactor: Unindent various code blocks in transport.c.
Mar 5 2025, 5:23 PM