User Details
- User Since
- Jan 12 2022, 10:04 AM (169 w, 4 d)
Wed, Apr 9
Fri, Apr 4
Thu, Apr 3
Wed, Apr 2
Tue, Apr 1
This is no longer necessary for T25, so I'm going to close this. I'm not sure we care enough to implement this.
Mon, Mar 31
That should work - the whole point of that block is basically to check if we're running from a source checkout and if so, set the right schema directory. I bet running this from a source directory where you don't also have PCMK_schema_directory set is something that doesn't happen all that often.
Tue, Mar 25
Wed, Mar 19
Tue, Mar 18
@waltdisgrace Adding a mainloop timer here is definitely the way to go. If you haven't looked at the mainloop stuff before (especially glib's implementation and what we've built on top of it), this could be a little bit confusing. The basic idea is that we fake being multithreaded by looping over a queue of events that can come from various sources like file or network IO, UNIX signals, periodic or one-off timers, and so forth. Using the main loop allows us to avoid blocking other work from happening.
@waltdisgrace Start by adding a unit test to verify that the pacemaker library still just segfaults on that input. I think lib/common/tests/xml_idref/pcmk__xe_dereference_children_test.c would be as good a place as any for this, but @nrwahl2 might have a better suggestion. I can then help you make sense of the segfault and we can figure out where to throw an error.
Additionally, it would be nice to have a unit test or two for this function. Most of what it does is call another function, several of which are already unit tested, but checking that the inputs/outputs are as expected would be good.