Merge pull request #2258 from kgaillot/best-practices
1e5e3b11ce8e
Actions

Description

Merge pull request #2258 from kgaillot/best-practices

Best practices for libcrmcluster

Details

Provenance

kgaillot	Authored on Dec 14 2020, 1:29 PM
GitHub <noreply@github.com>	Committed on Dec 14 2020, 1:29 PM

Parents

rP8f339d8a0df2: Refactor: libcrmcluster,daemons: best practices for node cache functions
rP80775494cd50: Merge pull request #2255 from clumens/empty-resource-list

Branches

Unknown

Tags

Unknown

Event Timeline

Merged Changes

8f339d8a0df2 Refactor: libcrmcluster,daemons: best practices for node cache functions
Author
kgaillot
Browse Repository
No Audits
f28027ca244d API: libcrmcluster: deprecate crm_terminate_member()…
Author
kgaillot
Browse Repository
No Audits
defd2d561eae Refactor: libcrmcluster: best practices for election code
Author
kgaillot
Browse Repository
No Audits
460a092a5c12 Refactor: pacemakerd,libcrmcluster: rename Corosync error message function
Author
kgaillot
Browse Repository
No Audits
d971d1464667 Refactor: libcrmcluster: move proc flag text function to source file
Author
kgaillot
Browse Repository
No Audits
5cfa67bacd87 Refactor: pacemakerd: remove dead code
Author
kgaillot
Browse Repository
No Audits
53b7471304f8 Refactor: libcrmcluster: move CPG functions/macros to source file
Author
kgaillot
Browse Repository
No Audits
bd299b328c5e Refactor: libcrmcluster: move node flag wrappers to only file that uses them
Author
kgaillot
Browse Repository
No Audits
3ab14aa38108 Refactor: libcrmcluster: comment and format header a little better
Author
kgaillot
Browse Repository
No Audits
a458e1d6c1ce Refactor: libcrmcluster: best practices for CPG-related functions
Author
kgaillot
Browse Repository
No Audits
7f85e30c4257 Refactor: libcrmcluster: make a macro more sensible
Author
kgaillot
Browse Repository
No Audits
142a2fcafc51 Low: libcrmcluster: properly check CPG payload size
Author
kgaillot
Browse Repository
No Audits
f0ae9051b166 Refactor: libcrmcluster: use proper types in CPG flush function
Author
kgaillot
Browse Repository
No Audits
19fa2f031478 Refactor: libcrmcluster: get rid of CPG iov sending function
Author
kgaillot
Browse Repository
No Audits
95e537bbd32d Refactor: libcrmcluster: make CPG message sending function private to library
Author
kgaillot
Browse Repository
No Audits
e4fc56d594be Refactor: libcrmcluster: remove unused variable
Author
kgaillot
Browse Repository
No Audits
8851eb8dcb37 Refactor: libcrmcluster: best practices for Corosync-related functions
Author
kgaillot
Browse Repository
No Audits
a0142b698c57 Refactor: libcrmcluster: remove unused function arguments
Author
kgaillot
Browse Repository
No Audits
8f309a842101 Refactor: libcrmcluster: redo nodelist check
Author
kgaillot
Browse Repository
No Audits
52cc51b73876 Refactor: libcrmcluster: avoid unnecessary function
Author
kgaillot
Browse Repository
No Audits
d9e080953f74 Refactor: libcrmcluster: use library-private header for Corosync functions
Author
kgaillot
Browse Repository
No Audits
89a5342e1256 Refactor: libcrmcluster: move message validation function to where it's used
Author
kgaillot
Browse Repository
No Audits
a1ce8493f6cf Low: libcrmcluster: correctly return error for invalid payload size
Author
kgaillot
Browse Repository
No Audits
cacf9f3cdcd4 Test: CTS: update pattern for cluster connection log
Author
kgaillot
Browse Repository
No Audits
45ddc0b86ded Refactor: libcrmcluster: best practices for cluster functions
Author
kgaillot
Browse Repository
No Audits
c2607e29359b Refactor: libcrmcluster: move node name validation function to only file that…
Author
kgaillot
Browse Repository
No Audits
b2a7128d178f Refactor: libcrmcluster: drop unused internal function
Author
kgaillot
Browse Repository
No Audits

Changes (29)

Path

Size

cts/

CTStests.py

daemons/

attrd/

based/

controld/

controld_join_client.c

controld_join_dc.c

controld_membership.c

controld_messages.c

controld_remote_ra.c

controld_schedulerd.c

controld_te_actions.c

fenced/

pacemakerd/

include/

crm/

cluster.h

cluster/

internal.h

lib/

cluster/

rP1e5e3b11ce8e

View Options

cts/CTStests.py

View Options

daemons/attrd/attrd_commands.c

View Options

daemons/based/based_messages.c

View Options

daemons/controld/controld_corosync.c

View Options

daemons/controld/controld_election.c

View Options

daemons/controld/controld_fencing.c

View Options

daemons/controld/controld_join_client.c

View Options

daemons/controld/controld_join_dc.c

View Options

daemons/controld/controld_membership.c

View Options

daemons/controld/controld_messages.c

View Options

daemons/controld/controld_remote_ra.c

View Options

daemons/controld/controld_schedulerd.c

View Options

daemons/controld/controld_te_actions.c

View Options

daemons/controld/controld_utils.c

View Options

daemons/fenced/fenced_commands.c

View Options

daemons/fenced/fenced_history.c

View Options

daemons/fenced/fenced_remote.c

View Options

daemons/fenced/pacemaker-fenced.c

View Options

daemons/pacemakerd/pacemakerd.c

View Options

daemons/pacemakerd/pcmkd_corosync.c

View Options

include/crm/cluster.h

View Options

include/crm/cluster/internal.h

View Options

lib/cluster/Makefile.am

View Options

lib/cluster/cluster.c

View Options

lib/cluster/corosync.c

View Options

lib/cluster/cpg.c

View Options

lib/cluster/crmcluster_private.h

View Options

lib/cluster/election.c

View Options

Merge pull request #2258 from kgaillot/best-practices1e5e3b11ce8eActions

Description

Details

Event Timeline

Merged Changes

Changes (29)

rP1e5e3b11ce8e

cts/CTStests.py

daemons/attrd/attrd_commands.c

daemons/based/based_messages.c

daemons/controld/controld_corosync.c

daemons/controld/controld_election.c

daemons/controld/controld_fencing.c

daemons/controld/controld_join_client.c

daemons/controld/controld_join_dc.c

daemons/controld/controld_membership.c

daemons/controld/controld_messages.c

daemons/controld/controld_remote_ra.c

daemons/controld/controld_schedulerd.c

daemons/controld/controld_te_actions.c

daemons/controld/controld_utils.c

daemons/fenced/fenced_commands.c

daemons/fenced/fenced_history.c

daemons/fenced/fenced_remote.c

daemons/fenced/pacemaker-fenced.c

daemons/pacemakerd/pacemakerd.c

daemons/pacemakerd/pcmkd_corosync.c

include/crm/cluster.h

include/crm/cluster/internal.h

lib/cluster/Makefile.am

lib/cluster/cluster.c

lib/cluster/corosync.c

lib/cluster/cpg.c

lib/cluster/crmcluster_private.h

lib/cluster/election.c

lib/cluster/membership.c

Merge pull request #2258 from kgaillot/best-practices
1e5e3b11ce8e
Actions